From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: split out display quirks to a new file
Date: Tue, 16 Oct 2018 18:10:34 +0300 [thread overview]
Message-ID: <87woqij5at.fsf@intel.com> (raw)
In-Reply-To: <153970174597.22931.17603984818867714231@skylake-alporthouse-com>
On Tue, 16 Oct 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2018-10-16 15:42:27)
>> Reduce intel_display.c by splitting out intel_quirks.c. No functional
>> changes.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> I was thinking intel_display_quirks, but it is dev_priv->quirks so that
> seems over specific.
Yeah, looks like you're even using dev_priv->quirks in gem code,
although it's not being initialized by the code at hand.
BR,
Jani.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-16 15:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 14:42 [PATCH 1/2] drm/i915: split out display quirks to a new file Jani Nikula
2018-10-16 14:42 ` [PATCH 2/2] drm/i915/quirks: pass dev_priv instead of drm dev to quirk code Jani Nikula
2018-10-16 14:56 ` Chris Wilson
2018-10-16 15:09 ` Jani Nikula
2018-10-16 15:13 ` Chris Wilson
2018-10-16 14:55 ` [PATCH 1/2] drm/i915: split out display quirks to a new file Chris Wilson
2018-10-16 15:10 ` Jani Nikula [this message]
2018-10-17 9:36 ` Jani Nikula
2018-10-16 14:57 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] " Patchwork
2018-10-16 14:59 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-10-16 15:23 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-16 17:27 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woqij5at.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).