intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Cc: "puthik@chromium.org" <puthik@chromium.org>,
	"Vetter, Daniel" <daniel.vetter@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Tc, Jenny" <jenny.tc@intel.com>,
	"Weinehall, David" <david.weinehall@intel.com>
Subject: Re: [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later
Date: Mon, 31 Jul 2017 13:55:02 +0300	[thread overview]
Message-ID: <87wp6oj2pl.fsf@nikula.org> (raw)
In-Reply-To: <CANCcNXciimkyFdMo-dhcdqbeFJhC-+jAs4DNhrj5oUJZ4DFfXw@mail.gmail.com>

On Mon, 24 Jul 2017, Puthikorn Voravootivat <puthik@chromium.org> wrote:
> I saw a DP 1.3 panel that advertise AUX backlight brightness control
> but not working properly. So it should work but not in real world.
> I think that is good reason enough to add this as a heuristic.

Are you suggesting the one panel you mention is representative of the
real world?

Granted, the original aux backlight implementation supported a very
narrow selection of panels. I believe this is the very reason you are
working on this patch series.

But now you're suggesting another arbitrary narrow selection of panels
based on limited evidence.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-07-31 10:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-19 10:29 [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later Jenny TC
2017-07-19 11:50 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-07-19 18:22 ` [PATCH] " Pandiyan, Dhinakaran
2017-07-20  9:33   ` Jani Nikula
2017-07-20 10:06     ` Tc, Jenny
2017-07-20 20:27       ` Pandiyan, Dhinakaran
2017-07-24 23:15         ` Puthikorn Voravootivat
2017-07-25 12:41           ` David Weinehall
2017-07-25 13:11             ` David Weinehall
2017-07-31 10:55           ` Jani Nikula [this message]
2017-07-31 22:41             ` Puthikorn Voravootivat
2017-08-01 23:15               ` Pandiyan, Dhinakaran
2017-08-02 13:53                 ` David Weinehall
2017-07-20 15:35     ` David Weinehall
2017-07-20 18:20       ` Pandiyan, Dhinakaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp6oj2pl.fsf@nikula.org \
    --to=jani.nikula@linux.intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=david.weinehall@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jenny.tc@intel.com \
    --cc=puthik@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).