From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 3/4] drm/i915: Restore GMBUS operation after a failed bit-banging fallback Date: Mon, 11 Apr 2016 12:50:44 +0300 Message-ID: <87wpo4tqx7.fsf@intel.com> References: <1457366220-29409-1-git-send-email-ville.syrjala@linux.intel.com> <1457366220-29409-4-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id F13136E2D4 for ; Mon, 11 Apr 2016 09:50:46 +0000 (UTC) In-Reply-To: <1457366220-29409-4-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAwNyBNYXIgMjAxNiwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pgo+IFdoZW4gdGhlIEdNQlVTIGJhc2VkIGkyYyB0cmFuc2ZlciB0aW1lcyBvdXQsIHdlIHRyeSB0 byBmYWxsIGJhY2sgdG8KPiBiaXQtYmFuZ2luZyBhbmQgcmV0cnkgdGhlIG9wZXJhdGlvbiB0aGF0 IHdheS4gSG93ZXZlciBpZiB0aGUgYml0LWJhbmdpbmcKPiBhdHRlbXB0IGFsc28gZmFpbHMsIHdl IHNob3VsZCBwcm9iYWJseSBnbyBiYWNrIHRvIHRoZSBHTUJVUyBtZXRob2QgZm9yCj4gdGhlIG5l eHQgYXR0ZW1wdC4gTWF5YmUgdGhlcmUgc2ltcGx5IHdhc24ndCBhbnlvbmUgb25lIHRoZSBidXMg YXQgdGhpcwo+IHRpbWUuCj4KPiBUaGVyZSdzIGFsc28gYSBiaXQgb2YgYSBtZXNzIGdvaW5nIG9u IHdpdGggdGhlIGZvcmNlX2JpdCBoYW5kbGluZy4KPiBJdCdzIHN1cHBvc2VkIHRvIGJlIGEgcmVm IGNvdW50IGFjdHVhbGx5LCBhbmQgaXQgaXMgYXMgZmFyIGFzCj4gaW50ZWxfZ21idXNfZm9yY2Vf Yml0KCkgaXMgY29uY2VybmVkLiBCdXQgaXQncyB0cmVhdGVkIGFzIGp1c3QgYQo+IGZsYWcgYnkg dGhlIHRpbWVvdXQgYmFzZWQgYml0LWJhbmdpbmcgZmFsbGJhY2suIEkgc3VwcG9zZSB0aGF0J3MK PiBmaW5lIHNpbmNlIHdlIHNob3VsZCBuZXZlciBlbmQgdXAgaW4gdGhlIHRpbWVvdXQgZmFsbGJh Y2sgY2FzZQo+IGlmIGZvcmNlX2JpdCB3YXMgYWxyZWFkeSBub24temVyby4gSG93ZXZlciBub3cg dGhhdCB3ZSB3YW50IHRvIHJlc3RvcmUKPiB0aGluZ3MgYmFjayB0byB3aGVyZSB0aGV5IHdlcmUg YWZ0ZXIgdGhlIGJpdC1iYW5naW5nIGF0dGVtcHQgZmFpbGVkLAo+IHdlJ3JlIGdvaW5nIHRvIGhh dmUgdG8gZG8gdGhpbmdzIGEgYml0IGRpZmZlcmVudGx5IHRvIGF2b2lkIGNsb2JiZXJpbmcKPiB0 aGUgZm9yY2VfYml0IGNvdW50IGFzIHNldCB1cCBieSBpbnRlbF9nbWJ1c19mb3JjZV9iaXQoKS4g U28gbGV0J3MKPiBkZWRpY2F0ZSB0aGUgaGlnaCBiaXQgYXMgYSBmbGFnIGZvciB0aGUgbG93IGxl dmVsIHRpbWVvdXQgYmFzZWQgZmFsbGJhY2sKPiBhbmQgdHJlYXQgdGhlIHJlc3Qgb2YgdGhlIGJp dHMgYXMgYSByZWYgY291bnQganVzdCBhcyBiZWZvcmUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICB8ICAxICsKPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfaTJjLmMgfCAxMCArKysrKysrLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5k ZXggZjM3YWMxMjBhMjlkLi4yMzQ4ZmVhNTk1OTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmgKPiBAQCAtMTA0Myw2ICsxMDQzLDcgQEAgc3RydWN0IGludGVsX2ZiY193b3JrOwo+ICAKPiAg c3RydWN0IGludGVsX2dtYnVzIHsKPiAgCXN0cnVjdCBpMmNfYWRhcHRlciBhZGFwdGVyOwo+ICsj ZGVmaW5lIEdNQlVTX0ZPUkNFX0JJVF9SRVRSWSAoMVUgPDwgMzEpCj4gIAl1MzIgZm9yY2VfYml0 Owo+ICAJdTMyIHJlZzA7Cj4gIAlpOTE1X3JlZ190IGdwaW9fcmVnOwo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9pMmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2kyYy5jCj4gaW5kZXggN2JmOGE0ODVlMThmLi41ZDRiMzYwNGFmZDIgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaTJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9pMmMuYwo+IEBAIC01NzksNyArNTc5LDYgQEAgdGltZW91dDoKPiAgCSAq IEhhcmR3YXJlIG1heSBub3Qgc3VwcG9ydCBHTUJVUyBvdmVyIHRoZXNlIHBpbnM/IFRyeSBHUElP IGJpdGJhbmdpbmcKPiAgCSAqIGluc3RlYWQuIFVzZSBFQUdBSU4gdG8gaGF2ZSBpMmMgY29yZSBy ZXRyeS4KPiAgCSAqLwo+IC0JYnVzLT5mb3JjZV9iaXQgPSAxOwo+ICAJcmV0ID0gLUVBR0FJTjsK PiAgCj4gIG91dDoKPiBAQCAtNTk3LDEwICs1OTYsMTUgQEAgZ21idXNfeGZlcihzdHJ1Y3QgaTJj X2FkYXB0ZXIgKmFkYXB0ZXIsIHN0cnVjdCBpMmNfbXNnICptc2dzLCBpbnQgbnVtKQo+ICAJaW50 ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYsIFBPV0VSX0RPTUFJTl9HTUJVUyk7Cj4gIAlt dXRleF9sb2NrKCZkZXZfcHJpdi0+Z21idXNfbXV0ZXgpOwo+ICAKPiAtCWlmIChidXMtPmZvcmNl X2JpdCkKPiArCWlmIChidXMtPmZvcmNlX2JpdCkgewo+ICAJCXJldCA9IGkyY19iaXRfYWxnby5t YXN0ZXJfeGZlcihhZGFwdGVyLCBtc2dzLCBudW0pOwo+IC0JZWxzZQo+ICsJCWlmIChyZXQgPCAw KQo+ICsJCQlidXMtPmZvcmNlX2JpdCAmPSB+R01CVVNfRk9SQ0VfQklUX1JFVFJZOwo+ICsJfSBl bHNlIHsKPiAgCQlyZXQgPSBkb19nbWJ1c194ZmVyKGFkYXB0ZXIsIG1zZ3MsIG51bSk7Cj4gKwkJ aWYgKHJldCA9PSAtRUFHQUlOKQo+ICsJCQlidXMtPmZvcmNlX2JpdCB8PSBHTUJVU19GT1JDRV9C SVRfUkVUUlk7CgpIbW0sIHdvdWxkIHRoaXMgYWxsIGJlIHNpbXBsZXIgaWYgd2UgZGlkIHRoZSBm aXJzdCBiaXQtYmFuZ2luZyByZXRyeQpoZXJlIG91cnNlbHZlcyBhZnRlciBhbGwsIGFuZCBzZXQg LT5mb3JjZV9iaXQgb25seSBpZiBiaXQtYmFuZ2luZwpzdWNjZWVkcyBhZnRlciBnbWJ1cyAtRUFH QUlOPyBJIHRoaW5rIG1vdmluZyB0aGUgcmV0cnkgb3V0IG9mCmRvX2dtYnVzX3hmZXIoKSB3YXMg dGhlIHJpZ2h0IHRoaW5nIHRvIGRvIHRvLCBidXQgbWF5YmUgSSB3ZW50IHRvbyBmYXIKYnkgcHVz aGluZyBpdCBhbGwgdGhlIHdheSB0byBpMmMgY29yZT8KCkFueXdheSwgdGhpcyBwYXRjaCBsb29r cyBnb29kLCBidXQgaXQncyBqdXN0IGEgYml0IHN1YnRsZSB3aXRoIHRoZQotRUFHQUlOIGFuZCBv bmUgcmV0cnkgYW5kIGFsbC4KClVwIHRvIHlvdS4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8 amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKPiArCX0KPiAgCj4gIAltdXRleF91bmxvY2soJmRldl9w cml2LT5nbWJ1c19tdXRleCk7Cj4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwg UE9XRVJfRE9NQUlOX0dNQlVTKTsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2Ug VGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==