From: Jani Nikula <jani.nikula@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: Andreas Reis <andreas.reis@gmail.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Emil Renner Berthing <kernel@esmil.dk>
Subject: Re: [PATCH] drm/i915: Add primary plane to mask if it's visible
Date: Wed, 23 Sep 2015 15:19:37 +0300 [thread overview]
Message-ID: <87wpvhnx9i.fsf@intel.com> (raw)
In-Reply-To: <5602887D.3020502@linux.intel.com>
On Wed, 23 Sep 2015, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote:
> Hey,
>
> Op 23-09-15 om 12:29 schreef Jani Nikula:
>> On Wed, 23 Sep 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
>>> On Tue, Sep 15, 2015 at 02:28:54PM +0200, Maarten Lankhorst wrote:
>>>> This fixes the warnings like
>>>>
>>>> "plane A assertion failure, should be disabled but not"
>>>>
>>>> that on the initial modeset during boot. This can happen if
>>>> the primary plane is enabled by the firmware, but inheriting
>>>> it fails because the DMAR is active or for other reasons.
>>>>
>>>> Reported-By: Andreas Reis <andreas.reis@gmail.com>
>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91429
>>>> Reported-and-Tested-by: Emil Renner Berthing <kernel@esmil.dk>
>>> Tested-by: Andreas Reis <andreas.reis@gmail.com>
>>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>>
>>> Most likely caused by
>>>
>>> commit 36750f284b3a4f19b304fda1bb7d6e9e1275ea8d
>>> Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> Date: Mon Jun 1 12:49:54 2015 +0200
>>>
>>> drm/i915: update plane state during init
>>>
>>> which is in 4.3, so this of for Jani.
>> What's the deal with this patch wrt
>>
>> commit f9cd7b881a042dcc8f1b1236ecea6deb3eb4d5bd
>> Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Date: Thu Sep 10 18:59:08 2015 +0300
>>
>> drm/i915: Move sprite/cursor plane disable to intel_sanitize_crtc()
>>
>> i.e. do we need a different patch for drm-intel-next-queued?
>>
> Indeed, and a different patch for v4.2 which you commented on. :-)
> crtc_mask needs to be updated here if plane_state->visible is true.
Okay, I pushed the patch do drm-intel-fixes, thanks for the patch and
review. I resolving the conflict on nightly rebuild with what's in
drm-intel-next-queued. Please send another patch against dinq.
BR,
Jani.
>
> ~Maarten
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-09-23 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 12:28 [PATCH] drm/i915: Add primary plane to mask if it's visible Maarten Lankhorst
2015-09-23 9:49 ` Daniel Vetter
2015-09-23 10:29 ` Jani Nikula
2015-09-23 11:09 ` Maarten Lankhorst
2015-09-23 12:19 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpvhnx9i.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=andreas.reis@gmail.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel@esmil.dk \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox