From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2 v2 addendum v2] drm/i915: Allow parsing of variable size child device entries from VBT Date: Fri, 14 Aug 2015 11:42:06 +0300 Message-ID: <87wpwyqn1d.fsf@intel.com> References: <1436526655-2965-1-git-send-email-antti.koskipaa@linux.intel.com> <1436526655-2965-2-git-send-email-antti.koskipaa@linux.intel.com> <20150804135552.GC6150@boom> <20150805085900.GM17734@phenom.ffwll.local> <55C3682E.6080103@intel.com> <20150806140855.GE6150@boom> <20150806153102.GW17734@phenom.ffwll.local> <20150812102917.GL6150@boom> <8737zotwqw.fsf@intel.com> <20150813131415.GO6150@boom> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B0C36EEC4 for ; Fri, 14 Aug 2015 01:39:13 -0700 (PDT) In-Reply-To: <20150813131415.GO6150@boom> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: David Weinehall Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxMyBBdWcgMjAxNSwgRGF2aWQgV2VpbmVoYWxsIDxkYXZpZC53ZWluZWhhbGxAbGlu dXguaW50ZWwuY29tPiB3cm90ZToKPiBPbiBXZWQsIEF1ZyAxMiwgMjAxNSBhdCAwNToxOTozNVBN ICswMzAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPj4gT24gV2VkLCAxMiBBdWcgMjAxNSwgRGF2aWQg V2VpbmVoYWxsIDxkYXZpZC53ZWluZWhhbGxAbGludXguaW50ZWwuY29tPiB3cm90ZToKPj4gPiBT b21lIG1vcmUgZml4dXAgaXMgbmVlZGVkOyB0aGUgYml0cyBmcm9tIEFudHRpJ3MgcGF0Y2gKPj4g PiB0aGF0IGFjdHVhbGx5IGV4cGFuZGVkIHRoZSBzdHJ1Y3QgdG8gZnVsbHkgZml0IHRoZSBuZXdl cgo+PiA+IHZlcnNpb25zIG9mIHRoZSBjaGlsZF9kZXZpY2VfY29uZmlnIHdhcyBwYXJ0IG9mIHRo ZSBzZWNvbmQKPj4gPiBwYXRjaDsgc2luY2UgdGhhdCBwYXRjaCBoYXNuJ3QgYmVlbiBtZXJnZWQg eWV0IHdlIG5lZWQgdGhpcyBiaXQ6Cj4+ID4KPj4gPiBUaGlzIGFwcGxpZXMgb24gdG9wIG9mIHRo ZSBwYXRjaCB5b3UgYWxyZWFkeSBtZXJnZWQKPj4gPiAodGhlIElib29zdCBwYXRjaCB3aWxsIG5l ZWQgY29ycmVzcG9uZGluZyBhZGp1c3RtZW50IHRvCj4+ID4gIHJlbW92ZSB0aGUgY2hhbmdlcyBJ IHNwbGl0IG91dCk6Cj4+ID4KPj4gPiBFeHBhbmQgY29tbW9uX2NoaWxkX2Rldl9jb25maWcgdG8g YmUgYWJsZSB0byBmaXQgYWxsIGluZm9ybWF0aW9uCj4+ID4gZGVmaW5lZCBieSB0aGUgbGF0ZXN0 IFZCVCBzcGVjaWZpY2F0aW9uLgo+PiA+Cj4+ID4gU2lnbmVkLW9mZi1ieTogRGF2aWQgV2VpbmVo YWxsIDxkYXZpZC53ZWluZWhhbGxAbGludXguaW50ZWwuY29tPgo+PiA+IENDOiBBbnR0aSBLb3Nr aXBhYSA8YW50dGkua29za2lwYWFAbGludXguaW50ZWwuY29tPgo+PiA+IC0tLQo+PiA+ICBpbnRl bF9iaW9zLmMgfCAgICA3ICsrKysrKy0KPj4gPiAgaW50ZWxfYmlvcy5oIHwgICAgNCArKysrCj4+ ID4gIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+PiA+ Cj4+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+PiA+IGluZGV4IDk5MGFjYzIwNzcxYS4u NDBlMmNjNGU3NDE5IDEwMDY0NAo+PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Jpb3MuYwo+PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+PiA+ IEBAIC0xMDM4LDYgKzEwMzgsMTAgQEAgcGFyc2VfZGV2aWNlX21hcHBpbmcoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiA+ICAJCURSTV9ERUJVR19LTVMoIk5vIGdlbmVyYWwg ZGVmaW5pdGlvbiBibG9jayBpcyBmb3VuZCwgbm8gZGV2aWNlcyBkZWZpbmVkLlxuIik7Cj4+ID4g IAkJcmV0dXJuOwo+PiA+ICAJfQo+PiA+ICsJLyogUmVtZW1iZXIgdG8ga2VlcCB0aGlzIGluIHN5 bmMgd2l0aCBjaGlsZF9kZXZpY2VfY29uZmlnOwo+PiA+ICsJICogd2hlbmV2ZXIgYSBuZXcgZmVh dHVyZSBpcyBhZGRlZCB0byBCREIgdGhhdCBjYXVzZXMgdGhhdAo+PiA+ICsJICogc3RydWN0IHRv IGdyb3cgdGhpcyBuZWVkcyB0byBiZSB1cGRhdGVkIHRvbwo+PiA+ICsJICovCj4+ID4gIAlpZiAo YmRiLT52ZXJzaW9uIDwgMTk1KSB7Cj4+ID4gIAkJZXhwZWN0ZWRfc2l6ZSA9IDMzOwo+PiA+ICAJ fSBlbHNlIGlmIChiZGItPnZlcnNpb24gPT0gMTk1KSB7Cj4+ID4gQEAgLTEwNTEsNyArMTA1NSw4 IEBAIHBhcnNlX2RldmljZV9tYXBwaW5nKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPj4gPiAgCX0KPj4gPiAgCj4+ID4gIAlpZiAoZXhwZWN0ZWRfc2l6ZSA+IHNpemVvZigqcF9j aGlsZCkpIHsKPj4gPiAtCQlEUk1fRVJST1IoImNoaWxkX2RldmljZV9jb25maWcgY2Fubm90IGZp dCBpbiBwX2NoaWxkXG4iKTsKPj4gPiArCQlEUk1fRVJST1IoImNoaWxkX2RldmljZV9jb25maWcg KHNpemUgJXUpIGNhbm5vdCBmaXQgaW4gcF9jaGlsZCAoc2l6ZSAldSk7IGJkYi0+dmVyc2lvbjog JXVcbiIsCj4+ID4gKwkJCSAgZXhwZWN0ZWRfc2l6ZSwgc2l6ZW9mKCpwX2NoaWxkKSwgYmRiLT52 ZXJzaW9uKTsKPj4gCj4+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYzogSW4gZnVu Y3Rpb24g4oCYcGFyc2VfZGV2aWNlX21hcHBpbmfigJk6Cj4+IGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Jpb3MuYzoxMDU4OjM6IHdhcm5pbmc6IGZvcm1hdCDigJgldeKAmSBleHBlY3RzIGFy Z3VtZW50IG9mIHR5cGUg4oCYdW5zaWduZWQgaW504oCZLCBidXQgYXJndW1lbnQgMyBoYXMgdHlw ZSDigJhsb25nIHVuc2lnbmVkIGludOKAmSBbLVdmb3JtYXQ9XQo+PiAgICBEUk1fRVJST1IoImNo aWxkX2RldmljZV9jb25maWcgKHNpemUgJXUpIGNhbm5vdCBmaXQgaW4gcF9jaGlsZCAoc2l6ZSAl dSk7IGJkYi0+dmVyc2lvbjogJXVcbiIsCj4+ICAgIF4KPj4gICBDQyBbTV0gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2ZpZm9fdW5kZXJydW4ubwo+Cj4gV2VsbCBzcG90dGVkLiAgT3IgcmF0 aGVyLCBzdHVwaWQgb2YgbWUgdG8gZm9yZ2V0IHRoYXQgc2l6ZW9mIHlpZWxkcwo+IHNpemVfdCBh cyB0eXBlLCB0aHVzIG5lY2Vzc2l0YXRpbmcgJXp1IGFzIGNvbnZlcnNpb24gc3BlY2lmaWVyLgo+ Cj4gRml4ZWQgdmVyc2lvbjoKPgo+IEV4cGFuZCBjb21tb25fY2hpbGRfZGV2X2NvbmZpZyB0byBi ZSBhYmxlIHRvIGZpdCBhbGwgaW5mb3JtYXRpb24KPiBkZWZpbmVkIGJ5IHRoZSBsYXRlc3QgVkJU IHNwZWNpZmljYXRpb24uCj4KPiB2MjogVXNlIHByb3BlciBjb252ZXJzaW9uIHNwZWNpZmllciBm b3Igc2l6ZV90ICglenUpCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYXZpZCBXZWluZWhhbGwgPGRhdmlk LndlaW5laGFsbEBsaW51eC5pbnRlbC5jb20+Cj4gQ0M6IEFudHRpIEtvc2tpcGFhIDxhbnR0aS5r b3NraXBhYUBsaW51eC5pbnRlbC5jb20+Cj4KPiAgaW50ZWxfYmlvcy5jIHwgICAgNyArKysrKyst Cj4gIGludGVsX2Jpb3MuaCB8ICAgIDQgKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9iaW9zLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiBp bmRleCA5OTBhY2MyMDc3MWEuLjU2NzNlZDUzNzk3YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9iaW9zLmMKPiBAQCAtMTAzOCw2ICsxMDM4LDEwIEBAIHBhcnNlX2RldmljZV9tYXBwaW5nKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQlEUk1fREVCVUdfS01TKCJObyBn ZW5lcmFsIGRlZmluaXRpb24gYmxvY2sgaXMgZm91bmQsIG5vIGRldmljZXMgZGVmaW5lZC5cbiIp Owo+ICAJCXJldHVybjsKPiAgCX0KPiArCS8qIFJlbWVtYmVyIHRvIGtlZXAgdGhpcyBpbiBzeW5j IHdpdGggY2hpbGRfZGV2aWNlX2NvbmZpZzsKPiArCSAqIHdoZW5ldmVyIGEgbmV3IGZlYXR1cmUg aXMgYWRkZWQgdG8gQkRCIHRoYXQgY2F1c2VzIHRoYXQKPiArCSAqIHN0cnVjdCB0byBncm93IHRo aXMgbmVlZHMgdG8gYmUgdXBkYXRlZCB0b28KPiArCSAqLwo+ICAJaWYgKGJkYi0+dmVyc2lvbiA8 IDE5NSkgewo+ICAJCWV4cGVjdGVkX3NpemUgPSAzMzsKPiAgCX0gZWxzZSBpZiAoYmRiLT52ZXJz aW9uID09IDE5NSkgewo+IEBAIC0xMDUxLDcgKzEwNTUsOCBAQCBwYXJzZV9kZXZpY2VfbWFwcGlu ZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAl9Cj4gIAo+ICAJaWYgKGV4 cGVjdGVkX3NpemUgPiBzaXplb2YoKnBfY2hpbGQpKSB7Cj4gLQkJRFJNX0VSUk9SKCJjaGlsZF9k ZXZpY2VfY29uZmlnIGNhbm5vdCBmaXQgaW4gcF9jaGlsZFxuIik7Cj4gKwkJRFJNX0VSUk9SKCJj aGlsZF9kZXZpY2VfY29uZmlnIChzaXplICV1KSBjYW5ub3QgZml0IGluIHBfY2hpbGQgKHNpemUg JXp1KTsgYmRiLT52ZXJzaW9uOiAldVxuIiwKPiArCQkJICBleHBlY3RlZF9zaXplLCBzaXplb2Yo KnBfY2hpbGQpLCBiZGItPnZlcnNpb24pOwo+ICAJCXJldHVybjsKPiAgCX0KPiAgCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuaCBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Jpb3MuaAo+IGluZGV4IGY3YWQ2YTU4NTEyOS4uNzFjYjk2Zjc3ODcwIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuaAo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuaAo+IEBAIC0yMzksNiArMjM5LDEwIEBAIHN0 cnVjdCBjb21tb25fY2hpbGRfZGV2X2NvbmZpZyB7Cj4gIAl1OCBub3RfY29tbW9uMlsyXTsKPiAg CXU4IGRkY19waW47Cj4gIAl1MTYgZWRpZF9wdHI7Cj4gKwl1OCBvYnNvbGV0ZTsKPiArCXU4IGZs YWdzXzE7Cj4gKwl1OCBub3RfY29tbW9uM1sxM107Cj4gKwl1OCBpYm9vc3RfbGV2ZWw7CgpIb3cg ZG9lcyB0aGlzIGltcGFjdCB0aGUgaWYgKHBfZGVmcy0+Y2hpbGRfZGV2X3NpemUgIT0gc2l6ZW9m KCpwX2NoaWxkKSkKY2hlY2sgaW4gcGFyc2Vfc2R2b19kZXZpY2VfbWFwcGluZygpPwoKQlIsCkph bmkuCgo+ICB9IF9fcGFja2VkOwo+ICAKPiAgLyogVGhpcyBmaWVsZCBjaGFuZ2VzIGRlcGVuZGlu ZyBvbiB0aGUgQkRCIHZlcnNpb24sIHNvIHRoZSBtb3N0IHJlbGlhYmxlIHdheSB0bwoKLS0gCkph bmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=