Re: [PATCH 1/4] drm/i915: Add audio hotplug info callback

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 23 Jul 2015, David Henningsson <david.henningsson@canonical.com> wrote:
> This callback will be called by the i915 driver to notify the hda
> driver that HDMI has been hotplugged.
>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
>  include/drm/i915_component.h |    5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h
> index c9a8b64..d053008 100644
> --- a/include/drm/i915_component.h
> +++ b/include/drm/i915_component.h
> @@ -26,6 +26,7 @@
>  
>  struct i915_audio_component {
>  	struct device *dev;
> +	void *audio_ptr;
>  
>  	const struct i915_audio_component_ops {
>  		struct module *owner;
> @@ -34,6 +35,10 @@ struct i915_audio_component {
>  		void (*codec_wake_override)(struct device *, bool enable);
>  		int (*get_cdclk_freq)(struct device *);
>  	} *ops;
> +
> +	const struct i915_audio_component_audio_ops {
> +		void (*hotplug_notify)(void *audio_ptr, int port, int port_mst_index);
> +	} *audio_ops;

I'd appreciate kernel-doc for the callback, in particular with the
preconditions for making the call clarified. When I first saw the
series, I thought "oh no you can't make the call from hotplug
code". Which you don't, but all your commit messages and comments and
naming refer to hotplug.

The main point is that you can't tell the audio it's good to go before
we have pretty much the whole display pipeline enabled, and there's a
long way from hotplug to that point.

BR,
Jani.



>  };
>  
>  #endif /* _I915_COMPONENT_H_ */
> -- 
> 1.7.9.5
>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx