From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH i-g-t] kms_cursor_crc: Kernel now checks for integer overflow Date: Tue, 03 Feb 2015 16:33:51 +0200 Message-ID: <87wq3zxdww.fsf@intel.com> References: <1422915648-752-1-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id DC6E26E036 for ; Tue, 3 Feb 2015 06:33:20 -0800 (PST) In-Reply-To: <1422915648-752-1-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAwMyBGZWIgMjAxNSwgTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNv bT4gd3JvdGU6Cj4gQXMgb2Yga2VybmVsIGNvbW1pdAo+Cj4gICAgIGNvbW1pdCBhNjc5MDY0YTdl OWU4Nzk5MTc3YTY0YTMxNjY4YTM0YTFiYzZhNGYxCj4gICAgIEF1dGhvcjogTWF0dCBSb3BlciA8 bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiAgICAgRGF0ZTogICBGcmkgSmFuIDMwIDE2OjIy OjM3IDIwMTUgLTA4MDAKPgo+ICAgICAgICAgZHJtL2k5MTU6IFN3aXRjaCBwbGFuZXMgZnJvbSB0 cmFuc2l0aW9uYWwgaGVscGVycyB0byBmdWxsIGF0b21pYyBoZWxwZXJzCj4KPiB0aGUga2VybmVs IG5vdyBjaGVja3MgZm9yIGN1cnNvciBjb29yZGluYXRlcyB0aGF0IHdvdWxkIHJlc3VsdCBpbgo+ IGludGVnZXIgb3ZlcmZsb3cgYW5kIHJldHVybnMgLUVSQU5HRSwgc2ltaWxhciB0byB0aGUgY2hl Y2tpbmcgdGhhdCB3YXMKPiBhbHJlYWR5IGRvbmUgZm9yIG90aGVyIHBsYW5lIHR5cGVzLiAgV2Ug dXBkYXRlIGttc19jdXJzb3JfY3JjIGhlcmUgdG8KPiByZWZsZWN0IHRoaXMgc21hbGwgYmVoYXZp b3IgY2hhbmdlOgo+ICAqIENoZWNrIGZvciBzdWNjZXNzIGF0IGV4dHJlbWUgYm91bmRhcnkgY29u ZGl0aW9ucyBJTlRfTUFYLXt3aWR0aCxoZWlnaHR9Cj4gICAgcmF0aGVyIHRoYW4gSU5UX01BWAo+ ICAqIEFkZCBuZXcgY2hlY2sgZm9yIHN1Y2Nlc3MgYXQgU0hSVF9NQVg7IGlmIHRoZSBkcml2ZXIg d2VyZSB0bwo+ICAgIGludGVybmFsbHkgdXNlIHNob3J0IHZhbHVlcyBhbmQgb3ZlcmZsb3csIHdl IGNvdWxkIGhhdmUgdGhlIGN1cnNvcgo+ICAgIHJlYXBwZWFyIG9uIHRoZSBzY3JlZW4uCj4gICog QWRkIGEgdGVzdCBmb3IgZmFpbHVyZSB3aXRoIHByb3BlciBlcnJvciBjb2RlIGF0IElOVF9NQVgt e3dpZHRoLGhlaWdodH0rMQo+Cj4gU2lnbmVkLW9mZi1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5k LnJvcGVyQGludGVsLmNvbT4KCgpCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODg5MTcKCj8KCgo+IC0tLQo+ICB0ZXN0cy9rbXNfY3Vyc29yX2Ny Yy5jIHwgMjkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQs IDI4IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS90ZXN0cy9r bXNfY3Vyc29yX2NyYy5jIGIvdGVzdHMva21zX2N1cnNvcl9jcmMuYwo+IGluZGV4IGUxMzkwYTcu LjY0ZmVhMTIgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMva21zX2N1cnNvcl9jcmMuYwo+ICsrKyBiL3Rl c3RzL2ttc19jdXJzb3JfY3JjLmMKPiBAQCAtMTM5LDYgKzEzOSwyOSBAQCBzdGF0aWMgdm9pZCBk b19zaW5nbGVfdGVzdChkYXRhX3QgKmRhdGEsIGludCB4LCBpbnQgeSkKPiAgCWlndF9hc3NlcnQo aWd0X2NyY19lcXVhbCgmY3JjLCAmcmVmX2NyYykpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBk b19mYWlsX3Rlc3QoZGF0YV90ICpkYXRhLCBpbnQgeCwgaW50IHksIGludCBleHBlY3QpCj4gK3sK PiArCWlndF9kaXNwbGF5X3QgKmRpc3BsYXkgPSAmZGF0YS0+ZGlzcGxheTsKPiArCWlndF9wbGFu ZV90ICpjdXJzb3I7Cj4gKwljYWlyb190ICpjciA9IGlndF9nZXRfY2Fpcm9fY3R4KGRhdGEtPmRy bV9mZCwgJmRhdGEtPnByaW1hcnlfZmIpOwo+ICsJaW50IHJldDsKPiArCj4gKwlpZ3RfcHJpbnRf YWN0aXZpdHkoKTsKPiArCj4gKwkvKiBIYXJkd2FyZSB0ZXN0ICovCj4gKwlpZ3RfcGFpbnRfdGVz dF9wYXR0ZXJuKGNyLCBkYXRhLT5zY3JlZW53LCBkYXRhLT5zY3JlZW5oKTsKPiArCWN1cnNvcl9l bmFibGUoZGF0YSk7Cj4gKwljdXJzb3IgPSBpZ3Rfb3V0cHV0X2dldF9wbGFuZShkYXRhLT5vdXRw dXQsIElHVF9QTEFORV9DVVJTT1IpOwo+ICsJaWd0X3BsYW5lX3NldF9wb3NpdGlvbihjdXJzb3Is IHgsIHkpOwo+ICsJcmV0ID0gaWd0X2Rpc3BsYXlfdHJ5X2NvbW1pdDIoZGlzcGxheSwgQ09NTUlU X0xFR0FDWSk7Cj4gKwo+ICsJaWd0X3BsYW5lX3NldF9wb3NpdGlvbihjdXJzb3IsIDAsIDApOwo+ ICsJY3Vyc29yX2Rpc2FibGUoZGF0YSk7Cj4gKwlpZ3RfZGlzcGxheV9jb21taXQoZGlzcGxheSk7 Cj4gKwo+ICsJaWd0X2Fzc2VydChyZXQgPT0gZXhwZWN0KTsKPiArfQo+ICsKPiAgc3RhdGljIHZv aWQgZG9fdGVzdChkYXRhX3QgKmRhdGEsCj4gIAkJICAgIGludCBsZWZ0LCBpbnQgcmlnaHQsIGlu dCB0b3AsIGludCBib3R0b20pCj4gIHsKPiBAQCAtMjAxLDcgKzIyNCwxMSBAQCBzdGF0aWMgdm9p ZCB0ZXN0X2NyY19vZmZzY3JlZW4oZGF0YV90ICpkYXRhKQo+ICAJZG9fdGVzdChkYXRhLCBsZWZ0 IC0gKGN1cnNvcl93KzUxMiksIHJpZ2h0ICsgKGN1cnNvcl93KzUxMiksIHRvcCAtIChjdXJzb3Jf aCs1MTIpLCBib3R0b20gKyAoY3Vyc29yX2grNTEyKSk7Cj4gIAo+ICAJLyogZ28gbnV0cyAqLwo+ IC0JZG9fdGVzdChkYXRhLCBJTlRfTUlOLCBJTlRfTUFYLCBJTlRfTUlOLCBJTlRfTUFYKTsKPiAr CWRvX3Rlc3QoZGF0YSwgSU5UX01JTiwgSU5UX01BWCAtIGN1cnNvcl93LCBJTlRfTUlOLCBJTlRf TUFYIC0gY3Vyc29yX2gpOwo+ICsJZG9fdGVzdChkYXRhLCBTSFJUX01JTiwgU0hSVF9NQVgsIFNI UlRfTUlOLCBTSFJUX01BWCk7Cj4gKwo+ICsJLyogTWFrZSBzdXJlIHdlIGdldCAtRVJBTkdFIG9u IGludGVnZXIgb3ZlcmZsb3cgKi8KPiArCWRvX2ZhaWxfdGVzdChkYXRhLCBJTlRfTUFYIC0gY3Vy c29yX3cgKyAxLCBJTlRfTUFYIC0gY3Vyc29yX2ggKyAxLCAtRVJBTkdFKTsKPiAgfQo+ICAKPiAg c3RhdGljIHZvaWQgdGVzdF9jcmNfc2xpZGluZyhkYXRhX3QgKmRhdGEpCj4gLS0gCj4gMS44LjUu MQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJ bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK Ci0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK