From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 11/18] drm/i915: rewrite hsw/bdw audio codec enable/disable sequences Date: Tue, 28 Oct 2014 17:18:16 +0200 Message-ID: <87wq7kjk93.fsf@intel.com> References: <7441f15f037714b64fa4d0039e2d2332546ff541.1414419818.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 23A636E48A for ; Tue, 28 Oct 2014 08:19:05 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx , shuang.he@linux.intel.com, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyNyBPY3QgMjAxNCwgUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAZ21haWwuY29t PiB3cm90ZToKPiBPbiBNb24sIE9jdCAyNywgMjAxNCBhdCA3OjI2IEFNLCBKYW5pIE5pa3VsYSA8 amFuaS5uaWt1bGFAaW50ZWwuY29tPiB3cm90ZToKPj4gVGhlcmUncyBzb21lIHNlcmlvdXMgY29u ZnVzaW9uIHJlZ2FyZGluZyBFTEQgdmFsaWQgYml0IHRoYXQgZ2V0cyBzZXQgYW5kCj4+IGNsZWFy ZWQgYmFjayBhbmQgZm9ydGggZXRjLiBSZXdyaXRlIGl0IGFsbCBiYXNlZCBvbiB0aGUgZG9jdW1l bnRlZCBhdWRpbwo+PiBjb2RlYyBlbmFibGUvZGlzYWJsZSBzZXF1ZW5jZXMuCj4KPiBDb3VsZCB5 b3UgcGxlYXNlIHNoYXJlIHRoaXMgZG9jIG9yIHBvaW50IG1lIG91dD8KClNhbWUgYnNwZWMgYXMg dGhlIG9uZSBiZWZvcmUuCgpCUiwKSmFuaS4KCgo+Cj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEphbmkg TmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfYXVkaW8uYyB8IDExMCArKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwgNjQgZGVsZXRpb25z KC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdWRpby5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYwo+PiBpbmRleCA4MDcwNDE0YjUw YWQuLjBjNmFjMTY5YWI5OCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYXVkaW8uYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdWRpby5jCj4+ IEBAIC0xMzIsMTQgKzEzMiwyNiBAQCBzdGF0aWMgdm9pZCBnNHhfYXVkaW9fY29kZWNfZW5hYmxl KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4+Cj4+ICBzdGF0aWMgdm9pZCBoc3df YXVkaW9fY29kZWNfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPj4gIHsK Pj4gLSAgICAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZW5jb2Rlci0+YmFzZS5kZXY7Cj4+ IC0gICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJp dmF0ZTsKPj4gLSAgICAgICBzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBlbmNvZGVyLT5iYXNlLmNy dGM7Cj4+IC0gICAgICAgZW51bSBwaXBlIHBpcGUgPSB0b19pbnRlbF9jcnRjKGNydGMpLT5waXBl Owo+PiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGVuY29kZXIt PmJhc2UuZGV2LT5kZXZfcHJpdmF0ZTsKPj4gKyAgICAgICBzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50 ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoZW5jb2Rlci0+YmFzZS5jcnRjKTsKPj4gKyAgICAgICBl bnVtIHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4+ICAgICAgICAgdWludDMyX3QgdG1w Owo+Pgo+PiArICAgICAgIERSTV9ERUJVR19LTVMoIkRpc2FibGUgYXVkaW8gY29kZWMgb24gcGlw ZSAlY1xuIiwgcGlwZV9uYW1lKHBpcGUpKTsKPj4gKwo+PiArICAgICAgIC8qIERpc2FibGUgdGlt ZXN0YW1wcyAqLwo+PiArICAgICAgIHRtcCA9IEk5MTVfUkVBRChIU1dfQVVEX0NGRyhwaXBlKSk7 Cj4+ICsgICAgICAgdG1wICY9IH5BVURfQ09ORklHX05fVkFMVUVfSU5ERVg7Cj4+ICsgICAgICAg dG1wIHw9IEFVRF9DT05GSUdfTl9QUk9HX0VOQUJMRTsKPj4gKyAgICAgICB0bXAgJj0gfkFVRF9D T05GSUdfVVBQRVJfTl9NQVNLOwo+PiArICAgICAgIHRtcCAmPSB+QVVEX0NPTkZJR19MT1dFUl9O X01BU0s7Cj4+ICsgICAgICAgaWYgKGludGVsX3BpcGVfaGFzX3R5cGUoaW50ZWxfY3J0YywgSU5U RUxfT1VUUFVUX0RJU1BMQVlQT1JUKSkKPj4gKyAgICAgICAgICAgICAgIHRtcCB8PSBBVURfQ09O RklHX05fVkFMVUVfSU5ERVg7Cj4+ICsgICAgICAgSTkxNV9XUklURShIU1dfQVVEX0NGRyhwaXBl KSwgdG1wKTsKPj4gKwo+PiArICAgICAgIC8qIEludmFsaWRhdGUgRUxEICovCj4+ICAgICAgICAg dG1wID0gSTkxNV9SRUFEKEhTV19BVURfUElOX0VMRF9DUF9WTEQpOwo+PiAtICAgICAgIHRtcCAm PSB+KChBVURJT19PVVRQVVRfRU5BQkxFX0EgfCBBVURJT19FTERfVkFMSURfQSkgPDwgKHBpcGUg KiA0KSk7Cj4+ICsgICAgICAgdG1wICY9IH4oQVVESU9fRUxEX1ZBTElEX0EgPDwgKHBpcGUgKiA0 KSk7Cj4+ICAgICAgICAgSTkxNV9XUklURShIU1dfQVVEX1BJTl9FTERfQ1BfVkxELCB0bXApOwo+ PiAgfQo+Pgo+PiBAQCAtMTQ5LDc3ICsxNjEsNDcgQEAgc3RhdGljIHZvaWQgaHN3X2F1ZGlvX2Nv ZGVjX2VuYWJsZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+PiAgewo+PiAgICAg ICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGNvbm5lY3Rvci0+ZGV2LT5k ZXZfcHJpdmF0ZTsKPj4gICAgICAgICBzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRv X2ludGVsX2NydGMoZW5jb2Rlci0+YmFzZS5jcnRjKTsKPj4gLSAgICAgICB1aW50OF90ICplbGQg PSBjb25uZWN0b3ItPmVsZDsKPj4gLSAgICAgICB1aW50MzJfdCBlbGR2Owo+PiArICAgICAgIGVu dW0gcGlwZSBwaXBlID0gaW50ZWxfY3J0Yy0+cGlwZTsKPj4gKyAgICAgICBjb25zdCB1aW50OF90 ICplbGQgPSBjb25uZWN0b3ItPmVsZDsKPj4gICAgICAgICB1aW50MzJfdCB0bXA7Cj4+ICAgICAg ICAgaW50IGxlbiwgaTsKPj4gLSAgICAgICBlbnVtIHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBp cGU7Cj4+IC0gICAgICAgZW51bSBwb3J0IHBvcnQ7Cj4+IC0gICAgICAgaW50IGhkbWl3X2hkbWll ZGlkID0gSFNXX0FVRF9FRElEX0RBVEEocGlwZSk7Cj4+IC0gICAgICAgaW50IGF1ZF9jbnRsX3N0 ID0gSFNXX0FVRF9ESVBfRUxEX0NUUkwocGlwZSk7Cj4+IC0gICAgICAgaW50IGF1ZF9jb25maWcg PSBIU1dfQVVEX0NGRyhwaXBlKTsKPj4gLSAgICAgICBpbnQgYXVkX2NudHJsX3N0MiA9IEhTV19B VURfUElOX0VMRF9DUF9WTEQ7Cj4+Cj4+IC0gICAgICAgLyogQXVkaW8gb3V0cHV0IGVuYWJsZSAq Lwo+PiAtICAgICAgIERSTV9ERUJVR19EUklWRVIoIkhETUkgYXVkaW86IGVuYWJsZSBjb2RlY1xu Iik7Cj4+IC0gICAgICAgdG1wID0gSTkxNV9SRUFEKGF1ZF9jbnRybF9zdDIpOwo+PiAtICAgICAg IHRtcCB8PSAoQVVESU9fT1VUUFVUX0VOQUJMRV9BIDw8IChwaXBlICogNCkpOwo+PiAtICAgICAg IEk5MTVfV1JJVEUoYXVkX2NudHJsX3N0MiwgdG1wKTsKPj4gLSAgICAgICBQT1NUSU5HX1JFQUQo YXVkX2NudHJsX3N0Mik7Cj4+IC0KPj4gLSAgICAgICAvKiBTZXQgRUxEIHZhbGlkIHN0YXRlICov Cj4+IC0gICAgICAgdG1wID0gSTkxNV9SRUFEKGF1ZF9jbnRybF9zdDIpOwo+PiAtICAgICAgIERS TV9ERUJVR19EUklWRVIoIkhETUkgYXVkaW86IHBpbiBlbGQgdmxkIHN0YXR1cz0weCUwOHhcbiIs IHRtcCk7Cj4+IC0gICAgICAgdG1wIHw9IChBVURJT19FTERfVkFMSURfQSA8PCAocGlwZSAqIDQp KTsKPj4gLSAgICAgICBJOTE1X1dSSVRFKGF1ZF9jbnRybF9zdDIsIHRtcCk7Cj4+IC0gICAgICAg dG1wID0gSTkxNV9SRUFEKGF1ZF9jbnRybF9zdDIpOwo+PiAtICAgICAgIERSTV9ERUJVR19EUklW RVIoIkhETUkgYXVkaW86IGVsZCB2bGQgc3RhdHVzPTB4JTA4eFxuIiwgdG1wKTsKPj4gLQo+PiAt ICAgICAgIC8qIEVuYWJsZSBIRE1JIG1vZGUgKi8KPj4gLSAgICAgICB0bXAgPSBJOTE1X1JFQUQo YXVkX2NvbmZpZyk7Cj4+IC0gICAgICAgRFJNX0RFQlVHX0RSSVZFUigiSERNSSBhdWRpbzogYXVk aW8gY29uZjogMHglMDh4XG4iLCB0bXApOwo+PiAtICAgICAgIC8qIGNsZWFyIE5fcHJvZ3JhbWlu Z19lbmFibGUgYW5kIE5fdmFsdWVfaW5kZXggKi8KPj4gLSAgICAgICB0bXAgJj0gfihBVURfQ09O RklHX05fVkFMVUVfSU5ERVggfCBBVURfQ09ORklHX05fUFJPR19FTkFCTEUpOwo+PiAtICAgICAg IEk5MTVfV1JJVEUoYXVkX2NvbmZpZywgdG1wKTsKPj4gKyAgICAgICBEUk1fREVCVUdfS01TKCJF bmFibGUgYXVkaW8gY29kZWMgb24gcGlwZSAlYywgJXUgYnl0ZXMgRUxEXG4iLAo+PiArICAgICAg ICAgICAgICAgICAgICAgcGlwZV9uYW1lKHBpcGUpLCBlbGRbMl0pOwo+Pgo+PiAtICAgICAgIERS TV9ERUJVR19EUklWRVIoIkVMRCBvbiBwaXBlICVjXG4iLCBwaXBlX25hbWUocGlwZSkpOwo+PiAt Cj4+IC0gICAgICAgZWxkdiA9IEFVRElPX0VMRF9WQUxJRF9BIDw8IChwaXBlICogNCk7Cj4+IC0K Pj4gLSAgICAgICBpZiAoaW50ZWxfcGlwZV9oYXNfdHlwZShpbnRlbF9jcnRjLCBJTlRFTF9PVVRQ VVRfRElTUExBWVBPUlQpKQo+PiAtICAgICAgICAgICAgICAgSTkxNV9XUklURShhdWRfY29uZmln LCBBVURfQ09ORklHX05fVkFMVUVfSU5ERVgpOyAvKiAweDEgPSBEUCAqLwo+PiAtICAgICAgIGVs c2UKPj4gLSAgICAgICAgICAgICAgIEk5MTVfV1JJVEUoYXVkX2NvbmZpZywgYXVkaW9fY29uZmln X2hkbWlfcGl4ZWxfY2xvY2sobW9kZSkpOwo+PiAtCj4+IC0gICAgICAgaWYgKGludGVsX2VsZF91 cHRvZGF0ZShjb25uZWN0b3IsCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhdWRf Y250cmxfc3QyLCBlbGR2LAo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYXVkX2Nu dGxfc3QsIElCWF9FTERfQUREUkVTU19NQVNLLAo+PiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgaGRtaXdfaGRtaWVkaWQpKQo+PiAtICAgICAgICAgICAgICAgcmV0dXJuOwo+PiArICAg ICAgIC8qIEVuYWJsZSBhdWRpbyBwcmVzZW5jZSBkZXRlY3QsIGludmFsaWRhdGUgRUxEICovCj4+ ICsgICAgICAgdG1wID0gSTkxNV9SRUFEKEhTV19BVURfUElOX0VMRF9DUF9WTEQpOwo+PiArICAg ICAgIHRtcCB8PSBBVURJT19PVVRQVVRfRU5BQkxFX0EgPDwgKHBpcGUgKiA0KTsKPj4gKyAgICAg ICB0bXAgJj0gfihBVURJT19FTERfVkFMSURfQSA8PCAocGlwZSAqIDQpKTsKPj4gKyAgICAgICBJ OTE1X1dSSVRFKEhTV19BVURfUElOX0VMRF9DUF9WTEQsIHRtcCk7Cj4+Cj4+IC0gICAgICAgdG1w ID0gSTkxNV9SRUFEKGF1ZF9jbnRybF9zdDIpOwo+PiAtICAgICAgIHRtcCAmPSB+ZWxkdjsKPj4g LSAgICAgICBJOTE1X1dSSVRFKGF1ZF9jbnRybF9zdDIsIHRtcCk7Cj4+ICsgICAgICAgaW50ZWxf d2FpdF9mb3JfdmJsYW5rKGRldl9wcml2LT5kZXYsIHBpcGUpOwo+Pgo+PiAtICAgICAgIHRtcCA9 IEk5MTVfUkVBRChhdWRfY250bF9zdCk7Cj4+ICsgICAgICAgLyogUmVzZXQgRUxEIHdyaXRlIGFk ZHJlc3MgKi8KPj4gKyAgICAgICB0bXAgPSBJOTE1X1JFQUQoSFNXX0FVRF9ESVBfRUxEX0NUUkwo cGlwZSkpOwo+PiAgICAgICAgIHRtcCAmPSB+SUJYX0VMRF9BRERSRVNTX01BU0s7Cj4+IC0gICAg ICAgSTkxNV9XUklURShhdWRfY250bF9zdCwgdG1wKTsKPj4gLSAgICAgICBwb3J0ID0gKHRtcCA+ PiAyOSkgJiBESVBfUE9SVF9TRUxfTUFTSzsgICAgICAgICAvKiBESVBfUG9ydF9TZWxlY3QsIDB4 MSA9IFBvcnRCICovCj4+IC0gICAgICAgRFJNX0RFQlVHX0RSSVZFUigicG9ydCBudW06JWRcbiIs IHBvcnQpOwo+PiArICAgICAgIEk5MTVfV1JJVEUoSFNXX0FVRF9ESVBfRUxEX0NUUkwocGlwZSks IHRtcCk7Cj4+Cj4+IC0gICAgICAgbGVuID0gbWluX3QoaW50LCBlbGRbMl0sIDIxKTsgICAvKiA4 NCBieXRlcyBvZiBodyBFTEQgYnVmZmVyICovCj4+IC0gICAgICAgRFJNX0RFQlVHX0RSSVZFUigi RUxEIHNpemUgJWRcbiIsIGxlbik7Cj4+ICsgICAgICAgLyogVXAgdG8gODQgYnl0ZXMgb2YgaHcg RUxEIGJ1ZmZlciAqLwo+PiArICAgICAgIGxlbiA9IG1pbl90KGludCwgZWxkWzJdLCAyMSk7Cj4+ ICAgICAgICAgZm9yIChpID0gMDsgaSA8IGxlbjsgaSsrKQo+PiAtICAgICAgICAgICAgICAgSTkx NV9XUklURShoZG1pd19oZG1pZWRpZCwgKigodWludDMyX3QgKillbGQgKyBpKSk7Cj4+IC0KPj4g LSAgICAgICB0bXAgPSBJOTE1X1JFQUQoYXVkX2NudHJsX3N0Mik7Cj4+IC0gICAgICAgdG1wIHw9 IGVsZHY7Cj4+IC0gICAgICAgSTkxNV9XUklURShhdWRfY250cmxfc3QyLCB0bXApOwo+PiArICAg ICAgICAgICAgICAgSTkxNV9XUklURShIU1dfQVVEX0VESURfREFUQShwaXBlKSwgKigodWludDMy X3QgKillbGQgKyBpKSk7Cj4+Cj4+IC0gICAgICAgLyogWFhYOiBUcmFuc2l0aW9uYWwgKi8KPj4g KyAgICAgICAvKiBFTEQgdmFsaWQgKi8KPj4gICAgICAgICB0bXAgPSBJOTE1X1JFQUQoSFNXX0FV RF9QSU5fRUxEX0NQX1ZMRCk7Cj4+IC0gICAgICAgdG1wIHw9ICgoQVVESU9fT1VUUFVUX0VOQUJM RV9BIHwgQVVESU9fRUxEX1ZBTElEX0EpIDw8IChwaXBlICogNCkpOwo+PiArICAgICAgIHRtcCB8 PSBBVURJT19FTERfVkFMSURfQSA8PCAocGlwZSAqIDQpOwo+PiAgICAgICAgIEk5MTVfV1JJVEUo SFNXX0FVRF9QSU5fRUxEX0NQX1ZMRCwgdG1wKTsKPj4gKwo+PiArICAgICAgIC8qIEVuYWJsZSB0 aW1lc3RhbXBzICovCj4+ICsgICAgICAgdG1wID0gSTkxNV9SRUFEKEhTV19BVURfQ0ZHKHBpcGUp KTsKPj4gKyAgICAgICB0bXAgJj0gfkFVRF9DT05GSUdfTl9WQUxVRV9JTkRFWDsKPj4gKyAgICAg ICB0bXAgJj0gfkFVRF9DT05GSUdfTl9QUk9HX0VOQUJMRTsKPj4gKyAgICAgICB0bXAgJj0gfkFV RF9DT05GSUdfUElYRUxfQ0xPQ0tfSERNSV9NQVNLOwo+PiArICAgICAgIGlmIChpbnRlbF9waXBl X2hhc190eXBlKGludGVsX2NydGMsIElOVEVMX09VVFBVVF9ESVNQTEFZUE9SVCkpCj4+ICsgICAg ICAgICAgICAgICB0bXAgfD0gQVVEX0NPTkZJR19OX1ZBTFVFX0lOREVYOwo+PiArICAgICAgIGVs c2UKPj4gKyAgICAgICAgICAgICAgIHRtcCB8PSBhdWRpb19jb25maWdfaGRtaV9waXhlbF9jbG9j ayhtb2RlKTsKPj4gKyAgICAgICBJOTE1X1dSSVRFKEhTV19BVURfQ0ZHKHBpcGUpLCB0bXApOwo+ PiAgfQo+Pgo+PiAgc3RhdGljIHZvaWQgaWxrX2F1ZGlvX2NvZGVjX2VuYWJsZShzdHJ1Y3QgZHJt X2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+PiAtLQo+PiAyLjEuMQo+Pgo+PiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBJbnRlbC1nZnggbWFpbGluZyBs aXN0Cj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+Cj4KPgo+IC0tIAo+IFJv ZHJpZ28gVml2aQo+IEJsb2c6IGh0dHA6Ly9ibG9nLnZpdmkuZW5nLmJyCgotLSAKSmFuaSBOaWt1 bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==