From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Matt Roper <matthew.d.roper@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't try to look up object for non-existent fb
Date: Wed, 25 Jun 2014 13:12:21 +0300 [thread overview]
Message-ID: <87wqc570xm.fsf@intel.com> (raw)
In-Reply-To: <20140625082838.GB23572@nuc-i3427.alporthouse.com>
On Wed, 25 Jun 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Jun 24, 2014 at 05:05:02PM -0700, Matt Roper wrote:
>> crtc->primary->fb may be NULL upon entry to intel_pipe_set_base() if the
>> primary plane has previously been disabled via the universal plane
>> interface. We need to check for NULL before trying to reference
>> old_fb's obj.
>>
>> This fixes a regression introduced in
>>
>> commit a071fa00647bc9a3c53f917b236fff9aea175e3a
>> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Date: Wed Jun 18 23:28:09 2014 +0200
>>
>> drm/i915: Introduce accurate frontbuffer tracking
>>
>> Testcase: igt/kms_universal_plane
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>
> Oh for a safe version of to_fb_obj().
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Pushed to dinq, thanks for the patch and review.
BR,
Jani.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2014-06-25 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 0:05 [PATCH] drm/i915: Don't try to look up object for non-existent fb Matt Roper
2014-06-25 8:28 ` Chris Wilson
2014-06-25 10:12 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqc570xm.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox