From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Don't try to look up object for
	non-existent fb
Date: Wed, 25 Jun 2014 13:12:21 +0300
Message-ID: <87wqc570xm.fsf@intel.com>
References: <1403654702-7199-1-git-send-email-matthew.d.roper@intel.com>
 <20140625082838.GB23572@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id CD1A689E5A
 for <intel-gfx@lists.freedesktop.org>; Wed, 25 Jun 2014 03:13:02 -0700 (PDT)
In-Reply-To: <20140625082838.GB23572@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Matt Roper <matthew.d.roper@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 25 Jun 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Jun 24, 2014 at 05:05:02PM -0700, Matt Roper wrote:
>> crtc->primary->fb may be NULL upon entry to intel_pipe_set_base() if the
>> primary plane has previously been disabled via the universal plane
>> interface.  We need to check for NULL before trying to reference
>> old_fb's obj.
>> 
>> This fixes a regression introduced in
>> 
>>         commit a071fa00647bc9a3c53f917b236fff9aea175e3a
>>         Author: Daniel Vetter <daniel.vetter@ffwll.ch>
>>         Date:   Wed Jun 18 23:28:09 2014 +0200
>> 
>>         drm/i915: Introduce accurate frontbuffer tracking
>> 
>> Testcase: igt/kms_universal_plane
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>
> Oh for a safe version of to_fb_obj().
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Pushed to dinq, thanks for the patch and review.

BR,
Jani.


> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center