From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [IGT PATCH] intel_bios_reader: make edp block decode match kernel Date: Tue, 06 May 2014 19:04:21 +0300 Message-ID: <87wqdyki62.fsf@intel.com> References: <1399375643-8675-1-git-send-email-jani.nikula@intel.com> <20140506155836.GA8012@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id DAD036E31C for ; Tue, 6 May 2014 09:04:32 -0700 (PDT) In-Reply-To: <20140506155836.GA8012@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 06 May 2014, Damien Lespiau wrote: > On Tue, May 06, 2014 at 02:27:23PM +0300, Jani Nikula wrote: >> All the somewhat recent VBT specs and the kernel have different format >> for the eDP block than what the tool decodes. What the tool does *may* >> be correct for really old VBT, but I have no specs or other reference to >> suppor this. Just do what the kernel does, that's what we're interested >> in anyway. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Damien Lespiau > > You may want to add checks on the VBT revision that introduce the > different parameters. I *wanted* to. But the versions in the spec apparently get changed also when that part about the spec actually hasn't changed. At least my 140-something spec had some of the same stuff that was indicated as having been added at 150-something. :( > We're also missing the VswingPreEmphasisValue fields from rev. 173. Yup, need to be added later (when we actually start using those). Ok to push? BR, Jani. > > -- > Damien > >> --- >> tools/intel_bios.h | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/tools/intel_bios.h b/tools/intel_bios.h >> index 128502039c66..832c580dd084 100644 >> --- a/tools/intel_bios.h >> +++ b/tools/intel_bios.h >> @@ -590,8 +590,11 @@ struct edp_link_params { >> struct bdb_edp { >> struct edp_power_seq power_seqs[16]; >> uint32_t color_depth; >> - uint32_t sdrrs_msa_timing_delay; >> struct edp_link_params link_params[16]; >> + uint32_t sdrrs_msa_timing_delay; >> + >> + uint16_t edp_s3d_feature; >> + uint16_t edp_t3_optimization; >> } __attribute__ ((packed)); >> >> /* >> -- >> 1.9.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center