From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH 4/6] drm/i915/dp: use the new drm helpers
	for dp aux
Date: Mon, 17 Mar 2014 16:54:49 +0200
Message-ID: <87wqfszxhi.fsf@intel.com>
References: <cover.1394808141.git.jani.nikula@intel.com>
 <b994d5c8a7097c82a45945add06b073bf95057af.1394808141.git.jani.nikula@intel.com>
 <CABVU7+vU3QkLFW08oTtUbC7sxdYv5snyWVQROkt0Txjn38T24w@mail.gmail.com>
 <CABVU7+tVWGZ5ihspC7BKeo=Sc7We=eZz2giC=hVqDUD5g_-pyw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 16D8C8A531
 for <intel-gfx@lists.freedesktop.org>; Mon, 17 Mar 2014 07:54:39 -0700 (PDT)
In-Reply-To: <CABVU7+tVWGZ5ihspC7BKeo=Sc7We=eZz2giC=hVqDUD5g_-pyw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, Thierry Reding <thierry.reding@gmail.com>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 17 Mar 2014, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> On Mon, Mar 17, 2014 at 11:08 AM, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
>> On Fri, Mar 14, 2014 at 11:51 AM, Jani Nikula <jani.nikula@intel.com> wrote:
>>> -       if (!intel_dp_aux_native_read(intel_dp, DP_TEST_SINK_MISC, buf, 1))
>>> +       if (drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK_MISC, buf) < 0);
>
> wrong ";" here..

Yikes, good catch. I've been rebasing this way too many times...

Jani.


-- 
Jani Nikula, Intel Open Source Technology Center