From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH] drm/i915: demote opregion excessive timeout
	WARN_ONCE to DRM_INFO
Date: Fri, 31 Jan 2014 13:55:47 +0200
Message-ID: <87wqhg2wn0.fsf@intel.com>
References: <20140131093802.GR29091@nuc-i3427.alporthouse.com>
	<1391168468-9072-1-git-send-email-jani.nikula@intel.com>
	<20140131114310.GV29091@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id D0FFEFA21D
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 31 Jan 2014 07:17:21 -0800 (PST)
In-Reply-To: <20140131114310.GV29091@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 31 Jan 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, Jan 31, 2014 at 01:41:08PM +0200, Jani Nikula wrote:
>> The WARN is a bit too verbose, make it a DRM_INFO that gets printed
>> once.
>> 
>> While at it, fix the typo in DSLP.
>> 
>> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_opregion.c |    6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
>> index 46d288055345..0fae017c4c7b 100644
>> --- a/drivers/gpu/drm/i915/intel_opregion.c
>> +++ b/drivers/gpu/drm/i915/intel_opregion.c
>> @@ -263,7 +263,11 @@ static int swsci(struct drm_device *dev, u32 function, u32 parm, u32 *parm_out)
>>  		dslp = 50;
>>  	} else if (dslp > 1500) {
>>  		/* Hey bios, trust must be earned. */
>> -		WARN_ONCE(1, "excessive driver sleep timeout (DSPL) %u\n", dslp);
>> +		static bool warned;
>> +		if (!warned) {
>> +			DRM_INFO("excessive driver sleep timeout (DSLP) %u\n", dslp);
>
> DRM_INFO("ACPI BIOS requests an excessive sleep of %d ms, using %d instead\n", dslp, MAX_DSLP);

You're just saying that because I didn't dare to write the new value
back to opregion! :p


>
>> +			warned = true;
>> +		}
>>  		dslp = 1500;
>>  	}
>>  
>> -- 
>> 1.7.9.5
>> 
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre

-- 
Jani Nikula, Intel Open Source Technology Center