From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD0A8C4345F for ; Tue, 23 Apr 2024 14:41:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D791113414; Tue, 23 Apr 2024 14:41:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Zu29I2R3"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 19136113414 for ; Tue, 23 Apr 2024 14:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713883316; x=1745419316; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=w0YOcLZiA7vVOzJymjr9cO5018hFoS8hbWZiyAMpX4U=; b=Zu29I2R3m2F8dDEwstu4dFUmj8onOKW4l9h4ZHzBZpridq5gDZd0RHg9 QorpY3Y4QHVquItxta6b2NGr9kZFeNaloh+U0/aFO6BIYhAM5KWL2QPlz vT6gBeow5ob05MSOfzI43QVgAcIL8C2H4u8enYAJkOWLD4ZkVm6AdUf27 rtYGhF6Amqv/uZ8kFdZFGkR89fP+IDEdYXRvo1xgeFztNFmCvOT4WEPoi jwUGxMP0Hj8X7659dsK59iLFlT36BfpKHS8nj0F370xImSLsiiP7xpeo5 tscK3fxIaxpFVeaKJ6hS9SyexNtxB8yqtfk03oryuPsCQUJfFFIteaV7g g==; X-CSE-ConnectionGUID: nXihh3tgRVGTzJT25WeGEQ== X-CSE-MsgGUID: 2mHZUWvlSUiPyOlOYO2L7Q== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="20871724" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="20871724" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 07:41:56 -0700 X-CSE-ConnectionGUID: 7lYd0sBAR6W3qMOZ9wSuCw== X-CSE-MsgGUID: hc6Y6x4KS1WL0JzjtBFm0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="24390259" Received: from fpirou-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.46.117]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 07:41:54 -0700 From: Jani Nikula To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH v2 1/4] drm/i915/dsi: remove unused _MIPIA_AUTOPWG register definition In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <57afda02856a68f78fe4d30384d4f7b352b9a812.1713520813.git.jani.nikula@intel.com> Date: Tue, 23 Apr 2024 17:41:52 +0300 Message-ID: <87y194qgy7.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 22 Apr 2024, Rodrigo Vivi wrote: > On Fri, Apr 19, 2024 at 01:04:03PM +0300, Jani Nikula wrote: >> There are other unused registers, but this is also unusable and >> inadequate. Remove. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Rodrigo Vivi Thanks for the review, pushed the lot to din. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/vlv_dsi_regs.h | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi_regs.h b/drivers/gpu/drm/i915/display/vlv_dsi_regs.h >> index abbe427e462e..b0cdaad7db9c 100644 >> --- a/drivers/gpu/drm/i915/display/vlv_dsi_regs.h >> +++ b/drivers/gpu/drm/i915/display/vlv_dsi_regs.h >> @@ -93,9 +93,6 @@ >> #define TEARING_EFFECT_DELAY_SHIFT 0 >> #define TEARING_EFFECT_DELAY_MASK (0xffff << 0) >> >> -/* XXX: all bits reserved */ >> -#define _MIPIA_AUTOPWG (VLV_DISPLAY_BASE + 0x611a0) >> - >> /* MIPI DSI Controller and D-PHY registers */ >> >> #define _MIPIA_DEVICE_READY (_MIPI_MMIO_BASE(dev_priv) + 0xb000) >> -- >> 2.39.2 >> -- Jani Nikula, Intel