From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F4230C433F5 for ; Thu, 10 Mar 2022 09:27:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7EF7910FE1C; Thu, 10 Mar 2022 09:27:34 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29C1410FE1A for ; Thu, 10 Mar 2022 09:27:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646904453; x=1678440453; h=from:to:subject:in-reply-to:references:date:message-id: mime-version:content-transfer-encoding; bh=mECuSn1SVn8bMIK+lXnFWb2TwFpZvOJHKYbf7SFiy/s=; b=f4Z4zfY6xAWmUHK2Tk3GoWtGp4MR1+7o+cyzkmBtmpgccdBjjmZRwBOv RLPMU1nR4nNwnj1z70xJOEYwKSE4d7rM8UWi8rL8DSqB8417Mxz5MARof SzQX2KAEZygbvnaVGukhR7U5x8KlVOssQvSDpqnaca7f3KNwsGewCS8oB +FaMSm/Osbb3GQS501l3tqs1Vl8aoyhpDJX9w5FBeX3nDG+zj3B1EX0I5 o/6eTgMyieuLvBBw0AKqOmxHuO9n6EcuPtnI940Ylb5kHfPJECXHKO6pT adxrBdQ2dFsF8nLvXyoHmOSs5VqT01vIGDNZteyKgbm8uXoDxCMpaB9aB Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10281"; a="235810891" X-IronPort-AV: E=Sophos;i="5.90,170,1643702400"; d="scan'208";a="235810891" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 01:27:28 -0800 X-IronPort-AV: E=Sophos;i="5.90,170,1643702400"; d="scan'208";a="538379844" Received: from mgherza1-mobl.ger.corp.intel.com (HELO localhost) ([10.252.55.69]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 01:27:24 -0800 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org In-Reply-To: <20220310004802.16310-4-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220310004802.16310-1-ville.syrjala@linux.intel.com> <20220310004802.16310-4-ville.syrjala@linux.intel.com> Date: Thu, 10 Mar 2022 11:27:21 +0200 Message-ID: <87y21ixime.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 03/13] drm/i915: Pimp DRRS debugs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 10 Mar 2022, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > Use the standard [CONNECTOR:%d:%s] format in the DRRS debugs. > > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_drrs.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c b/drivers/gpu/drm/= i915/display/intel_drrs.c > index 3b871a51eb55..17bedecbd7b2 100644 > --- a/drivers/gpu/drm/i915/display/intel_drrs.c > +++ b/drivers/gpu/drm/i915/display/intel_drrs.c > @@ -432,26 +432,32 @@ intel_drrs_init(struct intel_connector *connector, >=20=20 > if (DISPLAY_VER(dev_priv) <=3D 6) { > drm_dbg_kms(&dev_priv->drm, > - "DRRS supported for Gen7 and above\n"); > + "[CONNECTOR:%d:%s] DRRS not supported on platform\n", > + connector->base.base.id, connector->base.name); > return NULL; > } >=20=20 > if ((DISPLAY_VER(dev_priv) < 8 && !HAS_GMCH(dev_priv)) && > encoder->port !=3D PORT_A) { > drm_dbg_kms(&dev_priv->drm, > - "DRRS only supported on eDP port A\n"); > + "[CONNECTOR:%d:%s] DRRS not supported on [ENCODER:%d:%s]\n", > + connector->base.base.id, connector->base.name, > + encoder->base.base.id, encoder->base.name); > return NULL; > } >=20=20 > if (dev_priv->vbt.drrs_type !=3D SEAMLESS_DRRS_SUPPORT) { > - drm_dbg_kms(&dev_priv->drm, "VBT doesn't support DRRS\n"); > + drm_dbg_kms(&dev_priv->drm, > + "[CONNECTOR:%d:%s] DRRS not supported according to VBT\n", > + connector->base.base.id, connector->base.name); > return NULL; > } >=20=20 > downclock_mode =3D intel_panel_edid_downclock_mode(connector, fixed_mod= e); > if (!downclock_mode) { > drm_dbg_kms(&dev_priv->drm, > - "Downclock mode is not found. DRRS not supported\n"); > + "[CONNECTOR:%d:%s] DRRS not supported due to lack of downclock mo= de\n", > + connector->base.base.id, connector->base.name); > return NULL; > } >=20=20 > @@ -459,6 +465,8 @@ intel_drrs_init(struct intel_connector *connector, >=20=20 > dev_priv->drrs.refresh_rate_type =3D DRRS_HIGH_RR; > drm_dbg_kms(&dev_priv->drm, > - "seamless DRRS supported for eDP panel.\n"); > + "[CONNECTOR:%d:%s] seamless DRRS supported\n", > + connector->base.base.id, connector->base.name); > + > return downclock_mode; > } --=20 Jani Nikula, Intel Open Source Graphics Center