From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DC34C433F5 for ; Tue, 11 Jan 2022 08:34:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5610F11266C; Tue, 11 Jan 2022 08:34:44 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 61F5E112E4C; Tue, 11 Jan 2022 08:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641890080; x=1673426080; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=/0aU31xYzg/+MRAggb+53/jr584NfLEiehXMq2Y4qUw=; b=hfYnCvKsktU7JBFP49jte+/G19+B82SbaWjuZ6XnO0YjO+YOElOeNs0i nWJaDqX1e3P4u2ENR5NGIRlL6P+K0BZxFnnR+AEizf/QSYbdIzS+k01Ft QhlST/HgL+RMilpw0NtrgBSqnTVxZCCcuy2dxzSXZ4EBDyFI6wYg5JAID 0W5CKKpVQ3C9+1i1UTEdN1o3GAoBD0zMFjiW2b+LPAy0UIGd2XRzeyVwg lceQsg7qaYT8r7ddQ2fhwXfePP7WbOLQruekKTMjrmojG2U6ogo/xymyq ZQyQit7VuMnC4ci6ysVTOlUpQME2r6ExJPmEhdHR8HvGU0i+lsFxmdXtj g==; X-IronPort-AV: E=McAfee;i="6200,9189,10223"; a="306787857" X-IronPort-AV: E=Sophos;i="5.88,279,1635231600"; d="scan'208";a="306787857" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2022 00:34:39 -0800 X-IronPort-AV: E=Sophos;i="5.88,279,1635231600"; d="scan'208";a="690920830" Received: from sjobrien-mobl3.ger.corp.intel.com (HELO localhost) ([10.252.25.241]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2022 00:34:37 -0800 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170712155102.26276-1-ville.syrjala@linux.intel.com> <20170712155102.26276-3-ville.syrjala@linux.intel.com> <87tueoj4bw.fsf@intel.com> Date: Tue, 11 Jan 2022 10:34:34 +0200 Message-ID: <87y23m8ycl.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 3/3] drm/atomic: Make private objs proper objects X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 10 Jan 2022, Ville Syrj=C3=A4l=C3=A4 wrote: > On Fri, Dec 31, 2021 at 03:23:31PM +0200, Jani Nikula wrote: >> On Wed, 12 Jul 2017, ville.syrjala@linux.intel.com wrote: >> > From: Ville Syrj=C3=A4l=C3=A4 >> > >> > Make the atomic private object stuff less special by introducing proper >> > base classes for the object and its state. Drivers can embed these in >> > their own appropriate objects, after which these things will work >> > exactly like the plane/crtc/connector states during atomic operations. >> > >> > v2: Reorder to not depend on drm_dynarray (Daniel) >> > >> > Cc: Dhinakaran Pandiyan >> > Cc: Daniel Vetter >> > Reviewed-by: Daniel Vetter #v1 >> > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 >>=20 >> Stumbled upon an old commit >>=20 >> commit a4370c777406c2810e37fafd166ccddecdb2a60c >> Author: Ville Syrj=C3=A4l=C3=A4 >> Date: Wed Jul 12 18:51:02 2017 +0300 >>=20 >> drm/atomic: Make private objs proper objects >>=20 >> which is this patch. >>=20 >> > @@ -3050,8 +3043,7 @@ struct drm_dp_mst_topology_state *drm_atomic_get= _mst_topology_state(struct drm_a >> > struct drm_device *dev =3D mgr->dev; >> >=20=20 >> > WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex)); >> > - return drm_atomic_get_private_obj_state(state, mgr, >> > - &mst_state_funcs); >> > + return to_dp_mst_topology_state(drm_atomic_get_private_obj_state(sta= te, &mgr->base)); >> > } >> > EXPORT_SYMBOL(drm_atomic_get_mst_topology_state); >>=20 >> I don't think this combines well with... >>=20 >> > diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_= helper.h >> > index 177ab6f86855..d55abb75f29a 100644 >> > --- a/include/drm/drm_dp_mst_helper.h >> > +++ b/include/drm/drm_dp_mst_helper.h >> > @@ -404,12 +404,17 @@ struct drm_dp_payload { >> > int vcpi; >> > }; >> >=20=20 >> > +#define to_dp_mst_topology_state(x) container_of(x, struct drm_dp_mst= _topology_state, base) >>=20 >> ...this in case of error pointers that >> drm_atomic_get_private_obj_state() may return. > > offsetof(base)=3D=3D0 so should work in practice. Returning zeros is fine, but error pointers are another matter. BR, Jani. --=20 Jani Nikula, Intel Open Source Graphics Center