From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH v9 04/10] drm/i915/dsb: Indexed register
 write function for DSB.
Date: Fri, 20 Sep 2019 15:18:06 +0300
Message-ID: <87y2yjtb41.fsf@intel.com>
References: <20190920115930.27829-1-animesh.manna@intel.com>
 <20190920115930.27829-5-animesh.manna@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 70E436FCE2
 for <intel-gfx@lists.freedesktop.org>; Fri, 20 Sep 2019 12:18:12 +0000 (UTC)
In-Reply-To: <20190920115930.27829-5-animesh.manna@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Animesh Manna <animesh.manna@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCAyMCBTZXAgMjAxOSwgQW5pbWVzaCBNYW5uYSA8YW5pbWVzaC5tYW5uYUBpbnRlbC5j
b20+IHdyb3RlOgo+IERTQiBjYW4gcHJvZ3JhbSBsYXJnZSBzZXQgb2YgZGF0YSB0aHJvdWdoIGlu
ZGV4ZWQgcmVnaXN0ZXIgd3JpdGUKPiAob3Bjb2RlIDB4OSkgaW4gb25lIHNob3QuIERTQiBmZWF0
dXJlIGNhbiBiZSB1c2VkIGZvciBidWxrIHJlZ2lzdGVyCj4gcHJvZ3JhbW1pbmcgZS5nLiBnYW1t
YSBsdXQgcHJvZ3JhbW1pbmcsIEhEUiBtZXRhIGRhdGEgcHJvZ3JhbW1pbmcuCj4KPiB2MTogaW5p
dGlhbCB2ZXJzaW9uLgo+IHYyOiBzaW1wbGlmaWVkIGNvZGUgYnkgdXNpbmcgQUxJR04oKS4gKENo
cmlzKQo+IHYzOiBhc2NpaSB0YWJsZSBhZGRlZCBhcyBjb2RlIGNvbW1lbnQuIChTaGFzaGFuaykK
PiB2NDogY29zbWV0aWMgY2hhbmdlcyBkb25lLiAoU2hhc2hhbmspCj4gdjU6IHJlc2V0IGluc19z
dGFydF9vZmZzZXQuIChKYW5pKQo+IHY2OiB1cGRhdGUgaW5zX3N0YXJ0X29mZnNldCBpbiBpbmVs
X2RzYl9yZWdfd3JpdGUuCj4KPiBDYzogU2hhc2hhbmsgU2hhcm1hIDxzaGFzaGFuay5zaGFybWFA
aW50ZWwuY29tPgo+IENjOiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gQ2M6IEph
bmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9k
cmlnby52aXZpQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogU2hhc2hhbmsgU2hhcm1hIDxzaGFz
aGFuay5zaGFybWFAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEFuaW1lc2ggTWFubmEgPGFu
aW1lc2gubWFubmFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw
bGF5L2ludGVsX2RzYi5jIHwgNjggKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGRyaXZlcnMv
Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmggfCAgOSArKysrCj4gIDIgZmlsZXMgY2hh
bmdlZCwgNzcgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2lu
dGVsX2RzYi5jCj4gaW5kZXggZjk0Y2Q2ZGM5OGI2Li5mYWE4NTNiMDg0NTggMTAwNjQ0Cj4gLS0t
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kc2IuYwo+ICsrKyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmMKPiBAQCAtMTIsOCArMTIsMTAgQEAK
PiAgLyogRFNCIG9wY29kZXMuICovCj4gICNkZWZpbmUgRFNCX09QQ09ERV9TSElGVAkJMjQKPiAg
I2RlZmluZSBEU0JfT1BDT0RFX01NSU9fV1JJVEUJCTB4MQo+ICsjZGVmaW5lIERTQl9PUENPREVf
SU5ERVhFRF9XUklURQkweDkKPiAgI2RlZmluZSBEU0JfQllURV9FTgkJCTB4Rgo+ICAjZGVmaW5l
IERTQl9CWVRFX0VOX1NISUZUCQkyMAo+ICsjZGVmaW5lIERTQl9SRUdfVkFMVUVfTUFTSwkJMHhm
ZmZmZgo+ICAKPiAgc3RydWN0IGludGVsX2RzYiAqCj4gIGludGVsX2RzYl9nZXQoc3RydWN0IGlu
dGVsX2NydGMgKmNydGMpCj4gQEAgLTgzLDkgKzg1LDc0IEBAIHZvaWQgaW50ZWxfZHNiX3B1dChz
dHJ1Y3QgaW50ZWxfZHNiICpkc2IpCj4gIAkJbXV0ZXhfdW5sb2NrKCZpOTE1LT5kcm0uc3RydWN0
X211dGV4KTsKPiAgCQlkc2ItPmNtZF9idWYgPSBOVUxMOwo+ICAJCWRzYi0+ZnJlZV9wb3MgPSAw
Owo+ICsJCWRzYi0+aW5zX3N0YXJ0X29mZnNldCA9IDA7Cj4gIAl9Cj4gIH0KPiAgCj4gK3ZvaWQg
aW50ZWxfZHNiX2luZGV4ZWRfcmVnX3dyaXRlKHN0cnVjdCBpbnRlbF9kc2IgKmRzYiwgaTkxNV9y
ZWdfdCByZWcsCj4gKwkJCQkgdTMyIHZhbCkKPiArewo+ICsJc3RydWN0IGludGVsX2NydGMgKmNy
dGMgPSBjb250YWluZXJfb2YoZHNiLCB0eXBlb2YoKmNydGMpLCBkc2IpOwo+ICsJc3RydWN0IGRy
bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gKwl1
MzIgKmJ1ZiA9IGRzYi0+Y21kX2J1ZjsKPiArCXUzMiByZWdfdmFsOwo+ICsKPiArCWlmICghYnVm
KSB7Cj4gKwkJSTkxNV9XUklURShyZWcsIHZhbCk7Cj4gKwkJcmV0dXJuOwo+ICsJfQo+ICsKPiAr
CWlmIChXQVJOX09OKGRzYi0+ZnJlZV9wb3MgPj0gRFNCX0JVRl9TSVpFKSkgewo+ICsJCURSTV9E
RUJVR19LTVMoIkRTQiBidWZmZXIgb3ZlcmZsb3dcbiIpOwo+ICsJCXJldHVybjsKPiArCX0KPiAr
Cj4gKwkvKgo+ICsJICogRm9yIGV4YW1wbGUgdGhlIGJ1ZmZlciB3aWxsIGxvb2sgbGlrZSBiZWxv
dyBmb3IgMyBkd29yZHMgZm9yIGF1dG8KPiArCSAqIGluY3JlbWVudCByZWdpc3RlcjoKPiArCSAq
ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LSsKPiArCSAqIHwgc2l6ZSA9IDMgfCBvZmZzZXQgJnwgdmFsdWUxIHwgdmFsdWUyIHwgdmFsdWUz
IHwgemVybyAgIHwKPiArCSAqIHwgICAgICAgICAgfCBvcGNvZGUgIHwgICAgICAgIHwgICAgICAg
IHwgICAgICAgIHwgICAgICAgIHwKPiArCSAqICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiArCSAqICsgICAgICAgICAgKyAgICAgICAg
ICsgICAgICAgICsgICAgICAgICsgICAgICAgICsgICAgICAgICsKPiArCSAqIDAgICAgICAgICAg
NCAgICAgICAgIDggICAgICAgIDEyICAgICAgIDE2ICAgICAgIDIwICAgICAgIDI0Cj4gKwkgKiBC
eXRlCj4gKwkgKgo+ICsJICogQXMgZXZlcnkgaW5zdHJ1Y3Rpb24gaXMgOCBieXRlIGFsaWduZWQg
dGhlIGluZGV4IG9mIGRzYiBpbnN0cnVjdGlvbgo+ICsJICogd2lsbCBzdGFydCBhbHdheXMgZnJv
bSBldmVuIG51bWJlciB3aGlsZSBkZWFsaW5nIHdpdGggdTMyIGFycmF5LiBJZgo+ICsJICogd2Ug
YXJlIHdyaXRpbmcgb2RkIG5vIG9mIGR3b3JkcywgWmVyb3Mgd2lsbCBiZSBhZGRlZCBpbiB0aGUg
ZW5kIGZvcgo+ICsJICogcGFkZGluZy4KPiArCSAqLwo+ICsJcmVnX3ZhbCA9IGJ1Zltkc2ItPmlu
c19zdGFydF9vZmZzZXQgKyAxXSAmIERTQl9SRUdfVkFMVUVfTUFTSzsKPiArCWlmIChyZWdfdmFs
ICE9IGk5MTVfbW1pb19yZWdfb2Zmc2V0KHJlZykpIHsKPiArCQkvKiBFdmVyeSBpbnN0cnVjdGlv
biBzaG91bGQgYmUgOCBieXRlIGFsaWduZWQuICovCj4gKwkJZHNiLT5mcmVlX3BvcyA9IEFMSUdO
KGRzYi0+ZnJlZV9wb3MsIDIpOwo+ICsKPiArCQlkc2ItPmluc19zdGFydF9vZmZzZXQgPSBkc2It
PmZyZWVfcG9zOwo+ICsKPiArCQkvKiBVcGRhdGUgdGhlIHNpemUuICovCj4gKwkJYnVmW2RzYi0+
ZnJlZV9wb3MrK10gPSAxOwo+ICsKPiArCQkvKiBVcGRhdGUgdGhlIG9wY29kZSBhbmQgcmVnLiAq
Lwo+ICsJCWJ1Zltkc2ItPmZyZWVfcG9zKytdID0gKERTQl9PUENPREVfSU5ERVhFRF9XUklURSAg
PDwKPiArCQkJCQlEU0JfT1BDT0RFX1NISUZUKSB8Cj4gKwkJCQkJaTkxNV9tbWlvX3JlZ19vZmZz
ZXQocmVnKTsKPiArCj4gKwkJLyogVXBkYXRlIHRoZSB2YWx1ZS4gKi8KPiArCQlidWZbZHNiLT5m
cmVlX3BvcysrXSA9IHZhbDsKPiArCX0gZWxzZSB7Cj4gKwkJLyogVXBkYXRlIHRoZSBuZXcgdmFs
dWUuICovCj4gKwkJYnVmW2RzYi0+ZnJlZV9wb3MrK10gPSB2YWw7Cj4gKwo+ICsJCS8qIFVwZGF0
ZSB0aGUgc2l6ZS4gKi8KPiArCQlidWZbZHNiLT5pbnNfc3RhcnRfb2Zmc2V0XSsrOwo+ICsJfQo+
ICsKPiArCS8qIGlmIG51bWJlciBvZiBkYXRhIHdvcmRzIGlzIG9kZCwgdGhlbiB0aGUgbGFzdCBk
d29yZCBzaG91bGQgYmUgMC4qLwo+ICsJaWYgKGRzYi0+ZnJlZV9wb3MgJiAweDEpCj4gKwkJYnVm
W2RzYi0+ZnJlZV9wb3NdID0gMDsKPiArfQo+ICsKPiAgdm9pZCBpbnRlbF9kc2JfcmVnX3dyaXRl
KHN0cnVjdCBpbnRlbF9kc2IgKmRzYiwgaTkxNV9yZWdfdCByZWcsIHUzMiB2YWwpCj4gIHsKPiAg
CXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gY29udGFpbmVyX29mKGRzYiwgdHlwZW9mKCpjcnRj
KSwgZHNiKTsKPiBAQCAtMTAyLDYgKzE2OSw3IEBAIHZvaWQgaW50ZWxfZHNiX3JlZ193cml0ZShz
dHJ1Y3QgaW50ZWxfZHNiICpkc2IsIGk5MTVfcmVnX3QgcmVnLCB1MzIgdmFsKQo+ICAJCXJldHVy
bjsKPiAgCX0KPiAgCj4gKwlkc2ItPmluc19zdGFydF9vZmZzZXQgPSBkc2ItPmZyZWVfcG9zOwoK
T2theSwgSSdtIGJlaW5nIGEgcGVkYW50LCBidXQgdGhhdCdzIGtpbmQgb2YgcGFydCBvZiB0aGUg
am9iCmRlc2NyaXB0aW9uLCBJJ20gYWZyYWlkLgoKV2hhdCBpZjoKCmludGVsX2RzYl9nZXQoKQpp
bnRlbF9kc2JfcmVnX3dyaXRlKGRzYiwgRk9PLCAwKTsKaW50ZWxfZHNiX2luZGV4ZWRfcmVnX3dy
aXRlKGRzYiwgRk9PLCAwKTsKaW50ZWxfZHNiX2NvbW1pdCgpCmludGVsX2RzYl9wdXQoKQoKQlIs
CkphbmkuCgo+ICAJYnVmW2RzYi0+ZnJlZV9wb3MrK10gPSB2YWw7Cj4gIAlidWZbZHNiLT5mcmVl
X3BvcysrXSA9IChEU0JfT1BDT0RFX01NSU9fV1JJVEUgIDw8IERTQl9PUENPREVfU0hJRlQpIHwK
PiAgCQkJICAgICAgIChEU0JfQllURV9FTiA8PCBEU0JfQllURV9FTl9TSElGVCkgfAo+IGRpZmYg
LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5oIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kc2IuaAo+IGluZGV4IDA2ODZkNjdiMzRkNS4u
MmFlMjJmNzMwOWE3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkv
aW50ZWxfZHNiLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rz
Yi5oCj4gQEAgLTMwLDExICszMCwyMCBAQCBzdHJ1Y3QgaW50ZWxfZHNiIHsKPiAgCSAqIGFuZCBo
ZWxwIGluIGNhbGN1bGF0aW5nIHRhaWwgb2YgY29tbWFuZCBidWZmZXIuCj4gIAkgKi8KPiAgCWlu
dCBmcmVlX3BvczsKPiArCj4gKwkvKgo+ICsJICogaW5zX3N0YXJ0X29mZnNldCB3aWxsIGhlbHAg
dG8gc3RvcmUgc3RhcnQgYWRkcmVzcyBvZiB0aGUgZHNiCj4gKwkgKiBpbnN0dWN0aW9uIGFuZCBo
ZWxwIGluIGlkZW50aWZ5aW5nIHRoZSBiYXRjaCBvZiBhdXRvLWluY3JlbWVudAo+ICsJICogcmVn
aXN0ZXIuCj4gKwkgKi8KPiArCXUzMiBpbnNfc3RhcnRfb2Zmc2V0Owo+ICB9Owo+ICAKPiAgc3Ry
dWN0IGludGVsX2RzYiAqCj4gIGludGVsX2RzYl9nZXQoc3RydWN0IGludGVsX2NydGMgKmNydGMp
Owo+ICB2b2lkIGludGVsX2RzYl9wdXQoc3RydWN0IGludGVsX2RzYiAqZHNiKTsKPiAgdm9pZCBp
bnRlbF9kc2JfcmVnX3dyaXRlKHN0cnVjdCBpbnRlbF9kc2IgKmRzYiwgaTkxNV9yZWdfdCByZWcs
IHUzMiB2YWwpOwo+ICt2b2lkIGludGVsX2RzYl9pbmRleGVkX3JlZ193cml0ZShzdHJ1Y3QgaW50
ZWxfZHNiICpkc2IsIGk5MTVfcmVnX3QgcmVnLAo+ICsJCQkJIHUzMiB2YWwpOwo+ICAKPiAgI2Vu
ZGlmCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg
bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=