From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH v2 1/2] drm/i915/icl: Factor out combo PHY
 lane power setup helper
Date: Tue, 30 Apr 2019 15:44:00 +0300
Message-ID: <87y33rpsrz.fsf@intel.com>
References: <20190425185253.3197-1-imre.deak@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 85C9389121
 for <intel-gfx@lists.freedesktop.org>; Tue, 30 Apr 2019 12:41:49 +0000 (UTC)
In-Reply-To: <20190425185253.3197-1-imre.deak@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCAyNSBBcHIgMjAxOSwgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90
ZToKPiBGYWN0b3Igb3V0IHRoZSBjb21ibyBQSFkgbGFuZSBwb3dlciBjb25maWd1cmF0aW9uIGNv
ZGUgdG8gYSBzZXBhcmF0ZQo+IGhlbHBlcjsgaXQgd2lsbCBiZSBhbHNvIG5lZWRlZCBieSB0aGUg
bmV4dCBwYXRjaCBhZGRpbmcgdGhlIHNhbWUKPiBjb25maWd1cmF0aW9uIGZvciBEREkgcG9ydHMu
Cj4KPiBBZGQgc3VwcG9ydCBmb3IgRERJIHBvcnRzIGFuZCBsYW5lIHJldmVyc2FsIGFzIHByZXBh
cmF0aW9uIGZvciB0aGUgbmV4dAo+IHBhdGNoLgo+Cj4gVGhlIFBXUl9ET1dOX0xOXzEgdmFsdWUg
aXMgdW5zcGVjaWZpZWQgaW4gdGhlIEJTcGVjIHJlZ2lzdGVyIGRlc2NyaXB0aW9uCj4gc28gcmVt
b3ZlIGl0Lgo+Cj4gdjI6Cj4gLSBGaXggdXAgdGhlIHdyb25nIGFzc3VtcHRpb24gdGhhdCB0aGUg
ZW5jb2RpbmdzIGFyZSB0aGUgc2FtZSBmb3IgRERJCj4gICBhbmQgRFNJIHBvcnRzLiAoSmFuaSkK
PgoKQm90aCBwYXRjaGVzIGxvb2sgZ29vZCB0byBtZSwgYnV0IEknbSBhZnJhaWQgcGF0Y2ggMSBj
b25mbGljdHMgd2l0aCB0aGUKaGVhZGVyIHJlZmFjdG9yaW5nIEkgcHVzaGVkIGVhcmxpZXIsIGFz
IHdlbGwgYXMgdGhlIGZ1bmN0aW9uIG5hbWUKY2hhbmdlcyBpbiBbMV0uIEkgdGhpbmsgSSdkIGxp
a2UgdGhlIGZ1bmN0aW9uIGhlcmUgdG8gYmUgcmVuYW1lZAphY2NvcmRpbmdseS4KCk90aGVyIHRo
YW4gdGhhdCwgZm9yIGJvdGgsCgpSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxh
QGludGVsLmNvbT4KClsxXSBodHRwOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC9t
c2dpZC8yMDE5MDQzMDEyNDEyOC4yMzYwNi0xLWphbmkubmlrdWxhQGludGVsLmNvbQoKCj4gQ2M6
IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gQ2M6IE1hZGhhdiBDaGF1aGFu
IDxtYWRoYXYuY2hhdWhhbkBpbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmphbGEgPHZpbGxlLnN5
cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5k
ZWFrQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAg
ICAgICAgfCAgMyArKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICAgICB8
ICAxIC0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaWNsX2RzaS5jICAgICAgICAgfCAyNiArKy0t
LS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb21ib19waHkuYyB8
IDUyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgNCBmaWxlcyBjaGFuZ2Vk
LCA1OCBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k
cnYuaAo+IGluZGV4IGRjNzRkMzNjMjBhYS4uODdmMjRkOTJlMzU1IDEwMDY0NAo+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2Rydi5oCj4gQEAgLTM1MTUsNiArMzUxNSw5IEBAIHZvaWQgaWNsX2NvbWJvX3BoeXNf
aW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICB2b2lkIGljbF9jb21i
b19waHlzX3VuaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICB2b2lk
IGNubF9jb21ib19waHlzX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsK
PiAgdm9pZCBjbmxfY29tYm9fcGh5c191bmluaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2KTsKPiArdm9pZCBpY2xfY29tYm9fcGh5X3Bvd2VyX3VwX2xhbmVzKHN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiArCQkJCSAgZW51bSBwb3J0IHBvcnQsIGJvb2wgaXNf
ZHNpLAo+ICsJCQkJICBpbnQgbGFuZV9jb3VudCwgYm9vbCBsYW5lX3JldmVyc2FsKTsKPiAgCj4g
IGludCBpbnRlbF9ncHVfZnJlcShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGlu
dCB2YWwpOwo+ICBpbnQgaW50ZWxfZnJlcV9vcGNvZGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg
KmRldl9wcml2LCBpbnQgdmFsKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aTkxNV9yZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBpbmRleCBiNzQ4
MjRmMGI1YjEuLmUzMzJiOWY2OWE0YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X3JlZy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IEBA
IC0xODEzLDcgKzE4MTMsNiBAQCBlbnVtIGk5MTVfcG93ZXJfd2VsbF9pZCB7Cj4gICNkZWZpbmUg
IFBXUl9ET1dOX0xOXzMJCQkoMHg4IDw8IDQpCj4gICNkZWZpbmUgIFBXUl9ET1dOX0xOXzJfMV8w
CQkoMHg3IDw8IDQpCj4gICNkZWZpbmUgIFBXUl9ET1dOX0xOXzFfMAkJKDB4MyA8PCA0KQo+IC0j
ZGVmaW5lICBQV1JfRE9XTl9MTl8xCQkJKDB4MiA8PCA0KQo+ICAjZGVmaW5lICBQV1JfRE9XTl9M
Tl8zXzEJCSgweGEgPDwgNCkKPiAgI2RlZmluZSAgUFdSX0RPV05fTE5fM18xXzAJCSgweGIgPDwg
NCkKPiAgI2RlZmluZSAgUFdSX0RPV05fTE5fTUFTSwkJKDB4ZiA8PCA0KQo+IGRpZmYgLS1naXQg
YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pY2xfZHNpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
Y2xfZHNpLmMKPiBpbmRleCA5ZDk2MmVhMWU2MzUuLmYyMTEzZDM3OThiMCAxMDA2NDQKPiAtLS0g
YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pY2xfZHNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pY2xfZHNpLmMKPiBAQCAtMzYzLDMwICszNjMsMTAgQEAgc3RhdGljIHZvaWQgZ2VuMTFf
ZHNpX3Bvd2VyX3VwX2xhbmVzKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ICAJc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShlbmNvZGVyLT5iYXNlLmRl
dik7Cj4gIAlzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2kgPSBlbmNfdG9faW50ZWxfZHNpKCZl
bmNvZGVyLT5iYXNlKTsKPiAgCWVudW0gcG9ydCBwb3J0Owo+IC0JdTMyIHRtcDsKPiAtCXUzMiBs
YW5lX21hc2s7Cj4gIAo+IC0Jc3dpdGNoIChpbnRlbF9kc2ktPmxhbmVfY291bnQpIHsKPiAtCWNh
c2UgMToKPiAtCQlsYW5lX21hc2sgPSBQV1JfRE9XTl9MTl8zXzFfMDsKPiAtCQlicmVhazsKPiAt
CWNhc2UgMjoKPiAtCQlsYW5lX21hc2sgPSBQV1JfRE9XTl9MTl8zXzE7Cj4gLQkJYnJlYWs7Cj4g
LQljYXNlIDM6Cj4gLQkJbGFuZV9tYXNrID0gUFdSX0RPV05fTE5fMzsKPiAtCQlicmVhazsKPiAt
CWNhc2UgNDoKPiAtCWRlZmF1bHQ6Cj4gLQkJbGFuZV9tYXNrID0gUFdSX1VQX0FMTF9MQU5FUzsK
PiAtCQlicmVhazsKPiAtCX0KPiAtCj4gLQlmb3JfZWFjaF9kc2lfcG9ydChwb3J0LCBpbnRlbF9k
c2ktPnBvcnRzKSB7Cj4gLQkJdG1wID0gSTkxNV9SRUFEKElDTF9QT1JUX0NMX0RXMTAocG9ydCkp
Owo+IC0JCXRtcCAmPSB+UFdSX0RPV05fTE5fTUFTSzsKPiAtCQlJOTE1X1dSSVRFKElDTF9QT1JU
X0NMX0RXMTAocG9ydCksIHRtcCB8IGxhbmVfbWFzayk7Cj4gLQl9Cj4gKwlmb3JfZWFjaF9kc2lf
cG9ydChwb3J0LCBpbnRlbF9kc2ktPnBvcnRzKQo+ICsJCWljbF9jb21ib19waHlfcG93ZXJfdXBf
bGFuZXMoZGV2X3ByaXYsIHBvcnQsIHRydWUsCj4gKwkJCQkJICAgICBpbnRlbF9kc2ktPmxhbmVf
Y291bnQsIGZhbHNlKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgZ2VuMTFfZHNpX2NvbmZpZ19w
aHlfbGFuZXNfc2VxdWVuY2Uoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gZGlmZiAt
LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbWJvX3BoeS5jIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfY29tYm9fcGh5LmMKPiBpbmRleCAyYmY0MzU5ZDdlNDEuLjU0Nzg4
MDg4ODZmMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb21ib19w
aHkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbWJvX3BoeS5jCj4gQEAg
LTIwMyw2ICsyMDMsNTggQEAgc3RhdGljIGJvb2wgaWNsX2NvbWJvX3BoeV92ZXJpZnlfc3RhdGUo
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJcmV0dXJuIHJldDsKPiAgfQo+
ICAKPiArdm9pZCBpY2xfY29tYm9fcGh5X3Bvd2VyX3VwX2xhbmVzKHN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdiwKPiArCQkJCSAgZW51bSBwb3J0IHBvcnQsIGJvb2wgaXNfZHNpLAo+
ICsJCQkJICBpbnQgbGFuZV9jb3VudCwgYm9vbCBsYW5lX3JldmVyc2FsKQo+ICt7Cj4gKwl1OCBs
YW5lX21hc2s7Cj4gKwl1MzIgdmFsOwo+ICsKPiArCWlmIChpc19kc2kpIHsKPiArCQlXQVJOX09O
KGxhbmVfcmV2ZXJzYWwpOwo+ICsKPiArCQlzd2l0Y2ggKGxhbmVfY291bnQpIHsKPiArCQljYXNl
IDE6Cj4gKwkJCWxhbmVfbWFzayA9IFBXUl9ET1dOX0xOXzNfMV8wOwo+ICsJCQlicmVhazsKPiAr
CQljYXNlIDI6Cj4gKwkJCWxhbmVfbWFzayA9IFBXUl9ET1dOX0xOXzNfMTsKPiArCQkJYnJlYWs7
Cj4gKwkJY2FzZSAzOgo+ICsJCQlsYW5lX21hc2sgPSBQV1JfRE9XTl9MTl8zOwo+ICsJCQlicmVh
azsKPiArCQlkZWZhdWx0Ogo+ICsJCQlNSVNTSU5HX0NBU0UobGFuZV9jb3VudCk7Cj4gKwkJCS8q
IGZhbGwtdGhyb3VnaCAqLwo+ICsJCWNhc2UgNDoKPiArCQkJbGFuZV9tYXNrID0gUFdSX1VQX0FM
TF9MQU5FUzsKPiArCQkJYnJlYWs7Cj4gKwkJfQo+ICsJfSBlbHNlIHsKPiArCQlzd2l0Y2ggKGxh
bmVfY291bnQpIHsKPiArCQljYXNlIDE6Cj4gKwkJCWxhbmVfbWFzayA9IGxhbmVfcmV2ZXJzYWwg
PyBQV1JfRE9XTl9MTl8yXzFfMCA6Cj4gKwkJCQkJCSAgICBQV1JfRE9XTl9MTl8zXzJfMTsKPiAr
CQkJYnJlYWs7Cj4gKwkJY2FzZSAyOgo+ICsJCQlsYW5lX21hc2sgPSBsYW5lX3JldmVyc2FsID8g
UFdSX0RPV05fTE5fMV8wIDoKPiArCQkJCQkJICAgIFBXUl9ET1dOX0xOXzNfMjsKPiArCQkJYnJl
YWs7Cj4gKwkJZGVmYXVsdDoKPiArCQkJTUlTU0lOR19DQVNFKGxhbmVfY291bnQpOwo+ICsJCQkv
KiBmYWxsLXRocm91Z2ggKi8KPiArCQljYXNlIDQ6Cj4gKwkJCWxhbmVfbWFzayA9IFBXUl9VUF9B
TExfTEFORVM7Cj4gKwkJCWJyZWFrOwo+ICsJCX0KPiArCX0KPiArCj4gKwl2YWwgPSBJOTE1X1JF
QUQoSUNMX1BPUlRfQ0xfRFcxMChwb3J0KSk7Cj4gKwl2YWwgJj0gflBXUl9ET1dOX0xOX01BU0s7
Cj4gKwl2YWwgfD0gbGFuZV9tYXNrIDw8IFBXUl9ET1dOX0xOX1NISUZUOwo+ICsJSTkxNV9XUklU
RShJQ0xfUE9SVF9DTF9EVzEwKHBvcnQpLCB2YWwpOwo+ICt9Cj4gKwo+ICB2b2lkIGljbF9jb21i
b19waHlzX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gIAll
bnVtIHBvcnQgcG9ydDsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhp
Y3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo
dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==