[PATCH] drm/i915/psr: Adds psrwake options for all platforms

[PATCH] drm/i915/psr: Adds psrwake options for all platforms

[vathsala nagaraju]

From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>

Adds new psrwake options defined in the below table.
Platform	PSR wake options vbt version
KBL/CFL/WHL	All
SKL		All PV releases (Check for 203+ might help but cannot be foolproof)
BXT		Uses old interpretation.
CNL/ICL+	All
GLK		All

For SKL, we will continue to use older interpretation for the above reason.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Puthikorn Voravootivat <puthik@chromium.org>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 465dff4..010ff68 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
 	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
 	 * Old decimal value is wake up time in multiples of 100 us.
 	 */
-	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
+	if ((INTEL_GEN(dev_priv) >= 10) ||
+	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv))) {
 		switch (psr_table->tp1_wakeup_time) {
 		case 0:
 			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Jani Nikula]

On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@intel.com> wrote:
> From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
>
> Adds new psrwake options defined in the below table.
> Platform	PSR wake options vbt version
> KBL/CFL/WHL	All
> SKL		All PV releases (Check for 203+ might help but cannot be foolproof)
> BXT		Uses old interpretation.
> CNL/ICL+	All
> GLK		All
>
> For SKL, we will continue to use older interpretation for the above reason.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Puthikorn Voravootivat <puthik@chromium.org>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 465dff4..010ff68 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
>  	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
>  	 * Old decimal value is wake up time in multiples of 100 us.
>  	 */
> -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
> +	if ((INTEL_GEN(dev_priv) >= 10) ||
> +	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv))) {

Please keep the version check.

Please tell anyone who asks, and also those who don't, that *all* of the
VBT changes should be based on the *version*, and *none* of them should
be based on the *platform*.

BR,
Jani.

>  		switch (psr_table->tp1_wakeup_time) {
>  		case 0:
>  			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Nagaraju, Vathsala]

On 6/12/2018 2:30 PM, Jani Nikula wrote:
> On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@intel.com> wrote:
>> From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
>>
>> Adds new psrwake options defined in the below table.
>> Platform	PSR wake options vbt version
>> KBL/CFL/WHL	All
>> SKL		All PV releases (Check for 203+ might help but cannot be foolproof)
>> BXT		Uses old interpretation.
>> CNL/ICL+	All
>> GLK		All
>>
>> For SKL, we will continue to use older interpretation for the above reason.
>>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Puthikorn Voravootivat <puthik@chromium.org>
>> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>>
>> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
>> ---
>>   drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
>> index 465dff4..010ff68 100644
>> --- a/drivers/gpu/drm/i915/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>> @@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
>>   	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
>>   	 * Old decimal value is wake up time in multiples of 100 us.
>>   	 */
>> -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
>> +	if ((INTEL_GEN(dev_priv) >= 10) ||
>> +	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv))) {
> Please keep the version check.
Sure. For SKL , shall we use older interpretation for all bdb version as 
vbt team cannot confirm bdb version for SKL?

> Please tell anyone who asks, and also those who don't, that *all* of the
> VBT changes should be based on the *version*, and *none* of them should
> be based on the *platform*.
>
> BR,
> Jani.
>
>>   		switch (psr_table->tp1_wakeup_time) {
>>   		case 0:
>>   			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Jani Nikula]

On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@intel.com> wrote:
> On 6/12/2018 2:30 PM, Jani Nikula wrote:
>> On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@intel.com> wrote:
>>> From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
>>>
>>> Adds new psrwake options defined in the below table.
>>> Platform	PSR wake options vbt version
>>> KBL/CFL/WHL	All
>>> SKL		All PV releases (Check for 203+ might help but cannot be foolproof)
>>> BXT		Uses old interpretation.
>>> CNL/ICL+	All
>>> GLK		All
>>>
>>> For SKL, we will continue to use older interpretation for the above reason.
>>>
>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> Cc: Puthikorn Voravootivat <puthik@chromium.org>
>>> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>>>
>>> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
>>> ---
>>>   drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
>>> index 465dff4..010ff68 100644
>>> --- a/drivers/gpu/drm/i915/intel_bios.c
>>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>>> @@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
>>>   	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
>>>   	 * Old decimal value is wake up time in multiples of 100 us.
>>>   	 */
>>> -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
>>> +	if ((INTEL_GEN(dev_priv) >= 10) ||
>>> +	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv))) {
>> Please keep the version check.
> Sure. For SKL , shall we use older interpretation for all bdb version as 
> vbt team cannot confirm bdb version for SKL?

I guess.

BR,
Jani.


>
>> Please tell anyone who asks, and also those who don't, that *all* of the
>> VBT changes should be based on the *version*, and *none* of them should
>> be based on the *platform*.
>>
>> BR,
>> Jani.
>>
>>>   		switch (psr_table->tp1_wakeup_time) {
>>>   		case 0:
>>>   			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;
>

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH] drm/i915/psr: Adds psrwake options for all platforms

[vathsala nagaraju]

From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>

Adds new psrwake options defined in the below table.
Platform	PSR wake options vbt version
KBL/CFL/WHL	All
SKL		All PV releases (Check for 203+ might help but cannot be foolproof)
BXT		Uses old interpretation.
CNL/ICL+	All
GLK		All

For SKL, we will continue to use older interpretation for the above reason.

v2: Jani
    Keep the bdb version check.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Puthikorn Voravootivat <puthik@chromium.org>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 465dff4..5517ca7 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
 	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
 	 * Old decimal value is wake up time in multiples of 100 us.
 	 */
-	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
+	if (bdb->version >= 209 && ((INTEL_GEN(dev_priv) >= 10) ||
+	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv)))) {
 		switch (psr_table->tp1_wakeup_time) {
 		case 0:
 			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Ville Syrjälä]

On Tue, Jun 12, 2018 at 10:49:09AM +0530, vathsala nagaraju wrote:
> From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> 
> Adds new psrwake options defined in the below table.
> Platform	PSR wake options vbt version
> KBL/CFL/WHL	All
> SKL		All PV releases (Check for 203+ might help but cannot be foolproof)
> BXT		Uses old interpretation.
> CNL/ICL+	All
> GLK		All
> 
> For SKL, we will continue to use older interpretation for the above reason.
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Puthikorn Voravootivat <puthik@chromium.org>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> 
> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 465dff4..010ff68 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
>  	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
>  	 * Old decimal value is wake up time in multiples of 100 us.
>  	 */
> -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
> +	if ((INTEL_GEN(dev_priv) >= 10) ||
> +	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv))) {

That doesn't match your commit message.

>  		switch (psr_table->tp1_wakeup_time) {
>  		case 0:
>  			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Dhinakaran Pandiyan]

On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
> On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@intel.co
> m> wrote:
> > 
> > On 6/12/2018 2:30 PM, Jani Nikula wrote:
> > > 
> > > On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@intel.c
> > > om> wrote:
> > > > 
> > > > From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> > > > 
> > > > Adds new psrwake options defined in the below table.
> > > > Platform	PSR wake options vbt version
> > > > KBL/CFL/WHL	All
> > > > SKL		All PV releases (Check for 203+ might help
> > > > but cannot be foolproof)
> > > > BXT		Uses old interpretation.
> > > > CNL/ICL+	All
> > > > GLK		All
> > > > 
> > > > For SKL, we will continue to use older interpretation for the
> > > > above reason.
> > > > 
> > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > Cc: Puthikorn Voravootivat <puthik@chromium.org>
> > > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > > 
> > > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> > > > ---
> > > >   drivers/gpu/drm/i915/intel_bios.c | 3 ++-
> > > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/intel_bios.c
> > > > b/drivers/gpu/drm/i915/intel_bios.c
> > > > index 465dff4..010ff68 100644
> > > > --- a/drivers/gpu/drm/i915/intel_bios.c
> > > > +++ b/drivers/gpu/drm/i915/intel_bios.c
> > > > @@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct
> > > > drm_i915_private *dev_priv,
> > > >   	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
> > > >   	 * Old decimal value is wake up time in multiples of
> > > > 100 us.
> > > >   	 */
> > > > -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
> > > > +	if ((INTEL_GEN(dev_priv) >= 10) ||
> > > > +	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv))) {
> > > Please keep the version check.
> > Sure. For SKL , shall we use older interpretation for all bdb
> > version as 
> > vbt team cannot confirm bdb version for SKL?
> I guess.
> 

Why not change the version check to >= 203, if that's what PV releases
had as per your commit message? With the current code, Linux and
Windows set 500 us and 2.5 ms respectively on my laptop.



> BR,
> Jani.
> 
> 
> > 
> > 
> > > 
> > > Please tell anyone who asks, and also those who don't, that *all*
> > > of the
> > > VBT changes should be based on the *version*, and *none* of them
> > > should
> > > be based on the *platform*.
> > > 
> > > BR,
> > > Jani.
> > > 
> > > > 
> > > >   		switch (psr_table->tp1_wakeup_time) {
> > > >   		case 0:
> > > >   			dev_priv->vbt.psr.tp1_wakeup_time_us
> > > > = 500;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Dhinakaran Pandiyan]

On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote:
> On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
> > 
> > On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@intel.
> > co
> > m> wrote:
> > > 
> > > 
> > > On 6/12/2018 2:30 PM, Jani Nikula wrote:
> > > > 
> > > > 
> > > > On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@intel
> > > > .c
> > > > om> wrote:
> > > > > 
> > > > > 
> > > > > From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> > > > > 
> > > > > Adds new psrwake options defined in the below table.
> > > > > Platform	PSR wake options vbt version
> > > > > KBL/CFL/WHL	All
> > > > > SKL		All PV releases (Check for 203+ might help
> > > > > but cannot be foolproof)
> > > > > BXT		Uses old interpretation.
> > > > > CNL/ICL+	All
> > > > > GLK		All
> > > > > 
> > > > > For SKL, we will continue to use older interpretation for the
> > > > > above reason.
> > > > > 
> > > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > > Cc: Puthikorn Voravootivat <puthik@chromium.org>
> > > > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > > > 
> > > > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com
> > > > > >
> > > > > ---
> > > > >   drivers/gpu/drm/i915/intel_bios.c | 3 ++-
> > > > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/drivers/gpu/drm/i915/intel_bios.c
> > > > > b/drivers/gpu/drm/i915/intel_bios.c
> > > > > index 465dff4..010ff68 100644
> > > > > --- a/drivers/gpu/drm/i915/intel_bios.c
> > > > > +++ b/drivers/gpu/drm/i915/intel_bios.c
> > > > > @@ -710,7 +710,8 @@ static int
> > > > > intel_bios_ssc_frequency(struct
> > > > > drm_i915_private *dev_priv,
> > > > >   	 * New psr options 0=500us, 1=100us, 2=2500us,
> > > > > 3=0us
> > > > >   	 * Old decimal value is wake up time in multiples
> > > > > of
> > > > > 100 us.
> > > > >   	 */
> > > > > -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
> > > > > +	if ((INTEL_GEN(dev_priv) >= 10) ||
> > > > > +	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv)))
> > > > > {
> > > > Please keep the version check.
> > > Sure. For SKL , shall we use older interpretation for all bdb
> > > version as 
> > > vbt team cannot confirm bdb version for SKL?
> > I guess.
> > 
> Why not change the version check to >= 203, if that's what PV
> releases
> had as per your commit message? With the current code, Linux and
> Windows set 500 us and 2.5 ms respectively on my laptop.
Said laptop is a SKL with bdb version 205.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Nagaraju, Vathsala]

On 6/13/2018 11:10 PM, Dhinakaran Pandiyan wrote:
> On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote:
>> On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
>>> On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@intel.
>>> co
>>> m> wrote:
>>>>
>>>> On 6/12/2018 2:30 PM, Jani Nikula wrote:
>>>>>
>>>>> On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@intel
>>>>> .c
>>>>> om> wrote:
>>>>>>
>>>>>> From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
>>>>>>
>>>>>> Adds new psrwake options defined in the below table.
>>>>>> Platform	PSR wake options vbt version
>>>>>> KBL/CFL/WHL	All
>>>>>> SKL		All PV releases (Check for 203+ might help
>>>>>> but cannot be foolproof)
>>>>>> BXT		Uses old interpretation.
>>>>>> CNL/ICL+	All
>>>>>> GLK		All
>>>>>>
>>>>>> For SKL, we will continue to use older interpretation for the
>>>>>> above reason.
>>>>>>
>>>>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>>>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>>>> Cc: Puthikorn Voravootivat <puthik@chromium.org>
>>>>>> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>>>>>>
>>>>>> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com
>>>>>> ---
>>>>>>    drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>>>>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/i915/intel_bios.c
>>>>>> b/drivers/gpu/drm/i915/intel_bios.c
>>>>>> index 465dff4..010ff68 100644
>>>>>> --- a/drivers/gpu/drm/i915/intel_bios.c
>>>>>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>>>>>> @@ -710,7 +710,8 @@ static int
>>>>>> intel_bios_ssc_frequency(struct
>>>>>> drm_i915_private *dev_priv,
>>>>>>    	 * New psr options 0=500us, 1=100us, 2=2500us,
>>>>>> 3=0us
>>>>>>    	 * Old decimal value is wake up time in multiples
>>>>>> of
>>>>>> 100 us.
>>>>>>    	 */
>>>>>> -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
>>>>>> +	if ((INTEL_GEN(dev_priv) >= 10) ||
>>>>>> +	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv)))
>>>>>> {
>>>>> Please keep the version check.
>>>> Sure. For SKL , shall we use older interpretation for all bdb
>>>> version as
>>>> vbt team cannot confirm bdb version for SKL?
>>> I guess.
>>>
>> Why not change the version check to >= 203, if that's what PV
>> releases
>> had as per your commit message? With the current code, Linux and
>> Windows set 500 us and 2.5 ms respectively on my laptop.
> Said laptop is a SKL with bdb version 205.
+ ashutosh(VBT team)
Since VBT team cannot confirm version for SKL ,so skipped for skylake.
I did a copy paste of the table provided by vbt team, will edit for skylake.


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Nagaraju, Vathsala]

On 6/13/2018 11:10 PM, Dhinakaran Pandiyan wrote:
> On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote:
>> On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
>>> On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@intel.
>>> co
>>> m> wrote:
>>>>
>>>> On 6/12/2018 2:30 PM, Jani Nikula wrote:
>>>>>
>>>>> On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@intel
>>>>> .c
>>>>> om> wrote:
>>>>>>
>>>>>> From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
>>>>>>
>>>>>> Adds new psrwake options defined in the below table.
>>>>>> Platform	PSR wake options vbt version
>>>>>> KBL/CFL/WHL	All
>>>>>> SKL		All PV releases (Check for 203+ might help
>>>>>> but cannot be foolproof)
>>>>>> BXT		Uses old interpretation.
>>>>>> CNL/ICL+	All
>>>>>> GLK		All
>>>>>>
>>>>>> For SKL, we will continue to use older interpretation for the
>>>>>> above reason.
>>>>>>
>>>>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>>>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>>>> Cc: Puthikorn Voravootivat <puthik@chromium.org>
>>>>>> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>>>>>>
>>>>>> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com
>>>>>> ---
>>>>>>    drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>>>>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/i915/intel_bios.c
>>>>>> b/drivers/gpu/drm/i915/intel_bios.c
>>>>>> index 465dff4..010ff68 100644
>>>>>> --- a/drivers/gpu/drm/i915/intel_bios.c
>>>>>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>>>>>> @@ -710,7 +710,8 @@ static int
>>>>>> intel_bios_ssc_frequency(struct
>>>>>> drm_i915_private *dev_priv,
>>>>>>    	 * New psr options 0=500us, 1=100us, 2=2500us,
>>>>>> 3=0us
>>>>>>    	 * Old decimal value is wake up time in multiples
>>>>>> of
>>>>>> 100 us.
>>>>>>    	 */
>>>>>> -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
>>>>>> +	if ((INTEL_GEN(dev_priv) >= 10) ||
>>>>>> +	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv)))
>>>>>> {
>>>>> Please keep the version check.
>>>> Sure. For SKL , shall we use older interpretation for all bdb
>>>> version as
>>>> vbt team cannot confirm bdb version for SKL?
>>> I guess.
>>>
>> Why not change the version check to >= 203, if that's what PV
>> releases
>> had as per your commit message? With the current code, Linux and
>> Windows set 500 us and 2.5 ms respectively on my laptop.
> Said laptop is a SKL with bdb version 205.
+ ashutosh(VBT team)
Since VBT team cannot confirm version for SKL ,so skipped for skylake.
I did a copy paste of the table provided by vbt team, will edit for skylake

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Nagaraju, Vathsala]

On 6/13/2018 11:10 PM, Dhinakaran Pandiyan wrote:
> On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote:
>> On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
>>> On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@intel.
>>> co
>>> m> wrote:
>>>>
>>>> On 6/12/2018 2:30 PM, Jani Nikula wrote:
>>>>>
>>>>> On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@intel
>>>>> .c
>>>>> om> wrote:
>>>>>>
>>>>>> From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
>>>>>>
>>>>>> Adds new psrwake options defined in the below table.
>>>>>> Platform	PSR wake options vbt version
>>>>>> KBL/CFL/WHL	All
>>>>>> SKL		All PV releases (Check for 203+ might help
>>>>>> but cannot be foolproof)
>>>>>> BXT		Uses old interpretation.
>>>>>> CNL/ICL+	All
>>>>>> GLK		All
>>>>>>
>>>>>> For SKL, we will continue to use older interpretation for the
>>>>>> above reason.
>>>>>>
>>>>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>>>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>>>> Cc: Puthikorn Voravootivat <puthik@chromium.org>
>>>>>> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>>>>>>
>>>>>> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com
>>>>>> ---
>>>>>>    drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>>>>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/i915/intel_bios.c
>>>>>> b/drivers/gpu/drm/i915/intel_bios.c
>>>>>> index 465dff4..010ff68 100644
>>>>>> --- a/drivers/gpu/drm/i915/intel_bios.c
>>>>>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>>>>>> @@ -710,7 +710,8 @@ static int
>>>>>> intel_bios_ssc_frequency(struct
>>>>>> drm_i915_private *dev_priv,
>>>>>>    	 * New psr options 0=500us, 1=100us, 2=2500us,
>>>>>> 3=0us
>>>>>>    	 * Old decimal value is wake up time in multiples
>>>>>> of
>>>>>> 100 us.
>>>>>>    	 */
>>>>>> -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
>>>>>> +	if ((INTEL_GEN(dev_priv) >= 10) ||
>>>>>> +	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv)))
>>>>>> {
>>>>> Please keep the version check.
>>>> Sure. For SKL , shall we use older interpretation for all bdb
>>>> version as
>>>> vbt team cannot confirm bdb version for SKL?
>>> I guess.
>>>
>> Why not change the version check to >= 203, if that's what PV
>> releases
>> had as per your commit message? With the current code, Linux and
>> Windows set 500 us and 2.5 ms respectively on my laptop.
> Said laptop is a SKL with bdb version 205.
I did a copy paste of the table provided by vbt team, will edit for skylake
Since VBT team cannot confirm version for SKL ,so skipping for skylake.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Pandiyan, Dhinakaran]

On Thu, 2018-06-14 at 11:59 +0530, Nagaraju, Vathsala wrote:
> 
> On 6/13/2018 11:10 PM, Dhinakaran Pandiyan wrote:
> > 
> > On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote:
> > > 
> > > On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
> > > > 
> > > > On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@in
> > > > tel.
> > > > co
> > > > m> wrote:
> > > > > 
> > > > > 
> > > > > On 6/12/2018 2:30 PM, Jani Nikula wrote:
> > > > > > 
> > > > > > 
> > > > > > On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@i
> > > > > > ntel
> > > > > > .c
> > > > > > om> wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> > > > > > > 
> > > > > > > Adds new psrwake options defined in the below table.
> > > > > > > Platform	PSR wake options vbt version
> > > > > > > KBL/CFL/WHL	All
> > > > > > > SKL		All PV releases (Check for 203+ might
> > > > > > > help
> > > > > > > but cannot be foolproof)
> > > > > > > BXT		Uses old interpretation.
> > > > > > > CNL/ICL+	All
> > > > > > > GLK		All
> > > > > > > 
> > > > > > > For SKL, we will continue to use older interpretation for
> > > > > > > the
> > > > > > > above reason.
> > > > > > > 
> > > > > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > > > > Cc: Puthikorn Voravootivat <puthik@chromium.org>
> > > > > > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > > > > > 
> > > > > > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel
> > > > > > > .com
> > > > > > > ---
> > > > > > >    drivers/gpu/drm/i915/intel_bios.c | 3 ++-
> > > > > > >    1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > > > 
> > > > > > > diff --git a/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > b/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > index 465dff4..010ff68 100644
> > > > > > > --- a/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > +++ b/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > @@ -710,7 +710,8 @@ static int
> > > > > > > intel_bios_ssc_frequency(struct
> > > > > > > drm_i915_private *dev_priv,
> > > > > > >    	 * New psr options 0=500us, 1=100us, 2=2500us,
> > > > > > > 3=0us
> > > > > > >    	 * Old decimal value is wake up time in
> > > > > > > multiples
> > > > > > > of
> > > > > > > 100 us.
> > > > > > >    	 */
> > > > > > > -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv))
> > > > > > > {
> > > > > > > +	if ((INTEL_GEN(dev_priv) >= 10) ||
> > > > > > > +	    (IS_GEN9_BC(dev_priv) &&
> > > > > > > !IS_SKYLAKE(dev_priv)))
> > > > > > > {
> > > > > > Please keep the version check.
> > > > > Sure. For SKL , shall we use older interpretation for all bdb
> > > > > version as
> > > > > vbt team cannot confirm bdb version for SKL?
> > > > I guess.
> > > > 
> > > Why not change the version check to >= 203, if that's what PV
> > > releases
> > > had as per your commit message? With the current code, Linux and
> > > Windows set 500 us and 2.5 ms respectively on my laptop.
> > Said laptop is a SKL with bdb version 205.
> + ashutosh(VBT team)
> Since VBT team cannot confirm version for SKL ,so skipped for
> skylake.
> I did a copy paste of the table provided by vbt team, will edit for
> skylake.
> 
We are not going to get this right for all combinations, the best we
can do is make sure things work in most cases. I prefer to err on the
side of using the new mapping because when translated incorrectly, 3
out of 4 values lead to >= intended training time. Given the fact that
SKL PV releases also used the new mapping, I suggest you do this

if ((bdb->version >= 203 && IS_GEN9_BC(dev_priv)) ||
IS_GEMINILAKE(dev_priv) ||  INTEL_GEN(dev_priv) >= 10) {
/* new mapping */

}

I don't know what the basis for the current check for version 209 is,
other than it was the version on the KBL you tested.

-DK





_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Rodrigo Vivi]

On Thu, Jun 14, 2018 at 09:00:15AM -0700, Pandiyan, Dhinakaran wrote:
> On Thu, 2018-06-14 at 11:59 +0530, Nagaraju, Vathsala wrote:
> > 
> > On 6/13/2018 11:10 PM, Dhinakaran Pandiyan wrote:
> > > 
> > > On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote:
> > > > 
> > > > On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
> > > > > 
> > > > > On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@in
> > > > > tel.
> > > > > co
> > > > > m> wrote:
> > > > > > 
> > > > > > 
> > > > > > On 6/12/2018 2:30 PM, Jani Nikula wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@i
> > > > > > > ntel
> > > > > > > .c
> > > > > > > om> wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> > > > > > > > 
> > > > > > > > Adds new psrwake options defined in the below table.
> > > > > > > > Platform	PSR wake options vbt version
> > > > > > > > KBL/CFL/WHL	All
> > > > > > > > SKL		All PV releases (Check for 203+ might
> > > > > > > > help
> > > > > > > > but cannot be foolproof)
> > > > > > > > BXT		Uses old interpretation.
> > > > > > > > CNL/ICL+	All
> > > > > > > > GLK		All
> > > > > > > > 
> > > > > > > > For SKL, we will continue to use older interpretation for
> > > > > > > > the
> > > > > > > > above reason.
> > > > > > > > 
> > > > > > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > > > > > Cc: Puthikorn Voravootivat <puthik@chromium.org>
> > > > > > > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > > > > > > 
> > > > > > > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel
> > > > > > > > .com
> > > > > > > > ---
> > > > > > > >    drivers/gpu/drm/i915/intel_bios.c | 3 ++-
> > > > > > > >    1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > > > > 
> > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > b/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > index 465dff4..010ff68 100644
> > > > > > > > --- a/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > +++ b/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > @@ -710,7 +710,8 @@ static int
> > > > > > > > intel_bios_ssc_frequency(struct
> > > > > > > > drm_i915_private *dev_priv,
> > > > > > > >    	 * New psr options 0=500us, 1=100us, 2=2500us,
> > > > > > > > 3=0us
> > > > > > > >    	 * Old decimal value is wake up time in
> > > > > > > > multiples
> > > > > > > > of
> > > > > > > > 100 us.
> > > > > > > >    	 */
> > > > > > > > -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv))
> > > > > > > > {
> > > > > > > > +	if ((INTEL_GEN(dev_priv) >= 10) ||
> > > > > > > > +	    (IS_GEN9_BC(dev_priv) &&
> > > > > > > > !IS_SKYLAKE(dev_priv)))
> > > > > > > > {
> > > > > > > Please keep the version check.
> > > > > > Sure. For SKL , shall we use older interpretation for all bdb
> > > > > > version as
> > > > > > vbt team cannot confirm bdb version for SKL?
> > > > > I guess.
> > > > > 
> > > > Why not change the version check to >= 203, if that's what PV
> > > > releases
> > > > had as per your commit message? With the current code, Linux and
> > > > Windows set 500 us and 2.5 ms respectively on my laptop.
> > > Said laptop is a SKL with bdb version 205.
> > + ashutosh(VBT team)
> > Since VBT team cannot confirm version for SKL ,so skipped for
> > skylake.
> > I did a copy paste of the table provided by vbt team, will edit for
> > skylake.
> > 
> We are not going to get this right for all combinations,

:(
it seems we have to live with it

> the best we
> can do is make sure things work in most cases.

I agree.

> I prefer to err on the
> side of using the new mapping because when translated incorrectly, 3
> out of 4 values lead to >= intended training time. Given the fact that
> SKL PV releases also used the new mapping, I suggest you do this
> 
> if ((bdb->version >= 203 && IS_GEN9_BC(dev_priv)) ||
> IS_GEMINILAKE(dev_priv) ||  INTEL_GEN(dev_priv) >= 10) {

+1

> /* new mapping */
> 
> }
> 
> I don't know what the basis for the current check for version 209 is,
> other than it was the version on the KBL you tested.
> 
> -DK
> 
> 
> 
> 
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Nagaraju, Vathsala]

+ Ashutosh(VBT team)   + maulik

209 is confirmed version on kbl both by vbt team (Maulik) and google, so we had used it.

DK's suggestion is 
if ((bdb->version >= 203 && IS_GEN9_BC(dev_priv)) ||
IS_GEMINILAKE(dev_priv) ||  INTEL_GEN(dev_priv) >= 10) {
/* new mapping */

As per Ashutosh, 203 Is not the right version, 205 is fine , but user can still provide decimal value for SKL.
Jani/Rodrigo, should we use 205 for SKL or  drop SKL from the new mapping?

-----Original Message-----
From: Pandiyan, Dhinakaran 
Sent: Thursday, June 14, 2018 9:30 PM
To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Nikula, Jani <jani.nikula@intel.com>; Nagaraju, Vathsala <vathsala.nagaraju@intel.com>
Cc: puthik@chromium.org; intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

On Thu, 2018-06-14 at 11:59 +0530, Nagaraju, Vathsala wrote:
> 
> On 6/13/2018 11:10 PM, Dhinakaran Pandiyan wrote:
> > 
> > On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote:
> > > 
> > > On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
> > > > 
> > > > On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@in 
> > > > tel.
> > > > co
> > > > m> wrote:
> > > > > 
> > > > > 
> > > > > On 6/12/2018 2:30 PM, Jani Nikula wrote:
> > > > > > 
> > > > > > 
> > > > > > On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@i 
> > > > > > ntel .c
> > > > > > om> wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> > > > > > > 
> > > > > > > Adds new psrwake options defined in the below table.
> > > > > > > Platform	PSR wake options vbt version
> > > > > > > KBL/CFL/WHL	All
> > > > > > > SKL		All PV releases (Check for 203+ might
> > > > > > > help
> > > > > > > but cannot be foolproof)
> > > > > > > BXT		Uses old interpretation.
> > > > > > > CNL/ICL+	All
> > > > > > > GLK		All
> > > > > > > 
> > > > > > > For SKL, we will continue to use older interpretation for 
> > > > > > > the above reason.
> > > > > > > 
> > > > > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > > > > Cc: Puthikorn Voravootivat <puthik@chromium.org>
> > > > > > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > > > > > 
> > > > > > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel 
> > > > > > > .com
> > > > > > > ---
> > > > > > >    drivers/gpu/drm/i915/intel_bios.c | 3 ++-
> > > > > > >    1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > > > 
> > > > > > > diff --git a/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > b/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > index 465dff4..010ff68 100644
> > > > > > > --- a/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > +++ b/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > @@ -710,7 +710,8 @@ static int 
> > > > > > > intel_bios_ssc_frequency(struct drm_i915_private 
> > > > > > > *dev_priv,
> > > > > > >    	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
> > > > > > >    	 * Old decimal value is wake up time in multiples of
> > > > > > > 100 us.
> > > > > > >    	 */
> > > > > > > -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv))
> > > > > > > {
> > > > > > > +	if ((INTEL_GEN(dev_priv) >= 10) ||
> > > > > > > +	    (IS_GEN9_BC(dev_priv) &&
> > > > > > > !IS_SKYLAKE(dev_priv)))
> > > > > > > {
> > > > > > Please keep the version check.
> > > > > Sure. For SKL , shall we use older interpretation for all bdb 
> > > > > version as vbt team cannot confirm bdb version for SKL?
> > > > I guess.
> > > > 
> > > Why not change the version check to >= 203, if that's what PV
> > > releases
> > > had as per your commit message? With the current code, Linux and
> > > Windows set 500 us and 2.5 ms respectively on my laptop.
> > Said laptop is a SKL with bdb version 205.
> + ashutosh(VBT team)
> Since VBT team cannot confirm version for SKL ,so skipped for
> skylake.
> I did a copy paste of the table provided by vbt team, will edit for
> skylake.
> 
We are not going to get this right for all combinations, the best we
can do is make sure things work in most cases. I prefer to err on the
side of using the new mapping because when translated incorrectly, 3
out of 4 values lead to >= intended training time. Given the fact that
SKL PV releases also used the new mapping, I suggest you do this

if ((bdb->version >= 203 && IS_GEN9_BC(dev_priv)) ||
IS_GEMINILAKE(dev_priv) ||  INTEL_GEN(dev_priv) >= 10) {
/* new mapping */

}

I don't know what the basis for the current check for version 209 is,
other than it was the version on the KBL you tested.

-DK





_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Dhinakaran Pandiyan]

On Thu, 2018-06-14 at 16:56 +0000, Nagaraju, Vathsala wrote:
> + Ashutosh(VBT team)   + maulik
> 
> 209 is confirmed version on kbl both by vbt team (Maulik) and google,
> so we had used it.
> 
> DK's suggestion is 
> if ((bdb->version >= 203 && IS_GEN9_BC(dev_priv)) ||
> IS_GEMINILAKE(dev_priv) ||  INTEL_GEN(dev_priv) >= 10) {
> /* new mapping */
> 
> As per Ashutosh, 203 Is not the right version, 205 is fine , but user
> can still provide decimal value for SKL.
 
I am confused, why does the commit message mention 203 then?


> Jani/Rodrigo, should we use 205 for SKL or  drop SKL from the new
> mapping?
> 
> -----Original Message-----
> From: Pandiyan, Dhinakaran 
> Sent: Thursday, June 14, 2018 9:30 PM
> To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Nikula, Jani <jani.nikula
> @intel.com>; Nagaraju, Vathsala <vathsala.nagaraju@intel.com>
> Cc: puthik@chromium.org; intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/i915/psr: Adds psrwake options for all
> platforms
> 
> On Thu, 2018-06-14 at 11:59 +0530, Nagaraju, Vathsala wrote:
> > 
> > 
> > On 6/13/2018 11:10 PM, Dhinakaran Pandiyan wrote:
> > > 
> > > 
> > > On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote:
> > > > 
> > > > 
> > > > On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
> > > > > 
> > > > > 
> > > > > On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@
> > > > > in 
> > > > > tel.
> > > > > co
> > > > > m> wrote:
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > On 6/12/2018 2:30 PM, Jani Nikula wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju
> > > > > > > @i 
> > > > > > > ntel .c
> > > > > > > om> wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> > > > > > > > 
> > > > > > > > Adds new psrwake options defined in the below table.
> > > > > > > > Platform	PSR wake options vbt version
> > > > > > > > KBL/CFL/WHL	All
> > > > > > > > SKL		All PV releases (Check for 203+
> > > > > > > > might
> > > > > > > > help
> > > > > > > > but cannot be foolproof)
> > > > > > > > BXT		Uses old interpretation.
> > > > > > > > CNL/ICL+	All
> > > > > > > > GLK		All
> > > > > > > > 
> > > > > > > > For SKL, we will continue to use older interpretation
> > > > > > > > for 
> > > > > > > > the above reason.
> > > > > > > > 
> > > > > > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > > > > > Cc: Puthikorn Voravootivat <puthik@chromium.org>
> > > > > > > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > > > > > > 
> > > > > > > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@int
> > > > > > > > el 
> > > > > > > > .com
> > > > > > > > ---
> > > > > > > >    drivers/gpu/drm/i915/intel_bios.c | 3 ++-
> > > > > > > >    1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > > > > 
> > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > b/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > index 465dff4..010ff68 100644
> > > > > > > > --- a/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > +++ b/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > @@ -710,7 +710,8 @@ static int 
> > > > > > > > intel_bios_ssc_frequency(struct drm_i915_private 
> > > > > > > > *dev_priv,
> > > > > > > >    	 * New psr options 0=500us, 1=100us,
> > > > > > > > 2=2500us, 3=0us
> > > > > > > >    	 * Old decimal value is wake up time in
> > > > > > > > multiples of
> > > > > > > > 100 us.
> > > > > > > >    	 */
> > > > > > > > -	if (bdb->version >= 209 &&
> > > > > > > > IS_GEN9_BC(dev_priv))
> > > > > > > > {
> > > > > > > > +	if ((INTEL_GEN(dev_priv) >= 10) ||
> > > > > > > > +	    (IS_GEN9_BC(dev_priv) &&
> > > > > > > > !IS_SKYLAKE(dev_priv)))
> > > > > > > > {
> > > > > > > Please keep the version check.
> > > > > > Sure. For SKL , shall we use older interpretation for all
> > > > > > bdb 
> > > > > > version as vbt team cannot confirm bdb version for SKL?
> > > > > I guess.
> > > > > 
> > > > Why not change the version check to >= 203, if that's what PV
> > > > releases
> > > > had as per your commit message? With the current code, Linux
> > > > and
> > > > Windows set 500 us and 2.5 ms respectively on my laptop.
> > > Said laptop is a SKL with bdb version 205.
> > + ashutosh(VBT team)
> > Since VBT team cannot confirm version for SKL ,so skipped for
> > skylake.
> > I did a copy paste of the table provided by vbt team, will edit for
> > skylake.
> > 
> We are not going to get this right for all combinations, the best we
> can do is make sure things work in most cases. I prefer to err on the
> side of using the new mapping because when translated incorrectly, 3
> out of 4 values lead to >= intended training time. Given the fact
> that
> SKL PV releases also used the new mapping, I suggest you do this
> 
> if ((bdb->version >= 203 && IS_GEN9_BC(dev_priv)) ||
> IS_GEMINILAKE(dev_priv) ||  INTEL_GEN(dev_priv) >= 10) {
> /* new mapping */
> 
> }
> 
> I don't know what the basis for the current check for version 209 is,
> other than it was the version on the KBL you tested.
> 
> -DK
> 
> 
> 
> 
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Jani Nikula]

On Thu, 14 Jun 2018, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> wrote:
> On Thu, 2018-06-14 at 16:56 +0000, Nagaraju, Vathsala wrote:
>> + Ashutosh(VBT team)   + maulik
>> 
>> 209 is confirmed version on kbl both by vbt team (Maulik) and google,
>> so we had used it.
>> 
>> DK's suggestion is 
>> if ((bdb->version >= 203 && IS_GEN9_BC(dev_priv)) ||
>> IS_GEMINILAKE(dev_priv) ||  INTEL_GEN(dev_priv) >= 10) {
>> /* new mapping */
>> 
>> As per Ashutosh, 203 Is not the right version, 205 is fine , but user
>> can still provide decimal value for SKL.
>  
> I am confused, why does the commit message mention 203 then?

Whatever the version, I want that to be required always. i.e.

	if (version >= N && (bunch of other conditions))

*not*

	if (version >= N || (bunch of other conditions))

BR,
Jani.

>
>
>> Jani/Rodrigo, should we use 205 for SKL or  drop SKL from the new
>> mapping?
>> 
>> -----Original Message-----
>> From: Pandiyan, Dhinakaran 
>> Sent: Thursday, June 14, 2018 9:30 PM
>> To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Nikula, Jani <jani.nikula
>> @intel.com>; Nagaraju, Vathsala <vathsala.nagaraju@intel.com>
>> Cc: puthik@chromium.org; intel-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH] drm/i915/psr: Adds psrwake options for all
>> platforms
>> 
>> On Thu, 2018-06-14 at 11:59 +0530, Nagaraju, Vathsala wrote:
>> > 
>> > 
>> > On 6/13/2018 11:10 PM, Dhinakaran Pandiyan wrote:
>> > > 
>> > > 
>> > > On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote:
>> > > > 
>> > > > 
>> > > > On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
>> > > > > 
>> > > > > 
>> > > > > On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@
>> > > > > in 
>> > > > > tel.
>> > > > > co
>> > > > > m> wrote:
>> > > > > > 
>> > > > > > 
>> > > > > > 
>> > > > > > On 6/12/2018 2:30 PM, Jani Nikula wrote:
>> > > > > > > 
>> > > > > > > 
>> > > > > > > 
>> > > > > > > On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju
>> > > > > > > @i 
>> > > > > > > ntel .c
>> > > > > > > om> wrote:
>> > > > > > > > 
>> > > > > > > > 
>> > > > > > > > 
>> > > > > > > > From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
>> > > > > > > > 
>> > > > > > > > Adds new psrwake options defined in the below table.
>> > > > > > > > Platform	PSR wake options vbt version
>> > > > > > > > KBL/CFL/WHL	All
>> > > > > > > > SKL		All PV releases (Check for 203+
>> > > > > > > > might
>> > > > > > > > help
>> > > > > > > > but cannot be foolproof)
>> > > > > > > > BXT		Uses old interpretation.
>> > > > > > > > CNL/ICL+	All
>> > > > > > > > GLK		All
>> > > > > > > > 
>> > > > > > > > For SKL, we will continue to use older interpretation
>> > > > > > > > for 
>> > > > > > > > the above reason.
>> > > > > > > > 
>> > > > > > > > Cc: Jani Nikula <jani.nikula@intel.com>
>> > > > > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> > > > > > > > Cc: Puthikorn Voravootivat <puthik@chromium.org>
>> > > > > > > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>> > > > > > > > 
>> > > > > > > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@int
>> > > > > > > > el 
>> > > > > > > > .com
>> > > > > > > > ---
>> > > > > > > >    drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>> > > > > > > >    1 file changed, 2 insertions(+), 1 deletion(-)
>> > > > > > > > 
>> > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_bios.c
>> > > > > > > > b/drivers/gpu/drm/i915/intel_bios.c
>> > > > > > > > index 465dff4..010ff68 100644
>> > > > > > > > --- a/drivers/gpu/drm/i915/intel_bios.c
>> > > > > > > > +++ b/drivers/gpu/drm/i915/intel_bios.c
>> > > > > > > > @@ -710,7 +710,8 @@ static int 
>> > > > > > > > intel_bios_ssc_frequency(struct drm_i915_private 
>> > > > > > > > *dev_priv,
>> > > > > > > >    	 * New psr options 0=500us, 1=100us,
>> > > > > > > > 2=2500us, 3=0us
>> > > > > > > >    	 * Old decimal value is wake up time in
>> > > > > > > > multiples of
>> > > > > > > > 100 us.
>> > > > > > > >    	 */
>> > > > > > > > -	if (bdb->version >= 209 &&
>> > > > > > > > IS_GEN9_BC(dev_priv))
>> > > > > > > > {
>> > > > > > > > +	if ((INTEL_GEN(dev_priv) >= 10) ||
>> > > > > > > > +	    (IS_GEN9_BC(dev_priv) &&
>> > > > > > > > !IS_SKYLAKE(dev_priv)))
>> > > > > > > > {
>> > > > > > > Please keep the version check.
>> > > > > > Sure. For SKL , shall we use older interpretation for all
>> > > > > > bdb 
>> > > > > > version as vbt team cannot confirm bdb version for SKL?
>> > > > > I guess.
>> > > > > 
>> > > > Why not change the version check to >= 203, if that's what PV
>> > > > releases
>> > > > had as per your commit message? With the current code, Linux
>> > > > and
>> > > > Windows set 500 us and 2.5 ms respectively on my laptop.
>> > > Said laptop is a SKL with bdb version 205.
>> > + ashutosh(VBT team)
>> > Since VBT team cannot confirm version for SKL ,so skipped for
>> > skylake.
>> > I did a copy paste of the table provided by vbt team, will edit for
>> > skylake.
>> > 
>> We are not going to get this right for all combinations, the best we
>> can do is make sure things work in most cases. I prefer to err on the
>> side of using the new mapping because when translated incorrectly, 3
>> out of 4 values lead to >= intended training time. Given the fact
>> that
>> SKL PV releases also used the new mapping, I suggest you do this
>> 
>> if ((bdb->version >= 203 && IS_GEN9_BC(dev_priv)) ||
>> IS_GEMINILAKE(dev_priv) ||  INTEL_GEN(dev_priv) >= 10) {
>> /* new mapping */
>> 
>> }
>> 
>> I don't know what the basis for the current check for version 209 is,
>> other than it was the version on the KBL you tested.
>> 
>> -DK
>> 
>> 
>> 
>> 
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Dhinakaran Pandiyan]

On Fri, 2018-06-15 at 11:10 +0300, Jani Nikula wrote:
> On Thu, 14 Jun 2018, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.c
> om> wrote:
> > 
> > On Thu, 2018-06-14 at 16:56 +0000, Nagaraju, Vathsala wrote:
> > > 
> > > + Ashutosh(VBT team)   + maulik
> > > 
> > > 209 is confirmed version on kbl both by vbt team (Maulik) and
> > > google,
> > > so we had used it.
> > > 
> > > DK's suggestion is 
> > > if ((bdb->version >= 203 && IS_GEN9_BC(dev_priv)) ||
> > > IS_GEMINILAKE(dev_priv) ||  INTEL_GEN(dev_priv) >= 10) {
> > > /* new mapping */
> > > 
> > > As per Ashutosh, 203 Is not the right version, 205 is fine , but
> > > user
> > > can still provide decimal value for SKL.
> >  
> > I am confused, why does the commit message mention 203 then?
> Whatever the version, I want that to be required always. i.e.
> 
> 	if (version >= N && (bunch of other conditions))

Using the version number as a guard makes sense but this means we need
a version number that's applicable to all platforms.

Vathsala,
Can you please confirm if all platforms that you want to use the new
mapping for have version numbers >= 205?

If that's the case, it should be easy to change the check to

if (version >= 205 && (IS_GEN9_BC() || IS_GEMINILAKE() || INTEL_GEN()
>= 10))


> 
> *not*
> 
> 	if (version >= N || (bunch of other conditions))
> 
> BR,
> Jani.
> 
> > 
> > 
> > 
> > > 
> > > Jani/Rodrigo, should we use 205 for SKL or  drop SKL from the new
> > > mapping?
> > > 
> > > -----Original Message-----
> > > From: Pandiyan, Dhinakaran 
> > > Sent: Thursday, June 14, 2018 9:30 PM
> > > To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Nikula, Jani
> > > <jani.nikula
> > > @intel.com>; Nagaraju, Vathsala <vathsala.nagaraju@intel.com>
> > > Cc: puthik@chromium.org; intel-gfx@lists.freedesktop.org
> > > Subject: Re: [PATCH] drm/i915/psr: Adds psrwake options for all
> > > platforms
> > > 
> > > On Thu, 2018-06-14 at 11:59 +0530, Nagaraju, Vathsala wrote:
> > > > 
> > > > 
> > > > 
> > > > On 6/13/2018 11:10 PM, Dhinakaran Pandiyan wrote:
> > > > > 
> > > > > 
> > > > > 
> > > > > On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote:
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > On Wed, 13 Jun 2018, "Nagaraju, Vathsala"
> > > > > > > <vathsala.nagaraju@
> > > > > > > in 
> > > > > > > tel.
> > > > > > > co
> > > > > > > m> wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > On 6/12/2018 2:30 PM, Jani Nikula wrote:
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > On Tue, 12 Jun 2018, vathsala nagaraju
> > > > > > > > > <vathsala.nagaraju
> > > > > > > > > @i 
> > > > > > > > > ntel .c
> > > > > > > > > om> wrote:
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > From: Vathsala Nagaraju <vathsala.nagaraju@intel.co
> > > > > > > > > > m>
> > > > > > > > > > 
> > > > > > > > > > Adds new psrwake options defined in the below
> > > > > > > > > > table.
> > > > > > > > > > Platform	PSR wake options vbt version
> > > > > > > > > > KBL/CFL/WHL	All
> > > > > > > > > > SKL		All PV releases (Check for 203+
> > > > > > > > > > might
> > > > > > > > > > help
> > > > > > > > > > but cannot be foolproof)
> > > > > > > > > > BXT		Uses old interpretation.
> > > > > > > > > > CNL/ICL+	All
> > > > > > > > > > GLK		All
> > > > > > > > > > 
> > > > > > > > > > For SKL, we will continue to use older
> > > > > > > > > > interpretation
> > > > > > > > > > for 
> > > > > > > > > > the above reason.
> > > > > > > > > > 
> > > > > > > > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > > > > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > > > > > > > Cc: Puthikorn Voravootivat <puthik@chromium.org>
> > > > > > > > > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.
> > > > > > > > > > com>
> > > > > > > > > > 
> > > > > > > > > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju
> > > > > > > > > > @int
> > > > > > > > > > el 
> > > > > > > > > > .com
> > > > > > > > > > ---
> > > > > > > > > >    drivers/gpu/drm/i915/intel_bios.c | 3 ++-
> > > > > > > > > >    1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > > > > > > 
> > > > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > > > b/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > > > index 465dff4..010ff68 100644
> > > > > > > > > > --- a/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > > > +++ b/drivers/gpu/drm/i915/intel_bios.c
> > > > > > > > > > @@ -710,7 +710,8 @@ static int 
> > > > > > > > > > intel_bios_ssc_frequency(struct drm_i915_private 
> > > > > > > > > > *dev_priv,
> > > > > > > > > >    	 * New psr options 0=500us, 1=100us,
> > > > > > > > > > 2=2500us, 3=0us
> > > > > > > > > >    	 * Old decimal value is wake up time in
> > > > > > > > > > multiples of
> > > > > > > > > > 100 us.
> > > > > > > > > >    	 */
> > > > > > > > > > -	if (bdb->version >= 209 &&
> > > > > > > > > > IS_GEN9_BC(dev_priv))
> > > > > > > > > > {
> > > > > > > > > > +	if ((INTEL_GEN(dev_priv) >= 10) ||
> > > > > > > > > > +	    (IS_GEN9_BC(dev_priv) &&
> > > > > > > > > > !IS_SKYLAKE(dev_priv)))
> > > > > > > > > > {
> > > > > > > > > Please keep the version check.
> > > > > > > > Sure. For SKL , shall we use older interpretation for
> > > > > > > > all
> > > > > > > > bdb 
> > > > > > > > version as vbt team cannot confirm bdb version for SKL?
> > > > > > > I guess.
> > > > > > > 
> > > > > > Why not change the version check to >= 203, if that's what
> > > > > > PV
> > > > > > releases
> > > > > > had as per your commit message? With the current code,
> > > > > > Linux
> > > > > > and
> > > > > > Windows set 500 us and 2.5 ms respectively on my laptop.
> > > > > Said laptop is a SKL with bdb version 205.
> > > > + ashutosh(VBT team)
> > > > Since VBT team cannot confirm version for SKL ,so skipped for
> > > > skylake.
> > > > I did a copy paste of the table provided by vbt team, will edit
> > > > for
> > > > skylake.
> > > > 
> > > We are not going to get this right for all combinations, the best
> > > we
> > > can do is make sure things work in most cases. I prefer to err on
> > > the
> > > side of using the new mapping because when translated
> > > incorrectly, 3
> > > out of 4 values lead to >= intended training time. Given the fact
> > > that
> > > SKL PV releases also used the new mapping, I suggest you do this
> > > 
> > > if ((bdb->version >= 203 && IS_GEN9_BC(dev_priv)) ||
> > > IS_GEMINILAKE(dev_priv) ||  INTEL_GEN(dev_priv) >= 10) {
> > > /* new mapping */
> > > 
> > > }
> > > 
> > > I don't know what the basis for the current check for version 209
> > > is,
> > > other than it was the version on the KBL you tested.
> > > 
> > > -DK
> > > 
> > > 
> > > 
> > > 
> > > 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH] drm/i915/psr: Adds psrwake options for all platforms

[vathsala nagaraju]

From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>

Adds new psrwake options defined in the below table.
Platform	PSR wake options vbt version
KBL/CFL/WHL	All(205+)
BXT		Uses old interpretation.
CNL/ICL+	All(205+)
GLK		All(205+)
SKL		All PV releases (Check for 205+ might help but cannot be foolproof)

We will continue with newer interpretation for SKL from 205.

v2: Jani
    Keep the bdb version check.
v3:
    Apply newer version for skl from 205+(DK).
    Add (version check && platform list) (Jani).
    Add bdb version for each platform in commit message(DK).

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Puthikorn Voravootivat <puthik@chromium.org>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Ashutosh D Shukla <ashutosh.d.shukla@intel.com>
Cc: Maulik V Vaghela <maulik.v.vaghela@intel.com>

Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 465dff4..9ef0464 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
 	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
 	 * Old decimal value is wake up time in multiples of 100 us.
 	 */
-	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
+	if (bdb->version >= 205 && (IS_GEN9_BC(dev_priv) ||
+	    IS_GEMINILAKE(dev_priv) || (INTEL_GEN(dev_priv) >= 10))) {
 		switch (psr_table->tp1_wakeup_time) {
 		case 0:
 			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Adds psrwake options for all platforms (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915/psr: Adds psrwake options for all platforms (rev3)
URL   : https://patchwork.freedesktop.org/series/44601/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
71a6e6f9fe0e drm/i915/psr: Adds psrwake options for all platforms
-:42: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#42: FILE: drivers/gpu/drm/i915/intel_bios.c:714:
+	if (bdb->version >= 205 && (IS_GEN9_BC(dev_priv) ||
+	    IS_GEMINILAKE(dev_priv) || (INTEL_GEN(dev_priv) >= 10))) {

total: 0 errors, 0 warnings, 1 checks, 9 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/psr: Adds psrwake options for all platforms (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915/psr: Adds psrwake options for all platforms (rev3)
URL   : https://patchwork.freedesktop.org/series/44601/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4331 -> Patchwork_9345 =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_9345 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9345, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/44601/revisions/3/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9345:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_gttfill@basic:
      fi-pnv-d510:        PASS -> SKIP

    
== Known issues ==

  Here are the changes found in Patchwork_9345 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
      fi-glk-j4005:       PASS -> FAIL (fdo#106765)

    igt@kms_flip@basic-plain-flip:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106000)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-cnl-psr:         PASS -> DMESG-WARN (fdo#104951)

    igt@prime_busy@basic-before-default:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#105719)

    
    ==== Possible fixes ====

    igt@gem_ringfill@basic-default-hang:
      fi-elk-e7500:       DMESG-WARN -> PASS

    igt@kms_chamelium@dp-crc-fast:
      fi-kbl-7500u:       DMESG-FAIL (fdo#103841) -> PASS

    igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
      fi-glk-j4005:       FAIL (fdo#106765) -> PASS

    
  fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
  fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
  fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
  fdo#106765 https://bugs.freedesktop.org/show_bug.cgi?id=106765


== Participating hosts (41 -> 35) ==

  Additional (1): fi-bxt-dsi 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ilk-650 fi-ctg-p8600 


== Build changes ==

    * Linux: CI_DRM_4331 -> Patchwork_9345

  CI_DRM_4331: e47233f783ee68a864c2a10216735aca62d642da @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4522: 077c6f7c3786334c5e5c34888ab446fdb4347331 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9345: 71a6e6f9fe0e541daf1a181cb6debc8086d1fa84 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

71a6e6f9fe0e drm/i915/psr: Adds psrwake options for all platforms

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9345/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915/psr: Adds psrwake options for all platforms (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915/psr: Adds psrwake options for all platforms (rev3)
URL   : https://patchwork.freedesktop.org/series/44601/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4331_full -> Patchwork_9345_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_9345_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9345_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9345_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_tiled_blits@interruptible:
      shard-glk:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in Patchwork_9345_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_gtt:
      shard-apl:          PASS -> INCOMPLETE (fdo#103927)

    igt@drv_selftest@live_hangcheck:
      shard-glk:          NOTRUN -> DMESG-FAIL (fdo#106947)

    igt@kms_cursor_crc@cursor-64x64-suspend:
      shard-snb:          PASS -> DMESG-WARN (fdo#102365)

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-glk:          PASS -> DMESG-WARN (fdo#105763)

    igt@kms_flip_tiling@flip-y-tiled:
      shard-glk:          PASS -> FAIL (fdo#104724, fdo#103822)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      shard-apl:          PASS -> FAIL (fdo#103375)

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          FAIL (fdo#106509) -> PASS

    igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_flip_tiling@flip-to-x-tiled:
      shard-glk:          FAIL (fdo#104724, fdo#103822) -> PASS

    igt@kms_flip_tiling@flip-to-y-tiled:
      shard-glk:          FAIL (fdo#104724) -> PASS

    igt@perf@polling:
      shard-hsw:          FAIL (fdo#102252) -> PASS

    
    ==== Warnings ====

    igt@drv_selftest@live_gtt:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359) -> FAIL (fdo#105347)

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
  fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4331 -> Patchwork_9345

  CI_DRM_4331: e47233f783ee68a864c2a10216735aca62d642da @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4522: 077c6f7c3786334c5e5c34888ab446fdb4347331 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9345: 71a6e6f9fe0e541daf1a181cb6debc8086d1fa84 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9345/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Dhinakaran Pandiyan]

On Mon, 2018-06-18 at 11:42 +0530, vathsala nagaraju wrote:
> From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> 
> Adds new psrwake options defined in the below table.
> Platform	PSR wake options vbt version
> KBL/CFL/WHL	All(205+)
> BXT		Uses old interpretation.
> CNL/ICL+	All(205+)
> GLK		All(205+)
> SKL		All PV releases (Check for 205+ might help but
> cannot be foolproof)
> 
> We will continue with newer interpretation for SKL from 205.
Let's hope this works for most machines out there.

It'd be easier to distinguish newer updated patches if you use version
numbers.

Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

> 
> v2: Jani
>     Keep the bdb version check.
> v3:
>     Apply newer version for skl from 205+(DK).
>     Add (version check && platform list) (Jani).
>     Add bdb version for each platform in commit message(DK).
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Puthikorn Voravootivat <puthik@chromium.org>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: Ashutosh D Shukla <ashutosh.d.shukla@intel.com>
> Cc: Maulik V Vaghela <maulik.v.vaghela@intel.com>
> 
> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_bios.c
> b/drivers/gpu/drm/i915/intel_bios.c
> index 465dff4..9ef0464 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct
> drm_i915_private *dev_priv,
>  	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
>  	 * Old decimal value is wake up time in multiples of 100 us.
>  	 */
> -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
> +	if (bdb->version >= 205 && (IS_GEN9_BC(dev_priv) ||
> +	    IS_GEMINILAKE(dev_priv) || (INTEL_GEN(dev_priv) >= 10)))
> {
>  		switch (psr_table->tp1_wakeup_time) {
>  		case 0:
>  			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Jani Nikula]

On Mon, 18 Jun 2018, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> wrote:
> On Mon, 2018-06-18 at 11:42 +0530, vathsala nagaraju wrote:
>> From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
>> 
>> Adds new psrwake options defined in the below table.
>> Platform	PSR wake options vbt version
>> KBL/CFL/WHL	All(205+)
>> BXT		Uses old interpretation.
>> CNL/ICL+	All(205+)
>> GLK		All(205+)
>> SKL		All PV releases (Check for 205+ might help but
>> cannot be foolproof)
>> 
>> We will continue with newer interpretation for SKL from 205.
> Let's hope this works for most machines out there.
>
> It'd be easier to distinguish newer updated patches if you use version
> numbers.
>
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

Thanks for the patch and review, pushed to dinq with the checkpatch
warnings fixed while at it.

BR,
Jani.


>
>> 
>> v2: Jani
>>     Keep the bdb version check.
>> v3:
>>     Apply newer version for skl from 205+(DK).
>>     Add (version check && platform list) (Jani).
>>     Add bdb version for each platform in commit message(DK).
>> 
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Puthikorn Voravootivat <puthik@chromium.org>
>> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>> Cc: Ashutosh D Shukla <ashutosh.d.shukla@intel.com>
>> Cc: Maulik V Vaghela <maulik.v.vaghela@intel.com>
>> 
>> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_bios.c
>> b/drivers/gpu/drm/i915/intel_bios.c
>> index 465dff4..9ef0464 100644
>> --- a/drivers/gpu/drm/i915/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>> @@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct
>> drm_i915_private *dev_priv,
>>  	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
>>  	 * Old decimal value is wake up time in multiples of 100 us.
>>  	 */
>> -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
>> +	if (bdb->version >= 205 && (IS_GEN9_BC(dev_priv) ||
>> +	    IS_GEMINILAKE(dev_priv) || (INTEL_GEN(dev_priv) >= 10)))
>> {
>>  		switch (psr_table->tp1_wakeup_time) {
>>  		case 0:
>>  			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx