From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2] drm/i915: Actually flush interrupts on reset not just wedging Date: Fri, 23 Mar 2018 12:53:00 +0200 Message-ID: <87y3ij3vxv.fsf@gaia.fi.intel.com> References: <20180323090806.13096-1-chris@chris-wilson.co.uk> <20180323101824.14645-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id E057B6E02D for ; Fri, 23 Mar 2018 10:53:06 +0000 (UTC) In-Reply-To: <20180323101824.14645-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQ29tbWl0 IDBmMzZhODVjM2JkNSAoImRybS9pOTE1OiBGbHVzaCBwZW5kaW5nIGludGVycnVwdCBmb2xsb3dp bmcgYSBHUFUKPiByZXNldCIpIGdvdCBjb25mdXNlZCBhbmQgb25seSBhcHBsaWVkIHRoZSBmbHVz aCB0byB0aGUgc2V0LXdlZGdlIHBhdGgKPiAod2hpY2ggaXRzZWxmIGlzIHByb3ZpbmcgdHJvdWJs ZXNvbWUpLCBidXQgd2UgYWxzbyBuZWVkIHRoZQo+IHNlcmlhbGlzYXRpb24gb24gdGhlIHJlZ3Vs YXIgcmVzZXQgcGF0aC4gT29wcy4KPgo+IE1vdmUgdGhlIGludGVycnVwdCBpbnRvIHJlc2V0X2ly cSgpIGFuZCBtYWtlIGl0IGNvbW1vbiB0byB0aGUgcmVzZXQgYW5kCj4gZmluYWwgc2V0LXdlZGdl Lgo+Cj4gdjI6IHJlc2V0X2lycSgpIGFmdGVyIHBvcnQgY2FuY2VsbGF0aW9uLCBhcyB3ZSBhc3Nl cnQgdGhhdAo+IGV4ZWNsaXN0cy0+YWN0aXZlIGlzIHNhbmUgZm9yIGNhbmNlbGxhdGlvbiAoYW5k IGlzIGJlaW5nIHJlc2V0IGJ5Cj4gcmVzZXRfaXJxKS4KPgo+IFJlZmVyZW5jZXM6IDBmMzZhODVj M2JkNSAoImRybS9pOTE1OiBGbHVzaCBwZW5kaW5nIGludGVycnVwdCBmb2xsb3dpbmcgYSBHUFUg cmVzZXQiKQo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29u LmNvLnVrPgo+IENjOiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNv bT4KPiBDYzogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4KPiBDYzog TWljaGHFgiBXaW5pYXJza2kgPG1pY2hhbC53aW5pYXJza2lAaW50ZWwuY29tPgo+IENjOiBKZWZm IE1jR2VlIDxqZWZmLm1jZ2VlQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHJjLmMgfCAxMDcgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1MyBpbnNlcnRpb25zKCspLCA1NCBkZWxldGlvbnMoLSkK Pgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggY2UwOWM1YWQzMzRmLi5iNGFiMDZi MDVlNTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC03NDAsNiArNzQwLDU3 IEBAIGV4ZWNsaXN0c19jYW5jZWxfcG9ydF9yZXF1ZXN0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4 ZWNsaXN0cyAqIGNvbnN0IGV4ZWNsaXN0cykKPiAgCX0KPiAgfQo+ICAKPiArc3RhdGljIHZvaWQg Y2xlYXJfZ3RpaXIoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICt7Cj4gKwlzdGF0 aWMgY29uc3QgdTggZ3RpaXJbXSA9IHsKPiArCQlbUkNTXSAgPSAwLAo+ICsJCVtCQ1NdICA9IDAs Cj4gKwkJW1ZDU10gID0gMSwKPiArCQlbVkNTMl0gPSAxLAo+ICsJCVtWRUNTXSA9IDMsCj4gKwl9 Owo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZW5naW5lLT5pOTE1Owo+ ICsJaW50IGk7Cj4gKwo+ICsJLyogVE9ETzogY29ycmVjdGx5IHJlc2V0IGlycXMgZm9yIGdlbjEx ICovCj4gKwlpZiAoV0FSTl9PTl9PTkNFKElOVEVMX0dFTihlbmdpbmUtPmk5MTUpID49IDExKSkK PiArCQlyZXR1cm47Cj4gKwo+ICsJR0VNX0JVR19PTihlbmdpbmUtPmlkID49IEFSUkFZX1NJWkUo Z3RpaXIpKTsKPiArCj4gKwkvKgo+ICsJICogQ2xlYXIgYW55IHBlbmRpbmcgaW50ZXJydXB0IHN0 YXRlLgo+ICsJICoKPiArCSAqIFdlIGRvIGl0IHR3aWNlIG91dCBvZiBwYXJhbm9pYSB0aGF0IHNv bWUgb2YgdGhlIElJUiBhcmUKPiArCSAqIGRvdWJsZSBidWZmZXJlZCwgYW5kIHNvIGlmIHdlIG9u bHkgcmVzZXQgaXQgb25jZSB0aGVyZSBtYXkKPiArCSAqIHN0aWxsIGJlIGFuIGludGVycnVwdCBw ZW5kaW5nLgo+ICsJICovCj4gKwlmb3IgKGkgPSAwOyBpIDwgMjsgaSsrKSB7Cj4gKwkJSTkxNV9X UklURShHRU44X0dUX0lJUihndGlpcltlbmdpbmUtPmlkXSksCj4gKwkJCSAgIGVuZ2luZS0+aXJx X2tlZXBfbWFzayk7Cj4gKwkJUE9TVElOR19SRUFEKEdFTjhfR1RfSUlSKGd0aWlyW2VuZ2luZS0+ aWRdKSk7Cj4gKwl9Cj4gKwlHRU1fQlVHX09OKEk5MTVfUkVBRChHRU44X0dUX0lJUihndGlpcltl bmdpbmUtPmlkXSkpICYKPiArCQkgICBlbmdpbmUtPmlycV9rZWVwX21hc2spOwo+ICt9Cj4gKwo+ ICtzdGF0aWMgdm9pZCByZXNldF9pcnEoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ ICt7Cj4gKwkvKiBNYXJrIGFsbCBDUyBpbnRlcnJ1cHRzIGFzIGNvbXBsZXRlICovCj4gKwlzbXBf c3RvcmVfbWIoZW5naW5lLT5leGVjbGlzdHMuYWN0aXZlLCAwKTsKPiArCXN5bmNocm9uaXplX2hh cmRpcnEoZW5naW5lLT5pOTE1LT5kcm0uaXJxKTsKPiArCj4gKwljbGVhcl9ndGlpcihlbmdpbmUp OwoKU2hvdWxkIGNsZWFyaW5nIHRoZSBpaXIgYmUgYmVmb3JlIHdlIHN5bmNocm9uaXplPwpPdXIg bWFzdGVyIGlycSBpcyBvZmYsIHNvIG5vIGJpdCBjYW4gbGlnaHQgdXAsCmNsZWFyIGlpciwgcHJl dmVudCB0YXNrbGV0IHdpdGggYWN0aXZlIGFuZCBzeW5jaHJvbml6ZS4KCkZvciBkb2N1bWVudGF0 aW9uIGl0IHdvdWxkIGJlIG5pY2UgdGhhdCB3ZSBoYXZlCmFzc2VydCB0aGF0IHRoZSB0YXNrbGV0 IGlzIGluZGVlZCBkaXNhYmxlZC4KLU1pa2EKCj4gKwo+ICsJLyoKPiArCSAqIFRoZSBwb3J0IGlz IGNoZWNrZWQgcHJpb3IgdG8gc2NoZWR1bGluZyBhIHRhc2tsZXQsIGJ1dAo+ICsJICoganVzdCBp biBjYXNlIHdlIGhhdmUgc3VzcGVuZGVkIHRoZSB0YXNrbGV0IHRvIGRvIHRoZQo+ICsJICogd2Vk Z2luZyBtYWtlIHN1cmUgdGhhdCB3aGVuIGl0IHdha2VzLCBpdCBkZWNpZGVzIHRoZXJlCj4gKwkg KiBpcyBubyB3b3JrIHRvIGRvIGJ5IGNsZWFyaW5nIHRoZSBpcnFfcG9zdGVkIGJpdC4KPiArCSAq Lwo+ICsJY2xlYXJfYml0KEVOR0lORV9JUlFfRVhFQ0xJU1QsICZlbmdpbmUtPmlycV9wb3N0ZWQp Owo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBleGVjbGlzdHNfY2FuY2VsX3JlcXVlc3RzKHN0cnVj dCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgewo+ICAJc3RydWN0IGludGVsX2VuZ2luZV9l eGVjbGlzdHMgKiBjb25zdCBleGVjbGlzdHMgPSAmZW5naW5lLT5leGVjbGlzdHM7Cj4gQEAgLTc2 Nyw2ICs4MTgsNyBAQCBzdGF0aWMgdm9pZCBleGVjbGlzdHNfY2FuY2VsX3JlcXVlc3RzKHN0cnVj dCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCj4gIAkvKiBDYW5jZWwgdGhlIHJlcXVlc3Rz IG9uIHRoZSBIVyBhbmQgY2xlYXIgdGhlIEVMU1AgdHJhY2tlci4gKi8KPiAgCWV4ZWNsaXN0c19j YW5jZWxfcG9ydF9yZXF1ZXN0cyhleGVjbGlzdHMpOwo+ICsJcmVzZXRfaXJxKGVuZ2luZSk7Cj4g IAo+ICAJc3Bpbl9sb2NrKCZlbmdpbmUtPnRpbWVsaW5lLT5sb2NrKTsKPiAgCj4gQEAgLTgwNSwx OCArODU3LDYgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2NhbmNlbF9yZXF1ZXN0cyhzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAo+ICAJc3Bpbl91bmxvY2soJmVuZ2luZS0+dGlt ZWxpbmUtPmxvY2spOwo+ICAKPiAtCS8qIE1hcmsgYWxsIENTIGludGVycnVwdHMgYXMgY29tcGxl dGUgKi8KPiAtCXNtcF9zdG9yZV9tYihleGVjbGlzdHMtPmFjdGl2ZSwgMCk7Cj4gLQlzeW5jaHJv bml6ZV9oYXJkaXJxKGVuZ2luZS0+aTkxNS0+ZHJtLmlycSk7Cj4gLQo+IC0JLyoKPiAtCSAqIFRo ZSBwb3J0IGlzIGNoZWNrZWQgcHJpb3IgdG8gc2NoZWR1bGluZyBhIHRhc2tsZXQsIGJ1dAo+IC0J ICoganVzdCBpbiBjYXNlIHdlIGhhdmUgc3VzcGVuZGVkIHRoZSB0YXNrbGV0IHRvIGRvIHRoZQo+ IC0JICogd2VkZ2luZyBtYWtlIHN1cmUgdGhhdCB3aGVuIGl0IHdha2VzLCBpdCBkZWNpZGVzIHRo ZXJlCj4gLQkgKiBpcyBubyB3b3JrIHRvIGRvIGJ5IGNsZWFyaW5nIHRoZSBpcnFfcG9zdGVkIGJp dC4KPiAtCSAqLwo+IC0JY2xlYXJfYml0KEVOR0lORV9JUlFfRVhFQ0xJU1QsICZlbmdpbmUtPmly cV9wb3N0ZWQpOwo+IC0KPiAgCWxvY2FsX2lycV9yZXN0b3JlKGZsYWdzKTsKPiAgfQo+ICAKPiBA QCAtMTU2NiwxNCArMTYwNiw2IEBAIHN0YXRpYyBpbnQgaW50ZWxfaW5pdF93b3JrYXJvdW5kX2Ji KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAg Cj4gLXN0YXRpYyB1OCBndGlpcltdID0gewo+IC0JW1JDU10gPSAwLAo+IC0JW0JDU10gPSAwLAo+ IC0JW1ZDU10gPSAxLAo+IC0JW1ZDUzJdID0gMSwKPiAtCVtWRUNTXSA9IDMsCj4gLX07Cj4gLQo+ ICBzdGF0aWMgdm9pZCBlbmFibGVfZXhlY2xpc3RzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu Z2luZSkKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZW5naW5l LT5pOTE1Owo+IEBAIC0xNjU3LDM1ICsxNjg5LDYgQEAgc3RhdGljIGludCBnZW45X2luaXRfcmVu ZGVyX3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJcmV0dXJuIGluaXRf d29ya2Fyb3VuZHNfcmluZyhlbmdpbmUpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCByZXNldF9p cnEoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+IC17Cj4gLQlzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBlbmdpbmUtPmk5MTU7Cj4gLQlpbnQgaTsKPiAtCj4gLQkv KiBUT0RPOiBjb3JyZWN0bHkgcmVzZXQgaXJxcyBmb3IgZ2VuMTEgKi8KPiAtCWlmIChXQVJOX09O X09OQ0UoSU5URUxfR0VOKGVuZ2luZS0+aTkxNSkgPj0gMTEpKQo+IC0JCXJldHVybjsKPiAtCj4g LQlHRU1fQlVHX09OKGVuZ2luZS0+aWQgPj0gQVJSQVlfU0laRShndGlpcikpOwo+IC0KPiAtCS8q Cj4gLQkgKiBDbGVhciBhbnkgcGVuZGluZyBpbnRlcnJ1cHQgc3RhdGUuCj4gLQkgKgo+IC0JICog V2UgZG8gaXQgdHdpY2Ugb3V0IG9mIHBhcmFub2lhIHRoYXQgc29tZSBvZiB0aGUgSUlSIGFyZSBk b3VibGUKPiAtCSAqIGJ1ZmZlcmVkLCBhbmQgaWYgd2Ugb25seSByZXNldCBpdCBvbmNlIHRoZXJl IG1heSBzdGlsbCBiZQo+IC0JICogYW4gaW50ZXJydXB0IHBlbmRpbmcuCj4gLQkgKi8KPiAtCWZv ciAoaSA9IDA7IGkgPCAyOyBpKyspIHsKPiAtCQlJOTE1X1dSSVRFKEdFTjhfR1RfSUlSKGd0aWly W2VuZ2luZS0+aWRdKSwKPiAtCQkJICAgZW5naW5lLT5pcnFfa2VlcF9tYXNrKTsKPiAtCQlQT1NU SU5HX1JFQUQoR0VOOF9HVF9JSVIoZ3RpaXJbZW5naW5lLT5pZF0pKTsKPiAtCX0KPiAtCUdFTV9C VUdfT04oSTkxNV9SRUFEKEdFTjhfR1RfSUlSKGd0aWlyW2VuZ2luZS0+aWRdKSkgJgo+IC0JCSAg IGVuZ2luZS0+aXJxX2tlZXBfbWFzayk7Cj4gLQo+IC0JY2xlYXJfYml0KEVOR0lORV9JUlFfRVhF Q0xJU1QsICZlbmdpbmUtPmlycV9wb3N0ZWQpOwo+IC19Cj4gLQo+ICBzdGF0aWMgdm9pZCByZXNl dF9jb21tb25fcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gIAkJCSAgICAg IHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJlcXVlc3QpCj4gIHsKPiBAQCAtMTY5OSw4ICsxNzAyLDYg QEAgc3RhdGljIHZvaWQgcmVzZXRfY29tbW9uX3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAq ZW5naW5lLAo+ICAJLyogU2VlIGV4ZWNsaXN0c19jYW5jZWxfcmVxdWVzdHMoKSBmb3IgdGhlIGly cS9zcGlubG9jayBzcGxpdC4gKi8KPiAgCWxvY2FsX2lycV9zYXZlKGZsYWdzKTsKPiAgCj4gLQly ZXNldF9pcnEoZW5naW5lKTsKPiAtCj4gIAkvKgo+ICAJICogQ2F0Y2ggdXAgd2l0aCBhbnkgbWlz c2VkIGNvbnRleHQtc3dpdGNoIGludGVycnVwdHMuCj4gIAkgKgo+IEBAIC0xNzExLDE1ICsxNzEy LDEzIEBAIHN0YXRpYyB2b2lkIHJlc2V0X2NvbW1vbl9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVf Y3MgKmVuZ2luZSwKPiAgCSAqIHJlcXVlc3RzIHdlcmUgY29tcGxldGVkLgo+ICAJICovCj4gIAll eGVjbGlzdHNfY2FuY2VsX3BvcnRfcmVxdWVzdHMoZXhlY2xpc3RzKTsKPiArCXJlc2V0X2lycShl bmdpbmUpOwo+ICAKPiAgCS8qIFB1c2ggYmFjayBhbnkgaW5jb21wbGV0ZSByZXF1ZXN0cyBmb3Ig cmVwbGF5IGFmdGVyIHRoZSByZXNldC4gKi8KPiAgCXNwaW5fbG9jaygmZW5naW5lLT50aW1lbGlu ZS0+bG9jayk7Cj4gIAlfX3Vud2luZF9pbmNvbXBsZXRlX3JlcXVlc3RzKGVuZ2luZSk7Cj4gIAlz cGluX3VubG9jaygmZW5naW5lLT50aW1lbGluZS0+bG9jayk7Cj4gIAo+IC0JLyogTWFyayBhbGwg Q1MgaW50ZXJydXB0cyBhcyBjb21wbGV0ZSAqLwo+IC0JZXhlY2xpc3RzLT5hY3RpdmUgPSAwOwo+ IC0KPiAgCWxvY2FsX2lycV9yZXN0b3JlKGZsYWdzKTsKPiAgCj4gIAkvKgo+IC0tIAo+IDIuMTYu MgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK