Re: [PATCH] drm/i915/cnl: Remove alpha_support protection

Jani Nikula
2018-02-14T16:17:38Z

On Wed, 14 Feb 2018, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> We now have a stable cnl on our CI and it seems mostly
> green without big risks of blank screen or anything
> blowing up on linux installations in the future.
>
> As a reminder i915.alpha_support was created to protect
> future linux instalation's iso images that might contain a kernel
> from the enabling time of the new platform. Without this
> protection most of linux installation was recommending
> nomodeset option during installation that was getting stick
> there after installation.

Specifically, alpha support says nothing about the development state of
the hardware, and everything about the state of the driver in a kernel
release.

This is semantically no different from the old preliminary_hw_support
flag, but the old one was all too often interpreted as (preliminary hw)
support instead of the intended (preliminary) hw support, and it was
misleading for everyone. Hence the rename.

Please fix the typos, and with that,

Acked-by: Jani Nikula <jani.nikula@intel.com>

>
> Reference: https://intel-gfx-ci.01.org/tree/drm-tip/fi-cnl-y3.html
> Cc: James Ausmus <james.ausmus@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Jani Saarinen <jani.saarinen@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 4e7a10c89782..49cef20594b3 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -573,7 +573,6 @@ static const struct intel_device_info intel_coffeelake_gt3_info = {
>
> static const struct intel_device_info intel_cannonlake_info = {
> GEN10_FEATURES,
> - .is_alpha_support = 1,
> .platform = INTEL_CANNONLAKE,
> .gen = 10,
> .gt = 2,

--
Jani Nikula, Intel Open Source Technology Center