From: Jani Nikula <jani.nikula@linux.intel.com>
To: Adam Jackson <ajax@redhat.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] intel_vbt_decode: Typo fixes
Date: Tue, 19 Dec 2017 16:51:12 +0200 [thread overview]
Message-ID: <87y3lyojof.fsf@intel.com> (raw)
In-Reply-To: <20171215195936.28356-1-ajax@redhat.com>
On Fri, 15 Dec 2017, Adam Jackson <ajax@redhat.com> wrote:
> Signed-off-by: Adam Jackson <ajax@redhat.com>
> ---
> tools/intel_vbt_decode.c | 4 ++--
> tools/intel_vbt_defs.h | 6 +++---
Hi Adam, thanks for the patch. We've opted to make the kernel copy of
this file the single point of truth, and copy that over verbatim every
once in a while. Please send a patch to
drivers/gpu/drm/i915/intel_vbt_defs.h and it'll trickle over here
eventually when we sync up (or you can send the sync patch too).
Thanks,
Jani.
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index 9d90c69d..ce7da2c0 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -309,8 +309,8 @@ static const struct {
> { DEVICE_TYPE_COMPOSITE_OUTPUT, "Composite output" },
> { DEVICE_TYPE_DUAL_CHANNEL, "Dual channel" },
> { 1 << 7, "Content protection" },
> - { DEVICE_TYPE_HIGH_SPEED_LINK, "High speel link" },
> - { DEVICE_TYPE_LVDS_SINGALING, "LVDS signaling" },
> + { DEVICE_TYPE_HIGH_SPEED_LINK, "High speed link" },
> + { DEVICE_TYPE_LVDS_SIGNALING, "LVDS signaling" },
> { DEVICE_TYPE_TMDS_DVI_SIGNALING, "TMDS/DVI signaling" },
> { DEVICE_TYPE_VIDEO_SIGNALING, "Video signaling" },
> { DEVICE_TYPE_DISPLAYPORT_OUTPUT, "DisplayPort output" },
> diff --git a/tools/intel_vbt_defs.h b/tools/intel_vbt_defs.h
> index 404569c9..e388f9ad 100644
> --- a/tools/intel_vbt_defs.h
> +++ b/tools/intel_vbt_defs.h
> @@ -227,7 +227,7 @@ struct bdb_general_features {
> #define DEVICE_TYPE_COMPOSITE_OUTPUT (1 << 9)
> #define DEVICE_TYPE_DUAL_CHANNEL (1 << 8)
> #define DEVICE_TYPE_HIGH_SPEED_LINK (1 << 6)
> -#define DEVICE_TYPE_LVDS_SINGALING (1 << 5)
> +#define DEVICE_TYPE_LVDS_SIGNALING (1 << 5)
> #define DEVICE_TYPE_TMDS_DVI_SIGNALING (1 << 4)
> #define DEVICE_TYPE_VIDEO_SIGNALING (1 << 3)
> #define DEVICE_TYPE_DISPLAYPORT_OUTPUT (1 << 2)
> @@ -243,7 +243,7 @@ struct bdb_general_features {
> DEVICE_TYPE_MIPI_OUTPUT | \
> DEVICE_TYPE_COMPOSITE_OUTPUT | \
> DEVICE_TYPE_DUAL_CHANNEL | \
> - DEVICE_TYPE_LVDS_SINGALING | \
> + DEVICE_TYPE_LVDS_SIGNALING | \
> DEVICE_TYPE_TMDS_DVI_SIGNALING | \
> DEVICE_TYPE_VIDEO_SIGNALING | \
> DEVICE_TYPE_DISPLAYPORT_OUTPUT | \
> @@ -253,7 +253,7 @@ struct bdb_general_features {
> (DEVICE_TYPE_INTERNAL_CONNECTOR | \
> DEVICE_TYPE_MIPI_OUTPUT | \
> DEVICE_TYPE_COMPOSITE_OUTPUT | \
> - DEVICE_TYPE_LVDS_SINGALING | \
> + DEVICE_TYPE_LVDS_SIGNALING | \
> DEVICE_TYPE_TMDS_DVI_SIGNALING | \
> DEVICE_TYPE_VIDEO_SIGNALING | \
> DEVICE_TYPE_DISPLAYPORT_OUTPUT | \
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-12-19 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 19:59 [PATCH i-g-t] intel_vbt_decode: Typo fixes Adam Jackson
2017-12-15 20:55 ` Chris Wilson
2017-12-18 11:50 ` Arkadiusz Hiler
2017-12-18 13:31 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-12-18 14:22 ` ✗ Fi.CI.BAT: failure " Patchwork
2017-12-19 14:51 ` Jani Nikula [this message]
2018-01-19 8:48 ` [PATCH i-g-t] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3lyojof.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=ajax@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).