[PATCH] drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.

[PATCH] drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.

[Rodrigo Vivi]

Cannon Lake's VBT that is currently available for B0 stepping
states that port D uses alternate pin 3 messing up with the
default pin-port mapping table. Using that information we cannot
get HDMI working properly. So for now we don't relly on VBT for
this information.

Cc: Clint Taylor <clinton.a.taylor@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 639d45c..82b144c 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1187,6 +1187,15 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, enum port port,
 	if (is_dvi) {
 		info->alternate_ddc_pin = ddc_pin;
 
+		/*
+		 * All VBTs that we got so far for B Stepping has this
+		 * information wrong for Port D. So, let's just ignore for now.
+		 */
+		if (IS_CNL_REVID(dev_priv, CNL_REVID_B0, CNL_REVID_B0) &&
+		    port == PORT_D) {
+			info->alternate_ddc_pin = 0;
+		}
+
 		sanitize_ddc_pin(dev_priv, port);
 	}
 
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.

[Clint Taylor]

On 07/06/2017 02:08 PM, Rodrigo Vivi wrote:
> Cannon Lake's VBT that is currently available for B0 stepping
> states that port D uses alternate pin 3 messing up with the
> default pin-port mapping table. Using that information we cannot
> get HDMI working properly. So for now we don't relly on VBT for
> this information.
>
> Cc: Clint Taylor <clinton.a.taylor@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_bios.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 639d45c..82b144c 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1187,6 +1187,15 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, enum port port,
>   	if (is_dvi) {
>   		info->alternate_ddc_pin = ddc_pin;
>   
> +		/*
> +		 * All VBTs that we got so far for B Stepping has this
> +		 * information wrong for Port D. So, let's just ignore for now.
> +		 */
> +		if (IS_CNL_REVID(dev_priv, CNL_REVID_B0, CNL_REVID_B0) &&
> +		    port == PORT_D) {
> +			info->alternate_ddc_pin = 0;
> +		}
> +

Reviewed-by: Clinton Taylor <clinton.a.taylor@intel.com>

-Clint

>   		sanitize_ddc_pin(dev_priv, port);
>   	}
>   

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.

[Patchwork]

== Series Details ==

Series: drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.
URL   : https://patchwork.freedesktop.org/series/26956/
State : success

== Summary ==

Series 26956v1 drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.
https://patchwork.freedesktop.org/api/1.0/series/26956/revisions/1/mbox/

Test gem_exec_suspend:
        Subgroup basic-s4-devices:
                pass       -> DMESG-WARN (fi-kbl-r) fdo#100125

fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125

fi-bdw-5557u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:452s
fi-bdw-gvtdvm    total:279  pass:265  dwarn:0   dfail:0   fail:0   skip:14  time:429s
fi-blb-e6850     total:279  pass:224  dwarn:1   dfail:0   fail:0   skip:54  time:357s
fi-bsw-n3050     total:279  pass:243  dwarn:0   dfail:0   fail:0   skip:36  time:517s
fi-bxt-j4205     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:505s
fi-byt-j1900     total:279  pass:254  dwarn:1   dfail:0   fail:0   skip:24  time:497s
fi-byt-n2820     total:279  pass:250  dwarn:1   dfail:0   fail:0   skip:28  time:480s
fi-glk-2a        total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:595s
fi-hsw-4770      total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:433s
fi-hsw-4770r     total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:409s
fi-ilk-650       total:279  pass:229  dwarn:0   dfail:0   fail:0   skip:50  time:422s
fi-ivb-3520m     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:499s
fi-ivb-3770      total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:481s
fi-kbl-7500u     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:465s
fi-kbl-7560u     total:279  pass:268  dwarn:1   dfail:0   fail:0   skip:10  time:569s
fi-kbl-r         total:279  pass:260  dwarn:1   dfail:0   fail:0   skip:18  time:580s
fi-pnv-d510      total:279  pass:222  dwarn:2   dfail:0   fail:0   skip:55  time:564s
fi-skl-6260u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:460s
fi-skl-6700hq    total:279  pass:262  dwarn:0   dfail:0   fail:0   skip:17  time:584s
fi-skl-6700k     total:279  pass:257  dwarn:4   dfail:0   fail:0   skip:18  time:468s
fi-skl-6770hq    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:477s
fi-skl-gvtdvm    total:279  pass:266  dwarn:0   dfail:0   fail:0   skip:13  time:437s
fi-snb-2520m     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:542s
fi-snb-2600      total:279  pass:250  dwarn:0   dfail:0   fail:0   skip:29  time:400s

11125fb7b775223081da697898a92119cb017538 drm-tip: 2017y-07m-06d-23h-19m-02s UTC integration manifest
6514db7 drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_5140/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.

[Rodrigo Vivi]

patch merged to dinq. thanks for reviewing.

On Thu, Jul 6, 2017 at 2:52 PM, Clint Taylor <clinton.a.taylor@intel.com> wrote:
>
>
> On 07/06/2017 02:08 PM, Rodrigo Vivi wrote:
>>
>> Cannon Lake's VBT that is currently available for B0 stepping
>> states that port D uses alternate pin 3 messing up with the
>> default pin-port mapping table. Using that information we cannot
>> get HDMI working properly. So for now we don't relly on VBT for
>> this information.
>>
>> Cc: Clint Taylor <clinton.a.taylor@intel.com>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> ---
>>   drivers/gpu/drm/i915/intel_bios.c | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_bios.c
>> b/drivers/gpu/drm/i915/intel_bios.c
>> index 639d45c..82b144c 100644
>> --- a/drivers/gpu/drm/i915/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>> @@ -1187,6 +1187,15 @@ static void parse_ddi_port(struct drm_i915_private
>> *dev_priv, enum port port,
>>         if (is_dvi) {
>>                 info->alternate_ddc_pin = ddc_pin;
>>   +             /*
>> +                * All VBTs that we got so far for B Stepping has this
>> +                * information wrong for Port D. So, let's just ignore for
>> now.
>> +                */
>> +               if (IS_CNL_REVID(dev_priv, CNL_REVID_B0, CNL_REVID_B0) &&
>> +                   port == PORT_D) {
>> +                       info->alternate_ddc_pin = 0;
>> +               }
>> +
>
>
> Reviewed-by: Clinton Taylor <clinton.a.taylor@intel.com>
>
> -Clint
>
>>                 sanitize_ddc_pin(dev_priv, port);
>>         }
>>
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.

[Jani Nikula]

On Fri, 07 Jul 2017, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> patch merged to dinq. thanks for reviewing.

Did you report the VBT issue? Whenever we paper over bugs in other
components, we're sending a message it's fine. It's not.

BR,
Jani.


>
> On Thu, Jul 6, 2017 at 2:52 PM, Clint Taylor <clinton.a.taylor@intel.com> wrote:
>>
>>
>> On 07/06/2017 02:08 PM, Rodrigo Vivi wrote:
>>>
>>> Cannon Lake's VBT that is currently available for B0 stepping
>>> states that port D uses alternate pin 3 messing up with the
>>> default pin-port mapping table. Using that information we cannot
>>> get HDMI working properly. So for now we don't relly on VBT for
>>> this information.
>>>
>>> Cc: Clint Taylor <clinton.a.taylor@intel.com>
>>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> ---
>>>   drivers/gpu/drm/i915/intel_bios.c | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_bios.c
>>> b/drivers/gpu/drm/i915/intel_bios.c
>>> index 639d45c..82b144c 100644
>>> --- a/drivers/gpu/drm/i915/intel_bios.c
>>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>>> @@ -1187,6 +1187,15 @@ static void parse_ddi_port(struct drm_i915_private
>>> *dev_priv, enum port port,
>>>         if (is_dvi) {
>>>                 info->alternate_ddc_pin = ddc_pin;
>>>   +             /*
>>> +                * All VBTs that we got so far for B Stepping has this
>>> +                * information wrong for Port D. So, let's just ignore for
>>> now.
>>> +                */
>>> +               if (IS_CNL_REVID(dev_priv, CNL_REVID_B0, CNL_REVID_B0) &&
>>> +                   port == PORT_D) {
>>> +                       info->alternate_ddc_pin = 0;
>>> +               }
>>> +
>>
>>
>> Reviewed-by: Clinton Taylor <clinton.a.taylor@intel.com>
>>
>> -Clint
>>
>>>                 sanitize_ddc_pin(dev_priv, port);
>>>         }
>>>
>>
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx