Re: [PATCH 2/2] drm/i915: Silence smatch for cmdparser

Chris Wilson
2017-01-25T09:04:25Z

On Fri, Jan 20, 2017 at 09:45:30PM +0000, Chris Wilson wrote:
> drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue
> drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue
> drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue
> drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue
> drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue
> drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue
> drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue
> drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue
> drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue
> drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue
> drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue
> drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue
>
> If we move the shift into each case not only do we kill the warning from
> smatch, but we shrink the code slightly:
>
> text data bss dec hex filename
> 1267906 20587 3168 1291661 13b58d before
> 1267890 20587 3168 1291645 13b57d after
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Any takers for this pair?
-Chris

--
Chris Wilson, Intel Open Source Technology Centre