From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915/kbl: Fix DMC load on Kabylake.
Date: Wed, 09 Dec 2015 17:34:58 +0200 [thread overview]
Message-ID: <87y4d3vdnh.fsf@intel.com> (raw)
In-Reply-To: <1449674279-17290-1-git-send-email-rodrigo.vivi@intel.com>
On Wed, 09 Dec 2015, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> Kabylake A0 is based on Skylake H0.
>
> v2: Don't assume revid+7 and only load the one we are sure about.
>
> v3: Rebase on top of latest changes.
>
> v4: Accept cleaner solution from Jani with kbl_stepping_info
> starting on H0 instead of put a hack on revid.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_csr.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 6c6a669..9bb63a8 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -166,6 +166,14 @@ struct stepping_info {
> char substepping;
> };
>
> +/*
> + * Kabylake derivated from Skylake H0, so SKL H0
> + * is the right firmware for KBL A0 (revid 0).
> + */
> +static const struct stepping_info kbl_stepping_info[] = {
> + {'H', '0'}, {'I', '0'}
> +};
> +
> static const struct stepping_info skl_stepping_info[] = {
> {'A', '0'}, {'B', '0'}, {'C', '0'},
> {'D', '0'}, {'E', '0'}, {'F', '0'},
> @@ -182,7 +190,10 @@ static const struct stepping_info *intel_get_stepping_info(struct drm_device *de
> const struct stepping_info *si;
> unsigned int size;
>
> - if (IS_SKYLAKE(dev)) {
> + if (IS_KABYLAKE(dev)) {
> + size = ARRAY_SIZE(kbl_stepping_info);
> + si = kbl_stepping_info;
> + } else if (IS_SKYLAKE(dev)) {
> size = ARRAY_SIZE(skl_stepping_info);
> si = skl_stepping_info;
> } else if (IS_BROXTON(dev)) {
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-09 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 1:18 [PATCH] drm/i915/kbl: Fix DMC load on Kabylake Rodrigo Vivi
2015-12-09 11:16 ` Jani Nikula
2015-12-09 15:17 ` Rodrigo Vivi
2015-12-09 15:34 ` Jani Nikula [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-10-27 17:14 [PATCH 6/6] " Rodrigo Vivi
2015-10-29 17:20 ` [PATCH] " Rodrigo Vivi
2015-10-29 17:58 ` kbuild test robot
2015-10-29 18:05 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4d3vdnh.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox