From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove redundant check in i915_gem_obj_to_vma
Date: Thu, 12 Nov 2015 16:19:01 +0200 [thread overview]
Message-ID: <87y4e3fgh6.fsf@intel.com> (raw)
In-Reply-To: <20151112122938.GK6247@nuc-i3427.alporthouse.com>
On Thu, 12 Nov 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, Nov 12, 2015 at 11:59:55AM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> No need to verify VMA belongs to GGTT since:
>>
>> 1. The function must return a normal VMA belonging to passed in VM.
>> 2. There can only be one normal VMA for any VM.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by Chris Wilson <chris@chris-wilson.co.uk>
Pushed to drm-intel-next-queued, thanks for the patch and review.
BR,
Jani.
>
>> Maybe now even a candidate for making a static inline?
>
> No. After tracking vma, i915_gem_obj_to_vma() is moved off the hotpaths
> and mostly used for the first lookup by an execbuffer, context creation,
> modesetting and debug code.
> -Chris
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-12 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 11:59 [PATCH] drm/i915: Remove redundant check in i915_gem_obj_to_vma Tvrtko Ursulin
2015-11-12 12:29 ` Chris Wilson
2015-11-12 14:19 ` Jani Nikula [this message]
2015-11-13 12:36 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4e3fgh6.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox