From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Bob Paauwe <bob.j.paauwe@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/bxt: Broxton doesn't use gen9 scaling for rps frequencies.
Date: Tue, 10 Nov 2015 11:04:22 +0200 [thread overview]
Message-ID: <87y4e6ns2x.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <1447111722-5626-1-git-send-email-bob.j.paauwe@intel.com>
Bob Paauwe <bob.j.paauwe@intel.com> writes:
> Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92768
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 647c0ff..fc5097f 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -7138,7 +7138,7 @@ static int chv_freq_opcode(struct drm_i915_private *dev_priv, int val)
>
> int intel_gpu_freq(struct drm_i915_private *dev_priv, int val)
> {
> - if (IS_GEN9(dev_priv->dev))
> + if (IS_GEN9(dev_priv->dev) && !IS_BROXTON(dev_priv->dev))
> return (val * GT_FREQUENCY_MULTIPLIER) /
> GEN9_FREQ_SCALER;
Documentation disagrees with this patch. The units are 16.67Mhz
thus we should use 50/3.
-Mika
> else if (IS_CHERRYVIEW(dev_priv->dev))
> return chv_gpu_freq(dev_priv, val);
> @@ -7150,7 +7150,7 @@ int intel_gpu_freq(struct drm_i915_private *dev_priv, int val)
>
> int intel_freq_opcode(struct drm_i915_private *dev_priv, int val)
> {
> - if (IS_GEN9(dev_priv->dev))
> + if (IS_GEN9(dev_priv->dev) && !IS_BROXTON(dev_priv->dev))
> return (val * GEN9_FREQ_SCALER) / GT_FREQUENCY_MULTIPLIER;
> else if (IS_CHERRYVIEW(dev_priv->dev))
> return chv_freq_opcode(dev_priv, val);
> --
> 2.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-10 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 23:28 [PATCH] drm/i915/bxt: Broxton doesn't use gen9 scaling for rps frequencies Bob Paauwe
2015-11-10 9:04 ` Mika Kuoppala [this message]
2015-11-11 21:36 ` Bob Paauwe
2015-11-12 8:35 ` Imre Deak
2015-11-12 18:14 ` Bob Paauwe
2015-11-13 15:21 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4e6ns2x.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=bob.j.paauwe@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox