From: Jani Nikula <jani.nikula@intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: handle port E in cpt_digital_port_connected
Date: Mon, 21 Sep 2015 12:51:49 +0300 [thread overview]
Message-ID: <87y4g085hm.fsf@intel.com> (raw)
In-Reply-To: <8737y8w2w8.fsf@gaia.fi.intel.com>
On Mon, 21 Sep 2015, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
> Jani Nikula <jani.nikula@intel.com> writes:
>
>> SKL port E handling was added in
>>
>> commit 26951caf55d73ceb1967b0bf12f6d0b96853508e
>> Author: Xiong Zhang <xiong.y.zhang@intel.com>
>> Date: Mon Aug 17 15:55:50 2015 +0800
>>
>> drm/i915/skl: enable DDI-E hotplug
>>
>> but the whole function was moved in a another branch in
>>
>> commit b93433ccf64846820b9448f5ff5dd4348b58a8ed
>> Author: Jani Nikula <jani.nikula@intel.com>
>> Date: Thu Aug 20 10:47:36 2015 +0300
>>
>> drm/i915: move ibx_digital_port_connected to intel_dp.c
>>
>> and the addition was lost at some backmerge that I was unable to
>> identify. Put it back in.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
Thanks, pushed to drm-intel-next-queued.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/intel_dp.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index a6872508adec..77e4115fc847 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -4583,6 +4583,9 @@ static bool cpt_digital_port_connected(struct drm_i915_private *dev_priv,
>> case PORT_D:
>> bit = SDE_PORTD_HOTPLUG_CPT;
>> break;
>> + case PORT_E:
>> + bit = SDE_PORTE_HOTPLUG_SPT;
>> + break;
>> default:
>> MISSING_CASE(port->port);
>> return false;
>> --
>> 2.1.4
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-09-21 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 12:54 [PATCH] drm/i915/skl: handle port E in cpt_digital_port_connected Jani Nikula
2015-09-18 14:23 ` Jani Nikula
2015-09-21 9:13 ` Mika Kuoppala
2015-09-21 9:51 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4g085hm.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox