From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11B92C3DA6F for ; Fri, 25 Aug 2023 06:03:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A1C410E5FC; Fri, 25 Aug 2023 06:03:39 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B1C710E5FC for ; Fri, 25 Aug 2023 06:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692943418; x=1724479418; h=from:to:subject:in-reply-to:references:date:message-id: mime-version:content-transfer-encoding; bh=o+tAxqG6OUpyfy9SZw3EJBHA8zUtz8efNj/9LoVkgmw=; b=aSNuXe6ju9x/UuHNcqvZ9pg0CGOzj47Vpl8nuUSAwTuKZ63oZpEpdR3t fwdmv5Ba1+rDwkZkklPPa3TROsnJRBDCzGeEhr8qdAlbG/rCz2Ig15dB2 BuXnkpqXaDrEmx3CBXndWCvi+MSPGYgYD9YEo99ZR1ajcvwrNd+mKGKfd qzTBsEg9/sz4d9wV88cTp2pJFvLx9tjPogR2BaB5S4D2HbcG/X9Hx/1Cg HuhJO8RWt04MO3SZYAIV7dezXndZNRzFMjlgY28eZgsrZ3f1cybuUGw1k JIQTBZgsaxUgZGOCJUZtvvK2t9L6ZoNV7DYIkvuzgVft2PI4btkQ+t0Zq w==; X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="373511979" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="373511979" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2023 23:03:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="802847520" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="802847520" Received: from ogbrugge-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.56.56]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2023 23:03:35 -0700 From: Jani Nikula To: "Hogander, Jouni" , "intel-gfx@lists.freedesktop.org" In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230818112758.3586545-1-jani.nikula@intel.com> Date: Fri, 25 Aug 2023 09:03:32 +0300 Message-ID: <87zg2f3bgr.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH] drm/i915/vma: constify unbind_fence_ops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 23 Aug 2023, "Hogander, Jouni" wrote: > On Fri, 2023-08-18 at 14:27 +0300, Jani Nikula wrote: >> unbind_fence_ops can be const and placed in rodata. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Jouni H=C3=B6gander Thanks, pushed to din. BR, Jani. > >> --- >> drivers/gpu/drm/i915/i915_vma_resource.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_vma_resource.c >> b/drivers/gpu/drm/i915/i915_vma_resource.c >> index 6ba7a7feceba..53d619ef0c3d 100644 >> --- a/drivers/gpu/drm/i915/i915_vma_resource.c >> +++ b/drivers/gpu/drm/i915/i915_vma_resource.c >> @@ -94,7 +94,7 @@ static void unbind_fence_release(struct dma_fence >> *fence) >> call_rcu(&fence->rcu, unbind_fence_free_rcu); >> } >> >> -static struct dma_fence_ops unbind_fence_ops =3D { >> +static const struct dma_fence_ops unbind_fence_ops =3D { >> .get_driver_name =3D get_driver_name, >> .get_timeline_name =3D get_timeline_name, >> .release =3D unbind_fence_release, > --=20 Jani Nikula, Intel Open Source Graphics Center