From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AF3AEB64DA for ; Sat, 8 Jul 2023 19:36:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F94B10E025; Sat, 8 Jul 2023 19:36:18 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC37C10E025; Sat, 8 Jul 2023 19:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688844976; x=1720380976; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=k2/xZVWFj9+xgWTJyc1xnz6QEwq8Bw/OvuLA2qksd0o=; b=ZbUP871N0/q3i+GS+dZObtMNd6L1TO3/TmFf1zabDh+qgP0TI3Zd16Ts 4WfhoS7dK7x5gc+Gk13x1D3sSY1tzKo5p4i5c/GjPK+PgqPd6Xoon1lb4 yt1urz2BrooxvA7DDXF5BP0uM6XUk96c6g5+FEd0tftXaFjw4N2Wc1oZC 7k1XjnzdycGE0qeSv2mftdEdVT7l2WO/zM27QU27G2jf7Q3YHL8ahsBUW yBcDlzW9h1wXgtljgQPVW3BG9Y8HzO+F4xsEJhB+vqNRCoP4QnZikDXVU UOgHIeGViiOWDXYMPZIbPpTxyoe9WunAjM0mlu0S/B+9NYTqqur1XhWHJ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10765"; a="430163251" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="430163251" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2023 12:36:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10765"; a="755540884" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="755540884" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.153.202]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2023 12:36:15 -0700 Date: Sat, 08 Jul 2023 12:36:15 -0700 Message-ID: <87zg46gpqo.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Vinay Belgaumkar In-Reply-To: <20230707232359.81039-1-vinay.belgaumkar@intel.com> References: <20230707232359.81039-1-vinay.belgaumkar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH i-g-t] i915_pm_freq_api: Add some debug to tests X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 07 Jul 2023 16:23:59 -0700, Vinay Belgaumkar wrote: > > Some subtests seem to be failing in CI, use igt_assert_(lt/eq) which > print the values being compared and some additional debug as well. > > Signed-off-by: Vinay Belgaumkar > --- > tests/i915/i915_pm_freq_api.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c > index 522abee35..cdb2e70ca 100644 > --- a/tests/i915/i915_pm_freq_api.c > +++ b/tests/i915/i915_pm_freq_api.c > @@ -55,6 +55,7 @@ static void test_freq_basic_api(int dirfd, int gt) > rpn = get_freq(dirfd, RPS_RPn_FREQ_MHZ); > rp0 = get_freq(dirfd, RPS_RP0_FREQ_MHZ); > rpe = get_freq(dirfd, RPS_RP1_FREQ_MHZ); > + igt_debug("RPn: %d, RPe: %d, RP0: %d", rpn, rpe, rp0); Print gt here too. > > /* > * Negative bound tests > @@ -90,21 +91,18 @@ static void test_reset(int i915, int dirfd, int gt, int count) > int fd; > > for (int i = 0; i < count; i++) { > - igt_assert_f(set_freq(dirfd, RPS_MIN_FREQ_MHZ, rpn) > 0, > - "Failed after %d good cycles\n", i); > - igt_assert_f(set_freq(dirfd, RPS_MAX_FREQ_MHZ, rpn) > 0, > - "Failed after %d good cycles\n", i); > + igt_debug("Running cycle: %d", i); > + igt_assert(set_freq(dirfd, RPS_MIN_FREQ_MHZ, rpn) > 0); > + igt_assert(set_freq(dirfd, RPS_MAX_FREQ_MHZ, rpn) > 0); > usleep(ACT_FREQ_LATENCY_US); > - igt_assert_f(get_freq(dirfd, RPS_CUR_FREQ_MHZ) == rpn, > - "Failed after %d good cycles\n", i); > + igt_assert_eq(get_freq(dirfd, RPS_CUR_FREQ_MHZ), rpn); > > /* Manually trigger a GT reset */ > fd = igt_debugfs_gt_open(i915, gt, "reset", O_WRONLY); > igt_require(fd >= 0); > igt_ignore_warn(write(fd, "1\n", 2)); > > - igt_assert_f(get_freq(dirfd, RPS_CUR_FREQ_MHZ) == rpn, > - "Failed after %d good cycles\n", i); > + igt_assert_eq(get_freq(dirfd, RPS_CUR_FREQ_MHZ), rpn); Probably ok but why the changes in this loop? > } > close(fd); > } > @@ -116,13 +114,13 @@ static void test_suspend(int i915, int dirfd, int gt) > igt_assert(set_freq(dirfd, RPS_MIN_FREQ_MHZ, rpn) > 0); > igt_assert(set_freq(dirfd, RPS_MAX_FREQ_MHZ, rpn) > 0); > usleep(ACT_FREQ_LATENCY_US); > - igt_assert(get_freq(dirfd, RPS_CUR_FREQ_MHZ) == rpn); > + igt_assert_eq(get_freq(dirfd, RPS_CUR_FREQ_MHZ), rpn); > > /* Manually trigger a suspend */ > igt_system_suspend_autoresume(SUSPEND_STATE_S3, > SUSPEND_TEST_NONE); > > - igt_assert(get_freq(dirfd, RPS_CUR_FREQ_MHZ) == rpn); > + igt_assert_eq(get_freq(dirfd, RPS_CUR_FREQ_MHZ), rpn); > } > > int i915 = -1; > -- > 2.38.1 >