From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF54FC4332F for ; Fri, 16 Dec 2022 16:50:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 191ED10E0AC; Fri, 16 Dec 2022 16:50:05 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8FB410E05A; Fri, 16 Dec 2022 16:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671209401; x=1702745401; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=icRczXlqHzD+ae5wgkamu3FNINHiBF4DVSht/FvMcyA=; b=FruY/n6rEQ8lYKQRWyxulK8vNtfeJvk14+CP86t6hq4Fkl31GulIW1Hx ZvfQlbeG3VdY9LD0VRRa7XPhUSMFcNhx13d/Epv3TBspwAY5hu5LRFim6 nsbyIGJEEcBd8U/zczwK2b3IeK5GlqoCXIywokYSCSfwZoJX0pyLX+bfR gr6dXW24GiepThOa3gIQOS6z1O3YmKmbdeEsNoscUWFu9GKXYLzD64JJB 3n93CPpJCdpAjT5b5JHU729Nl6wZPVeZRXfBllMlVGylbVlPZUrkMkPd6 3tFjHJl4oS4kzll4gCS0+dV/7LaZJK32X8uExCn5jNvUzzAr6uAgfFCft A==; X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="320178311" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="320178311" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 08:50:00 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="895294387" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="895294387" Received: from fbielich-mobl3.ger.corp.intel.com (HELO localhost) ([10.252.62.38]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 08:49:57 -0800 From: Jani Nikula To: imre.deak@intel.com In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20221214184258.2869417-1-imre.deak@intel.com> <1ade43347769118c82f1b68bd8b51172a1012a37.camel@redhat.com> <875yebuy68.fsf@intel.com> Date: Fri, 16 Dec 2022 18:49:54 +0200 Message-ID: <87zgbnthsd.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 1/3] drm/display/dp_mst: Fix down/up message handling after sink disconnect X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Maxime Ripard , dri-devel@lists.freedesktop.org, Thomas Zimmermann , stable@vger.kernel.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 16 Dec 2022, Imre Deak wrote: > On Fri, Dec 16, 2022 at 06:10:39PM +0200, Jani Nikula wrote: >> On Fri, 16 Dec 2022, Imre Deak wrote: >> > On Wed, Dec 14, 2022 at 04:41:42PM -0500, Lyude Paul wrote: >> >> For the whole series: >> >> >> >> Reviewed-by: Lyude Paul >> > >> > Thanks for the review, pushed it to drm-misc-next. >> >> Hmm, with the drm-misc *not* cherry-picking patches from drm-misc-next >> to drm-misc-fixes, these will only get backported to stable kernels >> after they hit Linus' tree in the next (as opposed to current) merge >> window after a full development cycle. Wonder if they should be >> expedited. > > Ok, it should've been pushed to -fixes then, will do that next time. > Yes, I think sending them already before the next merge window would be > good. Cc: drm-misc maintainers, I think this is for you to figure out. BR, Jani. > >> >> BR, >> Jani. >> >> > >> >> Thanks! >> >> >> >> On Wed, 2022-12-14 at 20:42 +0200, Imre Deak wrote: >> >> > If the sink gets disconnected during receiving a multi-packet DP MST AUX >> >> > down-reply/up-request sideband message, the state keeping track of which >> >> > packets have been received already is not reset. This results in a failed >> >> > sanity check for the subsequent message packet received after a sink is >> >> > reconnected (due to the pending message not yet completed with an >> >> > end-of-message-transfer packet), indicated by the >> >> > >> >> > "sideband msg set header failed" >> >> > >> >> > error. >> >> > >> >> > Fix the above by resetting the up/down message reception state after a >> >> > disconnect event. >> >> > >> >> > Cc: Lyude Paul >> >> > Cc: # v3.17+ >> >> > Signed-off-by: Imre Deak >> >> > --- >> >> > drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 +++ >> >> > 1 file changed, 3 insertions(+) >> >> > >> >> > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c >> >> > index 51a46689cda70..90819fff2c9ba 100644 >> >> > --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c >> >> > +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c >> >> > @@ -3641,6 +3641,9 @@ int drm_dp_mst_topology_mgr_set_mst(struct drm_dp_mst_topology_mgr *mgr, bool ms >> >> > drm_dp_dpcd_writeb(mgr->aux, DP_MSTM_CTRL, 0); >> >> > ret = 0; >> >> > mgr->payload_id_table_cleared = false; >> >> > + >> >> > + memset(&mgr->down_rep_recv, 0, sizeof(mgr->down_rep_recv)); >> >> > + memset(&mgr->up_req_recv, 0, sizeof(mgr->up_req_recv)); >> >> > } >> >> > >> >> > out_unlock: >> >> >> >> -- >> >> Cheers, >> >> Lyude Paul (she/her) >> >> Software Engineer at Red Hat >> >> >> >> -- >> Jani Nikula, Intel Open Source Graphics Center -- Jani Nikula, Intel Open Source Graphics Center