From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09431C43334 for ; Tue, 7 Jun 2022 22:25:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2307610E163; Tue, 7 Jun 2022 22:25:52 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 156CD10E100; Tue, 7 Jun 2022 22:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654640751; x=1686176751; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Jsw+z9J5gOe/PXAgV4ZrgCokfetsJMNLa3T8bfW/V9c=; b=DqVr9jRFclD4SmY8Tfe6M4pL9D/0FxtiMkw2hgDnTBBqxhjAuxpdov9P JVvXH8auZOcIkvBTBkNAu/rPFpDtWfCwpewcGIWteXl8ZG4MyFjVA/TiH R7bEWV6SUEiKZ+N/mFTBosts4oa0wBfqyxIqf77Cs+Y5Hp4UlKHSPHNj+ sixAfBUMyYh43rW9oUSorTN8ILvTgyNBPkCocV/j6WbyWK8vyQ/b4pQfI MaBhgq7R24T+SZXukdTk+nM5GHR8ulNXAnXQtlhf5iMs3OE08h8jXpV4B uDyfA9kSW4EJrdvQA/IlXlywOfixI67YWhCKXvKxuYjIIdYMtPUF6KWiI g==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="338408088" X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="338408088" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 15:25:25 -0700 X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="670225417" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.186.67]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 15:25:25 -0700 Date: Tue, 07 Jun 2022 15:25:24 -0700 Message-ID: <87zgiojeln.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: John Harrison In-Reply-To: <6fd4a9fa-5e02-a34f-7c8e-68c8f747e4fb@intel.com> References: <20220607215103.3342267-1-John.C.Harrison@Intel.com> <871qw0ktzw.wl-ashutosh.dixit@intel.com> <6fd4a9fa-5e02-a34f-7c8e-68c8f747e4fb@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Use drm_err instead of pr_err X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel-GFX@Lists.FreeDesktop.Org, DRI-Devel@Lists.FreeDesktop.Org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 07 Jun 2022 15:23:17 -0700, John Harrison wrote: > > On 6/7/2022 15:07, Dixit, Ashutosh wrote: > > On Tue, 07 Jun 2022 14:51:03 -0700, John.C.Harrison@Intel.com wrote: > >> From: John Harrison > >> > >> Don't use pr_err in places where we have access to a struct_drm. > > Seem to be many more pr_err's in selftests. Is there a reason why drm_err's > > cannot be used in selftests (especially those using an i915 device)? > > Thanks. > I figured I'd start small and just do the gt/uc ones to being with as those > are the ones that affect me. > > It sounds like the only reason to use pr_err is in the mock selftests where > there is no easy access to a DRM structure. For everything else, there is > no reason that I am aware of. Fair enough: Reviewed-by: Ashutosh Dixit