From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B3CAC433F5 for ; Tue, 26 Apr 2022 00:43:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9271510EBBF; Tue, 26 Apr 2022 00:43:17 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A18210EF18 for ; Tue, 26 Apr 2022 00:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650933796; x=1682469796; h=date:message-id:from:to:subject:in-reply-to:references: mime-version; bh=lqlmT2Uj/rEvktwCuhrE+8qu+V3th30MaD/jhwJLEek=; b=YlSlfTO94ITHZPgg6xoJL3eBxYHxxAWqUe4knzGmYzLNgo91FZdIjqR/ mM7QcDLgWod7jeRyzynW3A3BLTxa6XKd8j1CcTVxwmxfDKtW8pDo/zOQ7 gXl2OnPbt186ylvssd08Kr9mDWqn+Q9kMZ3NpqMT4h7HQisc1u2TkrhnW 5YUehBmgp6sSVoQqbnjZfABBkCE2K8JFgPhlwb3V5sLWLKQ6roPXGdnev hw7xyTxpRQ9ZF/M4hn0ESK6BnWpynVPrY3XltUJcTnxx9dudF14Zj78IP PM2+95iSB8Ub0BVS3cA9uN4sjpMKGySHTlATwJlOswx5aKZgwiicRRbxr Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10328"; a="252777118" X-IronPort-AV: E=Sophos;i="5.90,289,1643702400"; d="scan'208";a="252777118" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2022 17:43:16 -0700 X-IronPort-AV: E=Sophos;i="5.90,289,1643702400"; d="scan'208";a="595484806" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.195.217]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2022 17:43:15 -0700 Date: Mon, 25 Apr 2022 17:43:15 -0700 Message-ID: <87zgk865ek.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kamil Konieczny , intel-gfx@lists.freedesktop.org, Rodrigo Vivi , Joonas Lahtinen In-Reply-To: References: <2a11577139f82f50058a2167404b82fa7c80cb39.1649871650.git.ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 5/8] drm/i915/gt: Add media RP0/RPn to per-gt sysfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 25 Apr 2022 02:39:42 -0700, Kamil Konieczny wrote: > > Hi Ashutosh, Hi Kamil, > On 2022-04-13 at 11:11:06 -0700, Ashutosh Dixit wrote: > > Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt > > sysfs. This patch adds the following files to gt/gtN sysfs: > > * media_RP0_freq_mhz > > * media_RPn_freq_mhz > --------- ^ > Can we keep it in lowercase ? So it will be like: > media_rp0_freq_mhz > media_rpn_freq_mhz > > Or is it merged with capital letters at other sysfs path ? Unfortunately that is the case as we can see below: $ ls -l /sys/class/drm/card0/gt/gt0/rps* -r--r--r-- 1 root root 4096 Jan 20 19:55 rps_RP0_freq_mhz -r--r--r-- 1 root root 4096 Jan 20 19:55 rps_RP1_freq_mhz -r--r--r-- 1 root root 4096 Jan 20 19:55 rps_RPn_freq_mhz We could have have discussed it before the other RPS patches were merged but I think at this point we'd need to maintain consistency with the previous naming scheme (the frequencies are actually known as RP0/RPn). Thanks. -- Ashutosh