From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Fix off-by-one in looking up icl sseu slice Date: Wed, 29 May 2019 17:23:20 +0300 Message-ID: <87zhn549wn.fsf@intel.com> References: <20190528200655.11605-1-chris@chris-wilson.co.uk> <87d0k1oed8.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 66E406E32C for ; Wed, 29 May 2019 14:20:10 +0000 (UTC) In-Reply-To: <87d0k1oed8.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyOSBNYXkgMjAxOSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVs LmNvbT4gd3JvdGU6Cj4gT24gVHVlLCAyOCBNYXkgMjAxOSwgQ2hyaXMgV2lsc29uIDxjaHJpc0Bj aHJpcy13aWxzb24uY28udWs+IHdyb3RlOgo+PiBXZSB3YW50IHRoZSBpbmRleCBjb3JyZXNwb25k aW5nIHRvIHRoZSBzZXQgYml0IGJ1dCBmbHMoKSByZXR1cm5zIHRoZQo+PiAxLWluZGV4IHZhbHVl Lgo+Pgo+PiBPdGhlcndpc2UsIHdlIHRyaWdnZXIgdGhlIHNhbml0eWNoZWNrCj4+IAlpbnRlbF9z c2V1X2dldF9zdWJzbGljZXM6NDYgR0VNX0JVR19PTihzbGljZSA+PSBzc2V1LT5tYXhfc2xpY2Vz KQo+PiB3aGVuIHdlIGxvb2sgdXAgdGhlIGludmFsaWQgc2xpY2UuCj4+Cj4+IFRoZSBvbmx5IHJl bWFpbmluZyBxdWVzdGlvbiB0aGVuIGlzIGp1c3QgaG93IHJlbGlhYmxlIHRoZSByZXN0IG9mCj4+ IGludGVsX2NhbGN1bGF0ZV9tY3Jfc19zc19zZWxlY3QoKSBpcyAtLSBob3cgbWFueSBtb3JlIG9m IHRob3NlIGZscygpIGFyZQo+PiBhbHNvIG9mZi1ieS1vbmUuCj4+Cj4+IEZpeGVzOiAxYWMxNTll MjNjMmMgKCJkcm0vaTkxNTogRXhwYW5kIHN1YnNsaWNlIG1hc2siKQo+Cj4gSSBzZW50IGEgcmV2 ZXJ0IG9mIHRoaXMgY29tbWl0IFsxXSBmb3IgcmVhc29ucyBleHBsYWluZWQgaW4gdGhlIGNvbW1p dAo+IG1lc3NhZ2UuCgpJJ3ZlIGdvbmUgYWhlYWQgYW5kIHB1c2hlZCB0aGUgcmV2ZXJ0LgoKV2Ug Y2FuIG5vdyBjYWxtbHkgZ2V0IGJhY2sgdG8gdGhlIGRyYXdpbmcgYm9hcmQsIGFuZCBnZXQgdGhp cyBzb3J0ZWQKb3V0LgoKQlIsCkphbmkuCgoKPgo+IEJSLAo+IEphbmkuCj4KPgo+IFsxXSBodHRw Oi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC9tc2dpZC8yMDE5MDUyOTA4MjE1MC4z MTUyNi0xLWphbmkubmlrdWxhQGludGVsLmNvbQo+Cj4KPj4gRml4ZXM6IDFlNDBkNGFlYTU3YiAo ImRybS9pOTE1L2NubDogSW1wbGVtZW50IFdhUHJvZ3JhbU1nc3JGb3JDb3JyZWN0U2xpY2VTcGVj aWZpY01taW9SZWFkcyIpCj4+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+PiBDYzogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5j ZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPj4gQ2M6IExpb25lbCBMYW5kd2VybGluIDxsaW9uZWwu Zy5sYW5kd2VybGluQGludGVsLmNvbT4KPj4gQ2M6IFN0dWFydCBTdW1tZXJzIDxzdHVhcnQuc3Vt bWVyc0BpbnRlbC5jb20+Cj4+IENjOiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50 ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3dvcmthcm91 bmRzLmMgfCAyICstCj4+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3dv cmthcm91bmRzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF93b3JrYXJvdW5kcy5j Cj4+IGluZGV4IGZiYzg1MzA4NTgwOS4uNDg1Y2QxYzhlY2M0IDEwMDY0NAo+PiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF93b3JrYXJvdW5kcy5jCj4+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2d0L2ludGVsX3dvcmthcm91bmRzLmMKPj4gQEAgLTc4MSw3ICs3ODEsNyBA QCB3YV9pbml0X21jcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwgc3RydWN0IGk5MTVf d2FfbGlzdCAqd2FsKQo+PiAgCQkgKiByZWFkIEZVU0UzIGZvciBlbmFibGVkIEwzIEJhbmsgSURz LCBpZiBMMyBCYW5rIG1hdGNoZXMKPj4gIAkJICogZW5hYmxlZCBzdWJzbGljZSwgbm8gbmVlZCB0 byByZWRpcmVjdCBNQ1IgcGFja2V0Cj4+ICAJCSAqLwo+PiAtCQl1MzIgc2xpY2UgPSBmbHMoc3Nl dS0+c2xpY2VfbWFzayk7Cj4+ICsJCXUzMiBzbGljZSA9IF9fZmxzKHNzZXUtPnNsaWNlX21hc2sp Owo+PiAgCQl1MzIgZnVzZTMgPQo+PiAgCQkJaW50ZWxfdW5jb3JlX3JlYWQoJmk5MTUtPnVuY29y ZSwgR0VOMTBfTUlSUk9SX0ZVU0UzKTsKPj4gIAkJdTMyIHNzX21hc2sgPSBpbnRlbF9zc2V1X2dl dF9zdWJzbGljZXMoc3NldSwgc2xpY2UpOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNv dXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4