From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915: Don't claim an unstarted request was guilty Date: Fri, 08 Feb 2019 17:31:54 +0200 Message-ID: <87zhr61el1.fsf@gaia.fi.intel.com> References: <20190207071829.5574-8-chris@chris-wilson.co.uk> <20190207074137.11189-1-chris@chris-wilson.co.uk> <878syq2v7y.fsf@gaia.fi.intel.com> <154963787506.3378.11368751484623076898@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 577926EE21 for ; Fri, 8 Feb 2019 15:32:05 +0000 (UTC) In-Reply-To: <154963787506.3378.11368751484623076898@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu ZyBNaWthIEt1b3BwYWxhICgyMDE5LTAyLTA4IDE0OjQ3OjEzKQo+PiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4gd3JpdGVzOgo+PiAKPj4gPiBJZiB3ZSBoYXZlbid0IGV2 ZW4gYmVndW4gZXhlY3V0aW5nIHRoZSBwYXlsb2FkIG9mIHRoZSBzdGFsbGVkIHJlcXVlc3QsCj4+ ID4gdGhlbiB3ZSBzaG91bGQgbm90IGNsYWltIHRoYXQgaXRzIHVzZXJzcGFjZSBjb250ZXh0IHdh cyBndWlsdHkgb2YKPj4gPiBzdWJtaXR0aW5nIGEgaGFuZ2luZyBiYXRjaC4KPj4gPgo+PiA+IHYy OiBDaGVjayBmb3IgY29udGV4dCBjb3JydXB0aW9uIGJlZm9yZSB0cnlpbmcgdG8gcmVzdGFydC4K Pj4gPiB2MzogUHJlc2VydmUgc2VtYXBob3JlcyBvbiBza2lwcGluZyByZXF1ZXN0cyAobmVlZCB0 byBrZWVwIHRoZSB0aW1lbGluZXMKPj4gPiBpbnRhY3QpLgo+PiA+Cj4+ID4gU2lnbmVkLW9mZi1i eTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+ID4gLS0tCj4+ID4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICAgICAgICB8IDQyICsrKysr KysrKysrKysrKysrLS0KPj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2lndF9z cGlubmVyLmMgIHwgIDkgKysrLQo+PiA+ICAuLi4vZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRl bF9oYW5nY2hlY2suYyAgfCAgNiArKysKPj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCA1MyBpbnNlcnRp b25zKCspLCA0IGRlbGV0aW9ucygtKQo+PiA+Cj4+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMK Pj4gPiBpbmRleCA1ZTk4ZmQ3OWJkOWQuLmUzMTM0YTYzNTkyNiAxMDA2NDQKPj4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jCj4+ID4gQEAgLTEzODcsNiArMTM4NywxMCBAQCBzdGF0aWMgaW50 IGdlbjhfZW1pdF9pbml0X2JyZWFkY3J1bWIoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4+ID4g ICAgICAgKmNzKysgPSBycS0+ZmVuY2Uuc2Vxbm8gLSAxOwo+PiA+ICAKPj4gPiAgICAgICBpbnRl bF9yaW5nX2FkdmFuY2UocnEsIGNzKTsKPj4gPiArCj4+ID4gKyAgICAgLyogUmVjb3JkIHRoZSB1 cGRhdGVkIHBvc2l0aW9uIG9mIHRoZSByZXF1ZXN0J3MgcGF5bG9hZCAqLwo+PiA+ICsgICAgIHJx LT5pbmZpeCA9IGludGVsX3Jpbmdfb2Zmc2V0KHJxLCBjcyk7Cj4+ID4gKwo+PiA+ICAgICAgIHJl dHVybiAwOwo+PiA+ICB9Cj4+ID4gIAo+PiA+IEBAIC0xODc4LDYgKzE4ODIsMjMgQEAgc3RhdGlj IHZvaWQgZXhlY2xpc3RzX3Jlc2V0X3ByZXBhcmUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5n aW5lKQo+PiA+ICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmVuZ2luZS0+dGltZWxpbmUu bG9jaywgZmxhZ3MpOwo+PiA+ICB9Cj4+ID4gIAo+PiA+ICtzdGF0aWMgYm9vbCBscmNfcmVnc19v ayhjb25zdCBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSkKPj4gPiArewo+PiA+ICsgICAgIGNvbnN0 IHN0cnVjdCBpbnRlbF9yaW5nICpyaW5nID0gcnEtPnJpbmc7Cj4+ID4gKyAgICAgY29uc3QgdTMy ICpyZWdzID0gcnEtPmh3X2NvbnRleHQtPmxyY19yZWdfc3RhdGU7Cj4+ID4gKwo+PiA+ICsgICAg IC8qIFF1aWNrIHNwb3QgY2hlY2sgZm9yIHRoZSBjb21tb24gc2lnbnMgb2YgY29udGV4dCBjb3Jy dXB0aW9uICovCj4+ID4gKwo+PiA+ICsgICAgIGlmIChyZWdzW0NUWF9SSU5HX0JVRkZFUl9DT05U Uk9MICsgMV0gIT0KPj4gPiArICAgICAgICAgKFJJTkdfQ1RMX1NJWkUocmluZy0+c2l6ZSkgfCBS SU5HX1ZBTElEKSkKPj4gPiArICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPj4gCj4+IFlvdSBi ZWVuIG5vdGljaW5nIHRoaXMgd2l0aCBjdHggY29ycnVwdGlvbj8gV2VsbCBub3cKPj4gdGhpbmtp bmcgYWJvdXQgaXQsIHdlIGhhdmUgaGFkIHJlcG9ydHMgd2hlcmUgb24gaW5pdCwKPj4gb24gc29t ZSB0cm91YmxlLCB0aGUgdmFsaWQgdmFuaXNoZXMuCj4KPiBZZXMsIGl0J3Mgd2h5IHdlJ3ZlIGJl ZW4gY29weWluZyB0aGUgZGVmYXVsdCBjb250ZXh0IG92ZXIgZ3VpbHR5IGZvciBhCj4gbG9uZyB0 aW1lIChwcmV0dHkgbXVjaCBzaW5jZSBsaXZlX2hhbmdjaGVjayBiZWNhbWUgYSB0aGluZyBpaXJj KS4KPgo+PiA+ICsKPj4gPiArICAgICBpZiAocmVnc1tDVFhfUklOR19CVUZGRVJfU1RBUlQgKyAx XSAhPSBpOTE1X2dndHRfb2Zmc2V0KHJpbmctPnZtYSkpCj4+ID4gKyAgICAgICAgICAgICByZXR1 cm4gZmFsc2U7Cj4+ID4gKwo+PiAKPj4gU2VlbiB0aGlzIG9uIGJ1Z3ppbGxhIHJlcG9ydHMgdG9v LiBBcmUgdGhlcmUgbW9yZQo+PiBpbiB5b3VyIHNsZWV2ZSBvciBpcyB0aGlzIGEgY29tcHJvbWlz ZSBvbiBjb21wbGV4aXR5Cj4+IGFuZCBwZXJmb3JtYW5jZT8gQ2hlY2tpbmcgb24gYSBzYW5lIGFj dHVhbCBoZWFkIHRvbz8KPgo+IE5vLCBJIGNhbid0IHJlbWVtYmVyIHNlZWluZyB0aGlzLCBqdXN0 IGxvb3NpbmcgQ1RMLiBCdXQgSSBkbyByZWNhbGwgdGhhdAo+IGF0IG9uZSBwb2ludCBpdCBzZWVt ZWQgdGhlIHdob2xlIHJlZyBzdGF0ZSB3YXMgemVybywgYnV0IHRoYXQgaXMgZm9nZ3kKPiBtZW1v cnkuCgpJIG1pZ2h0IG1peCB0aGlzIHdpdGggdGhlIGZhaWxlZCBpbml0IHdoZXJlIHRoZSBzdGFy dCB3YXMKYm9ndXMvc3RhbGUuIExvb2tlZCBsaWtlIGFmdGVyIHRoZSBoYW5nLCB0aGUgaGFyZHdh cmUganVzdApzd2FwcGVkIHRvIGEgcHJldmlvdXMgY3R4IHdpdGhvdXQgYW55IHByb3ZvY2F0aW9u LgoKUmVnYXJkbGVzcyBvZiB0aGUgcmVhc29uLCB0aGlzIHdpbGwgZ3VhcmQgdGhlCnJlc3RhcnQu Cgo+ICAKPj4gVGhlIGhldXJpc3RpY3Mgb2YgaXQgYm90aGVycyBtZSBzb21lIGFzIHdlIHdpbGwK Pj4gZ2V0IGZhbHNlIHBvc2l0aXZlcy4KPgo+IFRoZXkgY2Fubm90IGJlIGZhbHNlIHBvc2l0aXZl cyEgSWYgd2UgcmVzdG9yZSB0byBhIGJhdGNoIHNldHVwIGxpa2UKPiB0aGlzLCBpdCB3aWxsIGhh bmcgLS0gd2hpY2ggaXMgd2h5IHdlIGV4cGxpY2l0bHkgcmVzZXQgdGhlbS4KPiAgCj4+IFNvIGlu IGVmZmVjdCwgd2hlbiB3ZSBnZXQgb25lLCB3ZSBqdXN0IG1vdmUgYWhlYWQKPj4gYWZ0ZXIgYW4g ZXh0cmEgcmVzZXQgYXMgd2UgZ290IGl0IGFsbCB3cm9uZz8KPgo+IFl1cC4gVGhlIGNvbnRleHQg aXMgY29ycnVwdCwgd2UgcmVwbGFjZSBpdCB3aXRoIGEgc2FuZSBvbmUgYW5kIGhvcGUKPiBub2Jv ZHkgbm90aWNlcy4gTWVzYSBkb2VzIG5vdGljZSB0aG91Z2guLi4uCgpXZSB0ZWxsIHRoZW0gYWJv dXQgb3VyIHNob3J0Y29taW5ncywgaWYgdGhleSBjaG9vc2UgdG8gbGlzdGVuLgoKUmV2aWV3ZWQt Ynk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK