From: Jani Nikula <jani.nikula@linux.intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>,
Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix the static code analysis warning in debugfs
Date: Tue, 15 Jan 2019 12:52:29 +0200 [thread overview]
Message-ID: <87zhs25h1u.fsf@intel.com> (raw)
In-Reply-To: <20190109212217.GA13443@intel.com>
On Wed, 09 Jan 2019, Manasi Navare <manasi.d.navare@intel.com> wrote:
> On Wed, Jan 09, 2019 at 01:14:14PM -0800, Radhakrishna Sripada wrote:
>> intel_dp->dsc_dpcd is defined as an array making the if check redundant.
>>
>
> Yes I agree, I guess when I added that if check it was anot an array to begin
> with and then forgot to take it off.
>
> Looks good to me.
>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Manasi, you've got commit rights, please use them!
Pushed now, with proper Fixes: tag added, thanks for the patch, review,
testing, etc.
BR,
Jani.
>
> Manasi
>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_debugfs.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 95813e21ae02..908e41f9cb7d 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -4958,9 +4958,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
>> crtc_state = to_intel_crtc_state(crtc->state);
>> seq_printf(m, "DSC_Enabled: %s\n",
>> yesno(crtc_state->dsc_params.compression_enable));
>> - if (intel_dp->dsc_dpcd)
>> - seq_printf(m, "DSC_Sink_Support: %s\n",
>> - yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
>> + seq_printf(m, "DSC_Sink_Support: %s\n",
>> + yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
>> if (!intel_dp_is_edp(intel_dp))
>> seq_printf(m, "FEC_Sink_Support: %s\n",
>> yesno(drm_dp_sink_supports_fec(intel_dp->fec_capable)));
>> --
>> 2.20.0.rc2.7.g965798d1f299
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-15 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 21:14 [PATCH] drm/i915: Fix the static code analysis warning in debugfs Radhakrishna Sripada
2019-01-09 21:22 ` Manasi Navare
2019-01-15 10:52 ` Jani Nikula [this message]
2019-01-15 18:10 ` Manasi Navare
2019-01-09 22:55 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-10 1:53 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-14 19:31 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhs25h1u.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
--cc=radhakrishna.sripada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).