public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] igt/gem_eio: Increase wakeup delay for in-flight-suspend
Date: Fri, 01 Dec 2017 12:32:45 +0200	[thread overview]
Message-ID: <87zi72rb5e.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20171130150517.1351-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> For in-flight-suspend, we need to wait for the GPU hang within
> i915_gem_suspend(). This will take 10-20s, which means that the standard
> wakeup delay of around 15s may occur before we complete the suspend.
> This causes a pm_system_wakeup(), causing dpm_suspend() to return
> -EBUSY.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  tests/gem_eio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/gem_eio.c b/tests/gem_eio.c
> index 7a6be393..2ac9f0a9 100644
> --- a/tests/gem_eio.c
> +++ b/tests/gem_eio.c
> @@ -258,8 +258,8 @@ static void test_inflight_suspend(int fd)
>  		igt_assert(fence[n] != -1);
>  	}
>  
> -	igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> -				      SUSPEND_TEST_NONE);
> +	igt_set_autoresume_delay(30);
> +	igt_system_suspend_autoresume(SUSPEND_STATE_MEM, SUSPEND_TEST_NONE);
>  
>  	igt_post_hang_ring(fd, hang);

post_hang_cleanup(?) ...

-Mika

>  
> -- 
> 2.15.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-12-01 10:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 15:05 [PATCH igt] igt/gem_eio: Increase wakeup delay for in-flight-suspend Chris Wilson
2017-11-30 19:13 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-30 20:50 ` ✓ Fi.CI.IGT: " Patchwork
2017-11-30 20:53   ` Chris Wilson
2017-12-01 10:32 ` Mika Kuoppala [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-12-01 10:36 [PATCH igt] " Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zi72rb5e.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox