From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 8/9] drm/i915: Plumb crtc_state etc. directly to intel_ddi_pre_enable_{dp, hdmi}() Date: Fri, 13 Oct 2017 17:25:02 +0300 Message-ID: <87zi8vjfb5.fsf@intel.com> References: <20171010121207.570-1-ville.syrjala@linux.intel.com> <20171010121207.570-9-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA5E46EB4B for ; Fri, 13 Oct 2017 14:25:20 +0000 (UTC) In-Reply-To: <20171010121207.570-9-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxMCBPY3QgMjAxNywgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4KPiBSYXRoZXIgdGhhdCBwbHVtYiB0aGUgbGluayBwYXJhbWV0ZXJz IHNlcGFyYXRlbHkgdG8KPiBpbnRlbF9kZGlfcHJlX2VuYWJsZV9kcCgpIGxldCdzIGp1c3QgcGFz cyB0aGUgZW50aXJlIGNydGMgc3RhdGUuCj4KPiBpbnRlbF9kZGlfcHJlX2VuYWJsZV9oZG1pKCkg YWxyZWFkeSB0b29rIHRoZSBjcnRjIHN0YXRlLCBidXQgZm9yIHNvbWUKPiByZWFzb24gaW50ZWxf ZGRpX3ByZV9lbmFibGUoKSBzdGlsbCB3YW50ZWQgdG8gZXh0cmFjdCBoYXNfaW5mb2ZyYW1lCj4g ZnJvbSB0aGVyZWluIGFuZCBwYXNzIGl0IGluIHNlcGFyYXRlbHkuIExldCdzIG5vdCBkbyB0aGF0 IHNpbmNlIGl0J3MKPiBwb2ludGxlc3MuCj4KPiB2MjogUmViYXNlIGR1ZSB0byBtb3JlIGNvZGUg Z2V0dGluZyBwdWxsZWQgaW50byB0aGUgRERJIGhvb2tzCj4KPiBDYzogSmFuaSBOaWt1bGEgPGph bmkubmlrdWxhQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxq YW5pLm5pa3VsYUBpbnRlbC5jb20+CgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGRpLmMgfCA1NCArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAzNCBkZWxldGlvbnMoLSkKPgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gaW5kZXggYzkzMGVmMDMzOGM1Li40OWNmOGQ5ZDJiYzEg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IEBAIC0yMTU3LDI0ICsyMTU3LDI0IEBA IHN0YXRpYyB2b2lkIGludGVsX2RkaV9jbGtfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAq ZW5jb2RlcikKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX3ByZV9lbmFibGVfZHAo c3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gLQkJCQkgICAgaW50IGxpbmtfcmF0ZSwg dWludDMyX3QgbGFuZV9jb3VudCwKPiAtCQkJCSAgICBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwg KnBsbCwKPiAtCQkJCSAgICBib29sIGxpbmtfbXN0KQo+ICsJCQkJICAgIGNvbnN0IHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICsJCQkJICAgIGNvbnN0IHN0cnVjdCBkcm1f Y29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZHAgKmlu dGVsX2RwID0gZW5jX3RvX2ludGVsX2RwKCZlbmNvZGVyLT5iYXNlKTsKPiAgCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOwo+ICAJ ZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kZGlfZ2V0X2VuY29kZXJfcG9ydChlbmNvZGVyKTsKPiAg CXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gZW5jX3RvX2RpZ19wb3J0KCZl bmNvZGVyLT5iYXNlKTsKPiArCWJvb2wgaXNfbXN0ID0gaW50ZWxfY3J0Y19oYXNfdHlwZShjcnRj X3N0YXRlLCBJTlRFTF9PVVRQVVRfRFBfTVNUKTsKPiAgCXVpbnQzMl90IGxldmVsID0gaW50ZWxf ZGRpX2RwX2xldmVsKGludGVsX2RwKTsKPiAgCj4gLQlXQVJOX09OKGxpbmtfbXN0ICYmIChwb3J0 ID09IFBPUlRfQSB8fCBwb3J0ID09IFBPUlRfRSkpOwo+ICsJV0FSTl9PTihpc19tc3QgJiYgKHBv cnQgPT0gUE9SVF9BIHx8IHBvcnQgPT0gUE9SVF9FKSk7Cj4gIAo+IC0JaW50ZWxfZHBfc2V0X2xp bmtfcGFyYW1zKGludGVsX2RwLCBsaW5rX3JhdGUsIGxhbmVfY291bnQsCj4gLQkJCQkgbGlua19t c3QpOwo+ICsJaW50ZWxfZHBfc2V0X2xpbmtfcGFyYW1zKGludGVsX2RwLCBjcnRjX3N0YXRlLT5w b3J0X2Nsb2NrLAo+ICsJCQkJIGNydGNfc3RhdGUtPmxhbmVfY291bnQsIGlzX21zdCk7Cj4gIAo+ ICAJaW50ZWxfZWRwX3BhbmVsX29uKGludGVsX2RwKTsKPiAgCj4gLQlpbnRlbF9kZGlfY2xrX3Nl bGVjdChlbmNvZGVyLCBwbGwpOwo+ICsJaW50ZWxfZGRpX2Nsa19zZWxlY3QoZW5jb2RlciwgY3J0 Y19zdGF0ZS0+c2hhcmVkX2RwbGwpOwo+ICAKPiAgCWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0KGRl dl9wcml2LCBkaWdfcG9ydC0+ZGRpX2lvX3Bvd2VyX2RvbWFpbik7Cj4gIAo+IEBAIC0yMTg2LDcg KzIxODYsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9kZGlfcHJlX2VuYWJsZV9kcChzdHJ1Y3QgaW50 ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCQlpbnRlbF9wcmVwYXJlX2RwX2RkaV9idWZmZXJzKGVu Y29kZXIpOwo+ICAKPiAgCWludGVsX2RkaV9pbml0X2RwX2J1Zl9yZWcoZW5jb2Rlcik7Cj4gLQlp ZiAoIWxpbmtfbXN0KQo+ICsJaWYgKCFpc19tc3QpCj4gIAkJaW50ZWxfZHBfc2lua19kcG1zKGlu dGVsX2RwLCBEUk1fTU9ERV9EUE1TX09OKTsKPiAgCWludGVsX2RwX3N0YXJ0X2xpbmtfdHJhaW4o aW50ZWxfZHApOwo+ICAJaWYgKHBvcnQgIT0gUE9SVF9BIHx8IElOVEVMX0dFTihkZXZfcHJpdikg Pj0gOSkKPiBAQCAtMjE5NCwxMCArMjE5NCw4IEBAIHN0YXRpYyB2b2lkIGludGVsX2RkaV9wcmVf ZW5hYmxlX2RwKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICB9Cj4gIAo+ICBzdGF0 aWMgdm9pZCBpbnRlbF9kZGlfcHJlX2VuYWJsZV9oZG1pKHN0cnVjdCBpbnRlbF9lbmNvZGVyICpl bmNvZGVyLAo+IC0JCQkJICAgICAgYm9vbCBoYXNfaW5mb2ZyYW1lLAo+ICAJCQkJICAgICAgY29u c3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gLQkJCQkgICAgICBjb25z dCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZSwKPiAtCQkJCSAgICAgIGNv bnN0IHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsKQo+ICsJCQkJICAgICAgY29uc3Qgc3Ry dWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBpbnRl bF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0gZW5jX3RvX2RpZ19wb3J0KCZlbmNvZGVy LT5iYXNlKTsKPiAgCXN0cnVjdCBpbnRlbF9oZG1pICppbnRlbF9oZG1pID0gJmludGVsX2RpZ19w b3J0LT5oZG1pOwo+IEBAIC0yMjA3LDcgKzIyMDUsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9kZGlf cHJlX2VuYWJsZV9oZG1pKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJc3RydWN0 IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPSBlbmNfdG9fZGlnX3BvcnQoJmVuY29kZXIt PmJhc2UpOwo+ICAKPiAgCWludGVsX2RwX2R1YWxfbW9kZV9zZXRfdG1kc19vdXRwdXQoaW50ZWxf aGRtaSwgdHJ1ZSk7Cj4gLQlpbnRlbF9kZGlfY2xrX3NlbGVjdChlbmNvZGVyLCBwbGwpOwo+ICsJ aW50ZWxfZGRpX2Nsa19zZWxlY3QoZW5jb2RlciwgY3J0Y19zdGF0ZS0+c2hhcmVkX2RwbGwpOwo+ ICAKPiAgCWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0KGRldl9wcml2LCBkaWdfcG9ydC0+ZGRpX2lv X3Bvd2VyX2RvbWFpbik7Cj4gIAo+IEBAIC0yMjIzLDM4ICsyMjIxLDI2IEBAIHN0YXRpYyB2b2lk IGludGVsX2RkaV9wcmVfZW5hYmxlX2hkbWkoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIs Cj4gIAkJc2tsX2RkaV9zZXRfaWJvb3N0KGVuY29kZXIsIGxldmVsKTsKPiAgCj4gIAlpbnRlbF9k aWdfcG9ydC0+c2V0X2luZm9mcmFtZXMoJmVuY29kZXItPmJhc2UsCj4gLQkJCQkgICAgICAgaGFz X2luZm9mcmFtZSwKPiArCQkJCSAgICAgICBjcnRjX3N0YXRlLT5oYXNfaW5mb2ZyYW1lLAo+ICAJ CQkJICAgICAgIGNydGNfc3RhdGUsIGNvbm5fc3RhdGUpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9p ZCBpbnRlbF9kZGlfcHJlX2VuYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAt CQkJCSBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gKwkJCQkg Y29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIAkJCQkgY29uc3Qg c3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGUpCj4gIHsKPiAtCXN0cnVjdCBk cm1fY3J0YyAqY3J0YyA9IHBpcGVfY29uZmlnLT5iYXNlLmNydGM7Cj4gLQlzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGMtPmRldik7Cj4gLQlzdHJ1Y3QgaW50 ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Yyk7Cj4gLQlpbnQgcGlwZSA9 IGludGVsX2NydGMtPnBpcGU7Cj4gLQlpbnQgdHlwZSA9IGVuY29kZXItPnR5cGU7Cj4gKwlzdHJ1 Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Y19zdGF0ZS0+YmFzZS5jcnRj KTsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+ YmFzZS5kZXYpOwo+ICsJZW51bSBwaXBlIHBpcGUgPSBjcnRjLT5waXBlOwo+ICAKPiAtCVdBUk5f T04oaW50ZWxfY3J0Yy0+Y29uZmlnLT5oYXNfcGNoX2VuY29kZXIpOwo+ICsJV0FSTl9PTihjcnRj X3N0YXRlLT5oYXNfcGNoX2VuY29kZXIpOwo+ICAKPiAgCWludGVsX3NldF9jcHVfZmlmb191bmRl cnJ1bl9yZXBvcnRpbmcoZGV2X3ByaXYsIHBpcGUsIHRydWUpOwo+ICAKPiAtCWlmICh0eXBlID09 IElOVEVMX09VVFBVVF9EUCB8fCB0eXBlID09IElOVEVMX09VVFBVVF9FRFApIHsKPiAtCQlpbnRl bF9kZGlfcHJlX2VuYWJsZV9kcChlbmNvZGVyLAo+IC0JCQkJCXBpcGVfY29uZmlnLT5wb3J0X2Ns b2NrLAo+IC0JCQkJCXBpcGVfY29uZmlnLT5sYW5lX2NvdW50LAo+IC0JCQkJCXBpcGVfY29uZmln LT5zaGFyZWRfZHBsbCwKPiAtCQkJCQlpbnRlbF9jcnRjX2hhc190eXBlKHBpcGVfY29uZmlnLAo+ IC0JCQkJCQkJICAgIElOVEVMX09VVFBVVF9EUF9NU1QpKTsKPiAtCX0KPiAtCWlmICh0eXBlID09 IElOVEVMX09VVFBVVF9IRE1JKSB7Cj4gLQkJaW50ZWxfZGRpX3ByZV9lbmFibGVfaGRtaShlbmNv ZGVyLAo+IC0JCQkJCSAgcGlwZV9jb25maWctPmhhc19pbmZvZnJhbWUsCj4gLQkJCQkJICBwaXBl X2NvbmZpZywgY29ubl9zdGF0ZSwKPiAtCQkJCQkgIHBpcGVfY29uZmlnLT5zaGFyZWRfZHBsbCk7 Cj4gLQl9Cj4gKwlpZiAoaW50ZWxfY3J0Y19oYXNfdHlwZShjcnRjX3N0YXRlLCBJTlRFTF9PVVRQ VVRfSERNSSkpCj4gKwkJaW50ZWxfZGRpX3ByZV9lbmFibGVfaGRtaShlbmNvZGVyLCBjcnRjX3N0 YXRlLCBjb25uX3N0YXRlKTsKPiArCWVsc2UKPiArCQlpbnRlbF9kZGlfcHJlX2VuYWJsZV9kcChl bmNvZGVyLCBjcnRjX3N0YXRlLCBjb25uX3N0YXRlKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQg aW50ZWxfZGlzYWJsZV9kZGlfYnVmKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQoKLS0g CkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK