From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 07/12] drm/i915/psr: Re-create
	a	hsw_psr_enable_source.
Date: Fri, 14 Jul 2017 13:06:27 +0300
Message-ID: <87zic7jpss.fsf@nikula.org>
References: <20170712192042.19782-1-rodrigo.vivi@intel.com>
 <20170712192042.19782-8-rodrigo.vivi@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 26F476E7D5
 for <intel-gfx@lists.freedesktop.org>; Fri, 14 Jul 2017 10:01:28 +0000 (UTC)
In-Reply-To: <20170712192042.19782-8-rodrigo.vivi@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCAxMiBKdWwgMjAxNywgUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t
PiB3cm90ZToKPiBUaGlzIHNlcXVlbmNlIGlzIHBhcnQgb2YgZW5hYmxlIHNvdXJjZSBhbnl3YXlz
LCBidXQgdGhleQo+IG9ubHkgbmVlZCB0byBiZSBleGVjdXRlZCBvbmNlIGFuZCBub3Qgb24gZXZl
cnkgYWN0aXZhdGlvbiwKPiBTbyBsZXQncyByZS1jcmVhdGUgaHN3X2VuYWJsZV9zb3VyY2UuCj4K
PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBDYzogRGhpbmFr
YXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gQ2M6IEppbSBC
cmlkZSA8amltLmJyaWRlQGxpbnV4LmludGVsLmNvbT4KPiBDYzogVmF0aHNhbGEgTkFnYXJhanUg
PHZhdGhzYWxhLm5hZ2FyYWp1QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZp
dmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX3Bzci5jIHwgNzcgKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t
LQo+ICAxIGZpbGUgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKSwgMzQgZGVsZXRpb25zKC0pCj4K
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IGluZGV4IDJmYmY4MDNmMDY2Ny4uNDIyMDMzYTZm
OWY2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBAQCAtMjE5LDYgKzIxOSw0NyBA
QCBzdGF0aWMgdm9pZCBoc3dfcHNyX2VuYWJsZV9zaW5rKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf
ZHApCj4gIAlJOTE1X1dSSVRFKGF1eF9jdGxfcmVnLCBhdXhfY3RsKTsKPiAgfQo+ICAKPiArc3Rh
dGljIHZvaWQgaHN3X3Bzcl9lbmFibGVfc291cmNlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAp
Cj4gK3sKPiArCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gZHBfdG9fZGln
X3BvcnQoaW50ZWxfZHApOwo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGRpZ19wb3J0LT5i
YXNlLmJhc2UuZGV2Owo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f
aTkxNShkZXYpOwo+ICsJc3RydWN0IGludGVsX2NydGMgKmNydGMgPSB0b19pbnRlbF9jcnRjKGRp
Z19wb3J0LT5iYXNlLmJhc2UuY3J0Yyk7Cj4gKwllbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29k
ZXIgPSBjcnRjLT5jb25maWctPmNwdV90cmFuc2NvZGVyOwo+ICsKPiArCXUzMiBjaGlja2VuOwo+
ICsKPiArCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfc3VwcG9ydCkgewo+ICsJCWNoaWNrZW4gPSBQ
U1IyX1ZTQ19FTkFCTEVfUFJPR19IRUFERVI7Cj4gKwkJaWYgKGRldl9wcml2LT5wc3IueV9jb3Jk
X3N1cHBvcnQpCj4gKwkJCWNoaWNrZW4gfD0gUFNSMl9BRERfVkVSVElDQUxfTElORV9DT1VOVDsK
PiArCQlJOTE1X1dSSVRFKENISUNLRU5fVFJBTlMoY3B1X3RyYW5zY29kZXIpLCBjaGlja2VuKTsK
PiArCQlJOTE1X1dSSVRFKEVEUF9QU1JfREVCVUdfQ1RMLAo+ICsJCQkgICBFRFBfUFNSX0RFQlVH
X01BU0tfTUVNVVAgfAo+ICsJCQkgICBFRFBfUFNSX0RFQlVHX01BU0tfSFBEIHwKPiArCQkJICAg
RURQX1BTUl9ERUJVR19NQVNLX0xQU1AgfAo+ICsJCQkgICBFRFBfUFNSX0RFQlVHX01BU0tfTUFY
X1NMRUVQIHwKPiArCQkJICAgRURQX1BTUl9ERUJVR19NQVNLX0RJU1BfUkVHX1dSSVRFKTsKPiAr
CX0gZWxzZSB7Cj4gKwkJLyoKPiArCQkgKiBQZXIgU3BlYzogQXZvaWQgY29udGludW91cyBQU1Ig
ZXhpdCBieSBtYXNraW5nIE1FTVVQCj4gKwkJICogYW5kIEhQRC4gYWxzbyBtYXNrIExQU1AgdG8g
YXZvaWQgZGVwZW5kZW5jeSBvbiBvdGhlcgo+ICsJCSAqIGRyaXZlcnMgdGhhdCBtaWdodCBibG9j
ayBydW50aW1lX3BtIGJlc2lkZXMKPiArCQkgKiBwcmV2ZW50aW5nICBvdGhlciBodyB0cmFja2lu
ZyBpc3N1ZXMgbm93IHdlIGNhbiByZWx5Cj4gKwkJICogb24gZnJvbnRidWZmZXIgdHJhY2tpbmcu
Cj4gKwkJICovCj4gKwkJSTkxNV9XUklURShFRFBfUFNSX0RFQlVHX0NUTCwKPiArCQkJICAgRURQ
X1BTUl9ERUJVR19NQVNLX01FTVVQIHwKPiArCQkJICAgRURQX1BTUl9ERUJVR19NQVNLX0hQRCB8
Cj4gKwkJCSAgIEVEUF9QU1JfREVCVUdfTUFTS19MUFNQKTsKPiArCX0KPiArCj4gKwkvKgo+ICsJ
ICogVGhlIHJlc3Qgb2YgZW5hYmxlIHNvdXJjZSBzZXF1ZW5jZSB0aGF0IHNob3VsZCBiZSBoZXJl
IGlzIGFjdHVhbGx5Cj4gKwkgKiBleGVjdXRlZCBkdXJpbmcgYWN0aXZhdGlvbiB0aW1lLiBTbyBj
aGVjayBoc3dfcHNyX2FjdGl2YXRlKCkuCj4gKwkgKi8KPiArfQo+ICsKPiAgc3RhdGljIHZvaWQg
dmx2X3Bzcl9lbmFibGVfc291cmNlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIHsKPiAg
CXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50
ZWxfZHApOwo+IEBAIC00NzQsOSArNTE1LDYgQEAgdm9pZCBpbnRlbF9wc3JfZW5hYmxlKHN0cnVj
dCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRl
bF9kaWdfcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiAgCXN0cnVjdCBkcm1fZGV2
aWNlICpkZXYgPSBpbnRlbF9kaWdfcG9ydC0+YmFzZS5iYXNlLmRldjsKPiAgCXN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAtCXN0cnVjdCBpbnRlbF9j
cnRjICpjcnRjID0gdG9faW50ZWxfY3J0YyhpbnRlbF9kaWdfcG9ydC0+YmFzZS5iYXNlLmNydGMp
Owo+IC0JZW51bSB0cmFuc2NvZGVyIGNwdV90cmFuc2NvZGVyID0gY3J0Yy0+Y29uZmlnLT5jcHVf
dHJhbnNjb2RlcjsKPiAtCXUzMiBjaGlja2VuOwo+ICAKPiAgCWlmICghSEFTX1BTUihkZXZfcHJp
dikpCj4gIAkJcmV0dXJuOwo+IEBAIC01MDEsMzQgKzUzOSwxMSBAQCB2b2lkIGludGVsX3Bzcl9l
bmFibGUoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCj4gIAkJaHN3X3Bzcl9zZXR1cF92
c2MoaW50ZWxfZHApOwo+ICAKPiAtCQlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX3N1cHBvcnQpIHsK
PiAtCQkJY2hpY2tlbiA9IFBTUjJfVlNDX0VOQUJMRV9QUk9HX0hFQURFUjsKPiAtCQkJaWYgKGRl
dl9wcml2LT5wc3IueV9jb3JkX3N1cHBvcnQpCj4gLQkJCQljaGlja2VuIHw9IFBTUjJfQUREX1ZF
UlRJQ0FMX0xJTkVfQ09VTlQ7Cj4gLQkJCUk5MTVfV1JJVEUoQ0hJQ0tFTl9UUkFOUyhjcHVfdHJh
bnNjb2RlciksIGNoaWNrZW4pOwo+IC0JCQlJOTE1X1dSSVRFKEVEUF9QU1JfREVCVUdfQ1RMLAo+
IC0JCQkJICAgRURQX1BTUl9ERUJVR19NQVNLX01FTVVQIHwKPiAtCQkJCSAgIEVEUF9QU1JfREVC
VUdfTUFTS19IUEQgfAo+IC0JCQkJICAgRURQX1BTUl9ERUJVR19NQVNLX0xQU1AgfAo+IC0JCQkJ
ICAgRURQX1BTUl9ERUJVR19NQVNLX01BWF9TTEVFUCB8Cj4gLQkJCQkgICBFRFBfUFNSX0RFQlVH
X01BU0tfRElTUF9SRUdfV1JJVEUpOwo+IC0JCX0gZWxzZSB7Cj4gLQkJCS8qCj4gLQkJCSAqIFBl
ciBTcGVjOiBBdm9pZCBjb250aW51b3VzIFBTUiBleGl0IGJ5IG1hc2tpbmcgTUVNVVAKPiAtCQkJ
ICogYW5kIEhQRC4gYWxzbyBtYXNrIExQU1AgdG8gYXZvaWQgZGVwZW5kZW5jeSBvbiBvdGhlcgo+
IC0JCQkgKiBkcml2ZXJzIHRoYXQgbWlnaHQgYmxvY2sgcnVudGltZV9wbSBiZXNpZGVzCj4gLQkJ
CSAqIHByZXZlbnRpbmcgIG90aGVyIGh3IHRyYWNraW5nIGlzc3VlcyBub3cgd2UgY2FuIHJlbHkK
PiAtCQkJICogb24gZnJvbnRidWZmZXIgdHJhY2tpbmcuCj4gLQkJCSAqLwo+IC0JCQlJOTE1X1dS
SVRFKEVEUF9QU1JfREVCVUdfQ1RMLAo+IC0JCQkJICAgRURQX1BTUl9ERUJVR19NQVNLX01FTVVQ
IHwKPiAtCQkJCSAgIEVEUF9QU1JfREVCVUdfTUFTS19IUEQgfAo+IC0JCQkJICAgRURQX1BTUl9E
RUJVR19NQVNLX0xQU1ApOwo+IC0JCX0KPiAtCj4gIAkJLyogRW5hYmxlIFBTUiBvbiB0aGUgcGFu
ZWwgKi8KPiAgCQloc3dfcHNyX2VuYWJsZV9zaW5rKGludGVsX2RwKTsKPiAgCj4gKwkJaHN3X3Bz
cl9lbmFibGVfc291cmNlKGludGVsX2RwKTsKPiArCgpXb3VsZG4ndCBpdCBiZSBiZXR0ZXIgdG8g
a2VlcCB0aGUgb3JkZXI/IE9yIGhhdmUgdGhlIG9yZGVyIGNoYW5nZWQgaW4gYQpzZXBhcmF0ZSBw
YXRjaCBpZiB5b3UgbmVlZCB0aGUgb3JkZXIgY2hhbmdlZD8KCkJSLApKYW5pLgoKPiAgCQlpZiAo
SU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+ICAJCQlpbnRlbF9wc3JfYWN0aXZhdGUoaW50ZWxf
ZHApOwo+ICAJfSBlbHNlIHsKPiBAQCAtNTM3LDEyICs1NTIsNiBAQCB2b2lkIGludGVsX3Bzcl9l
bmFibGUoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCQkvKiBFbmFibGUgUFNSIG9uIHRo
ZSBwYW5lbCAqLwo+ICAJCXZsdl9wc3JfZW5hYmxlX3NpbmsoaW50ZWxfZHApOwo+ICAKPiAtCQkv
KiBPbiBIU1crIGVuYWJsZV9zb3VyY2UgYWxzbyBtZWFucyBnbyB0byBQU1IgZW50cnkvYWN0aXZl
Cj4gLQkJICogc3RhdGUgYXMgc29vbiBhcyBpZGxlX2ZyYW1lIGFjaGlldmVkIGFuZCBoZXJlIHdv
dWxkIGJlCj4gLQkJICogdG8gc29vbi4gSG93ZXZlciBvbiBWTFYgZW5hYmxlX3NvdXJjZSBqdXN0
IGVuYWJsZSBQU1IKPiAtCQkgKiBidXQgbGV0IGl0IG9uIGluYWN0aXZlIHN0YXRlLiBTbyB3ZSBt
aWdodCBkbyB0aGlzIHByaW9yCj4gLQkJICogdG8gYWN0aXZlIHRyYW5zaXRpb24sIGkuZS4gaGVy
ZS4KPiAtCQkgKi8KPiAgCQl2bHZfcHNyX2VuYWJsZV9zb3VyY2UoaW50ZWxfZHApOwo+ICAJfQoK
LS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp
bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK