public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>,
	Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Joe Konno <joe.konno@linux.intel.com>
Subject: Re: [PATCH v4 00/12] All sort of cdclk stuff
Date: Thu, 28 May 2015 20:17:35 +0300	[thread overview]
Message-ID: <87zj4ovcy8.fsf@intel.com> (raw)
In-Reply-To: <20150528160108.GJ8341@phenom.ffwll.local>

On Thu, 28 May 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, May 28, 2015 at 04:29:10PM +0100, Damien Lespiau wrote:
>> On Wed, May 27, 2015 at 02:49:38PM -0700, Joe Konno wrote:
>> > Do we have an idea when this patch series will be reviewed? Customers
>> > are awaiting for this to be merged to the drm-intel fd.o repository.
>> 
>> This series is mostly reviewed, all but one patch the HSW CDCLK code.
>> I'm not sure that we want to enable that on HSW as AFAIK changing CDCLK
>> hasn't been validated on that platform.
>> 
>> Next step is for Mika to resend the series with jani's comments I
>> believe?
>
> Yeah.
>
> The other thing I realized (and the reason I didn't realize that most here
> is reviewed) is that the r-b tags magically appeared when resending and
> there seems to never have been a review on the m-l. I don't like when that
> kind of backroom review happens, since it excludes everyone else. Besides
> that I'll simply not noticed it has happened ...

Well, as I mentioned, Mika should've added his Signed-off-by, not
Reviewed-by, when picking up where Ville left off. I'm not sure if much
further review is necessary if the patches have gone through two
developers. So I don't think it's as bad as you imply.

BR,
Jani.


> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-05-28 17:19 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22  8:22 [PATCH v4 00/12] All sort of cdclk stuff Mika Kahola
2015-05-22  8:22 ` [PATCH v4 01/12] drm/i915: Fix i855 get_display_clock_speed Mika Kahola
2015-05-28 18:12   ` Damien Lespiau
2015-05-22  8:22 ` [PATCH v4 02/12] drm/i915: Fix 852GM/GMV cdclk Mika Kahola
2015-05-28 18:16   ` Damien Lespiau
2015-05-22  8:22 ` [PATCH v4 03/12] drm/i915: Add cdclk extraction for g33, g965gm and g4x Mika Kahola
2015-05-28 18:17   ` Damien Lespiau
2015-05-22  8:22 ` [PATCH v4 04/12] drm/i915: Warn when cdclk for the platforms is not known Mika Kahola
2015-05-28 18:19   ` Damien Lespiau
2015-05-29  7:57     ` Daniel Vetter
2015-05-22  8:22 ` [PATCH v4 05/12] drm/i915: Cache current cdclk frequency in dev_priv Mika Kahola
2015-05-28 18:24   ` Damien Lespiau
2015-05-22  8:22 ` [PATCH v4 06/12] drm/i915: Use cached cdclk value Mika Kahola
2015-05-28 18:27   ` Damien Lespiau
2015-05-22  8:22 ` [PATCH v4 07/12] drm/i915: Unify ilk and hsw .get_aux_clock_divider Mika Kahola
2015-05-28 18:31   ` Damien Lespiau
2015-05-22  8:22 ` [PATCH v4 8/8] drm/i915: Store max cdclk value in dev_priv Mika Kahola
2015-05-28 18:32   ` Damien Lespiau
2015-05-22  8:22 ` [PATCH v4 09/12] drm/i915: Don't enable IPS when pixel rate exceeds 95% Mika Kahola
2015-05-28 18:35   ` Damien Lespiau
2015-05-22  8:22 ` [PATCH v4 10/12] drm/i915: HSW cdclk support Mika Kahola
2015-05-29 11:30   ` Damien Lespiau
2015-05-29 12:06     ` Kahola, Mika
2015-05-29 12:56       ` Damien Lespiau
2015-05-29 13:51     ` Ville Syrjälä
2015-05-22  8:22 ` [PATCH v4 11/12] drm/i915: Add IS_BDW_ULX Mika Kahola
2015-05-29 11:33   ` Damien Lespiau
2015-05-22  8:22 ` [PATCH v4 12/12] drm/i915: BDW clock change support Mika Kahola
2015-05-29 11:45   ` Damien Lespiau
2015-05-22  8:41 ` [PATCH v4 00/12] All sort of cdclk stuff Jani Nikula
2015-05-22  8:46   ` Jani Nikula
2015-05-27 21:49 ` Joe Konno
2015-05-28 15:29   ` Damien Lespiau
2015-05-28 16:01     ` Daniel Vetter
2015-05-28 17:11       ` Joe Konno
2015-05-28 17:20         ` Damien Lespiau
2015-05-28 17:17       ` Jani Nikula [this message]
2015-05-28 17:28         ` Damien Lespiau
2015-05-28 17:40           ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj4ovcy8.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=damien.lespiau@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joe.konno@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox