From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/2] drm/i915: Split adding request to smaller functions Date: Fri, 20 Feb 2015 11:16:15 +0200 Message-ID: <87zj897xk0.fsf@gaia.fi.intel.com> References: <1424362735-10569-1-git-send-email-mika.kuoppala@intel.com> <54E61549.504@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 173B76E664 for ; Fri, 20 Feb 2015 01:16:26 -0800 (PST) In-Reply-To: <54E61549.504@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John Harrison , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Sm9obiBIYXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4gd3JpdGVzOgoKPiBQbGVh c2Ugbm90ZSB0aGF0IGEgbG90IG9mIHRoZSBpc3N1ZXMgd2l0aCBfaTkxNV9hZGRfcmVxdWVzdCBh cmUgY2xlYW5lZCAKPiB1cCBieSBteSBwYXRjaCBzZXJpZXMgdG8gcmVtb3ZlIHRoZSBvdXRzdGFu ZGluZ19sYXp5X3JlcXVlc3QuIFRoZSBhZGQgdG8gCj4gY2xpZW50IGluIHNvbWUgcmFuZG9tIGNs aWVudCBjb250ZXh0IGlzIGZpeGVkLCB0aGUgbWVzc3kgZXhlY2xpc3QgdnMgCj4gbGVnYWN5IHJp bmdidWYgZGVjaXNpb25zIGFyZSByZW1vdmVkLCB0aGUgZXhlY2xpc3QgdnMgbGVnYWN5IG9uZS1z aWRlZCAKPiBjb250ZXh0IHJlZmVyZW5jZSBpcyByZW1vdmVkLCAuLi4KPgo+IEFsc28sIEkgYW0g aW4gdGhlIHByb2Nlc3Mgb2YgY29udmVydGluZyB0aGUgcmVxdWVzdCBzdHJ1Y3R1cmUgdG8gdXNl IAo+IHN0cnVjdCBmZW5jZSB3aGljaCB3aWxsIHBvc3NpYmx5IGFuc3dlciBzb21lIG9mIHlvdXIg bG9ja2luZyBjb25jZXJucyBpbiAKPiB0aGUgc3Vic2VxdWVudCBwYXRjaC4KPgo+IFNvIGNhbiB5 b3UgaG9sZCBvZiBvbiBtZXJnaW5nIHRoZXNlIHR3byBwYXRjaGVzIGF0IGxlYXN0IHVudGlsIHRo ZSBkdXN0IAo+IGhhcyBzZXR0bGVkIG9uIHRoZSBhbnRpLU9MUiBzZXJpZXM/Cj4KClRoaXMgd2Fz IGp1c3QgYSBxdWljayBzdGFiIGF0IGZpeGluZyB0aGUgaGFuZ2NoZWNrIG1pc3JlcG9ydHMgb24g cmluZwpiZWluZyBpZGxlIHdoZW4gbm90LgoKRGFuaWVsIHBsZWFzZSBqdXN0IGlnbm9yZSB0aGVz ZSB0d28uCgotTWlrYQoKPiBUaGFua3MuCj4KPgo+IE9uIDE5LzAyLzIwMTUgMTY6MTgsIE1pa2Eg S3VvcHBhbGEgd3JvdGU6Cj4+IENsZWFuIF9faTkxNV9hZGRfcmVxdWVzdCBieSBzcGxpdHRpbmcg cmVxdWVzdCBzdWJtaXNzaW9uIHRvCj4+IHByZXBhcmF0aW9uLCBhY3R1YWwgc3VibWlzc2lvbiBh bmQgYWRkaW5nIHRvIGNsaWVudC4KPj4KPj4gV2hpbGUgZG9pbmcgdGhpcyB3ZSBjYW4gcmVtb3Zl IHRoZSByZXF1ZXN0LT5zdGFydCB3aGljaAo+PiB3YXMgbm90IHVzZWQuCj4+Cj4+IENjOiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4gU2lnbmVkLW9mZi1ieTogTWlr YSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAxMTYgKysrKysrKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCA3OCBpbnNlcnRpb25zKCspLCAzOCBk ZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+IGluZGV4IDYxMTM0YWIu LjA2MjY1ZTcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMK Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+PiBAQCAtMjQwNywyNiAr MjQwNywzNCBAQCBpOTE1X2dlbV9nZXRfc2Vxbm8oc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdTMy ICpzZXFubykKPj4gICAJcmV0dXJuIDA7Cj4+ICAgfQo+PiAgIAo+PiAtaW50IF9faTkxNV9hZGRf cmVxdWVzdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nLAo+PiAtCQkgICAgICAgc3RydWN0 IGRybV9maWxlICpmaWxlLAo+PiAtCQkgICAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3Qg Km9iaikKPj4gK3N0YXRpYyBzdHJ1Y3QgaW50ZWxfcmluZ2J1ZmZlciAqCj4+ICtfX3JlcXVlc3Rf dG9fcmluZ2J1ZihzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4+ICt7Cj4+ ICsJaWYgKGk5MTUuZW5hYmxlX2V4ZWNsaXN0cykKPj4gKwkJcmV0dXJuIHJlcXVlc3QtPmN0eC0+ ZW5naW5lW3JlcXVlc3QtPnJpbmctPmlkXS5yaW5nYnVmOwo+PiArCj4+ICsJcmV0dXJuIHJlcXVl c3QtPnJpbmctPmJ1ZmZlcjsKPj4gK30KPj4gKwo+PiArc3RhdGljIHN0cnVjdCBkcm1faTkxNV9n ZW1fcmVxdWVzdCAqCj4+ICtpOTE1X2dlbV9yZXF1ZXN0X3ByZXBhcmUoc3RydWN0IGludGVsX2Vu Z2luZV9jcyAqcmluZywgc3RydWN0IGRybV9maWxlICpmaWxlKQo+PiAgIHsKPj4gLQlzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSByaW5nLT5kZXYtPmRldl9wcml2YXRlOwo+PiAg IAlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3Q7Cj4+ICAgCXN0cnVjdCBpbnRl bF9yaW5nYnVmZmVyICpyaW5nYnVmOwo+PiAtCXUzMiByZXF1ZXN0X3N0YXJ0Owo+PiAgIAlpbnQg cmV0Owo+PiAgIAo+PiAgIAlyZXF1ZXN0ID0gcmluZy0+b3V0c3RhbmRpbmdfbGF6eV9yZXF1ZXN0 Owo+PiAgIAlpZiAoV0FSTl9PTihyZXF1ZXN0ID09IE5VTEwpKQo+PiAtCQlyZXR1cm4gLUVOT01F TTsKPj4gKwkJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4+ICAgCj4+IC0JaWYgKGk5MTUuZW5h YmxlX2V4ZWNsaXN0cykgewo+PiAtCQlyaW5nYnVmID0gcmVxdWVzdC0+Y3R4LT5lbmdpbmVbcmlu Zy0+aWRdLnJpbmdidWY7Cj4+IC0JfSBlbHNlCj4+IC0JCXJpbmdidWYgPSByaW5nLT5idWZmZXI7 Cj4+ICsJLyogZXhlY2xpc3Qgc3VibWlzc2lvbiBoYXMgdGhpcyBhbHJlYWR5IHNldCAqLwo+PiAr CWlmICghcmVxdWVzdC0+Y3R4KQo+PiArCQlyZXF1ZXN0LT5jdHggPSByaW5nLT5sYXN0X2NvbnRl eHQ7Cj4+ICsKPj4gKwlyaW5nYnVmID0gX19yZXF1ZXN0X3RvX3JpbmdidWYocmVxdWVzdCk7Cj4+ ICsJaWYgKFdBUk5fT04ocmluZ2J1ZiA9PSBOVUxMKSkKPj4gKwkJcmV0dXJuIEVSUl9QVFIoLUVJ Tyk7Cj4+ICAgCj4+IC0JcmVxdWVzdF9zdGFydCA9IGludGVsX3JpbmdfZ2V0X3RhaWwocmluZ2J1 Zik7Cj4+ICAgCS8qCj4+ICAgCSAqIEVtaXQgYW55IG91dHN0YW5kaW5nIGZsdXNoZXMgLSBleGVj YnVmIGNhbiBmYWlsIHRvIGVtaXQgdGhlIGZsdXNoCj4+ICAgCSAqIGFmdGVyIGhhdmluZyBlbWl0 dGVkIHRoZSBiYXRjaGJ1ZmZlciBjb21tYW5kLiBIZW5jZSB3ZSBuZWVkIHRvIGZpeAo+PiBAQCAt MjQzNCwyMSArMjQ0MiwzMCBAQCBpbnQgX19pOTE1X2FkZF9yZXF1ZXN0KHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKnJpbmcsCj4+ICAgCSAqIGlzIHRoYXQgdGhlIGZsdXNoIF9tdXN0XyBoYXBwZW4g YmVmb3JlIHRoZSBuZXh0IHJlcXVlc3QsIG5vIG1hdHRlcgo+PiAgIAkgKiB3aGF0Lgo+PiAgIAkg Ki8KPj4gLQlpZiAoaTkxNS5lbmFibGVfZXhlY2xpc3RzKSB7Cj4+ICsJaWYgKGk5MTUuZW5hYmxl X2V4ZWNsaXN0cykKPj4gICAJCXJldCA9IGxvZ2ljYWxfcmluZ19mbHVzaF9hbGxfY2FjaGVzKHJp bmdidWYsIHJlcXVlc3QtPmN0eCk7Cj4+IC0JCWlmIChyZXQpCj4+IC0JCQlyZXR1cm4gcmV0Owo+ PiAtCX0gZWxzZSB7Cj4+ICsJZWxzZQo+PiAgIAkJcmV0ID0gaW50ZWxfcmluZ19mbHVzaF9hbGxf Y2FjaGVzKHJpbmcpOwo+PiAtCQlpZiAocmV0KQo+PiAtCQkJcmV0dXJuIHJldDsKPj4gLQl9Cj4+ ICsKPj4gKwlpZiAocmV0KQo+PiArCQlyZXR1cm4gRVJSX1BUUihyZXQpOwo+PiArCj4+ICsJcmV0 dXJuIHJlcXVlc3Q7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyBpbnQgaTkxNV9nZW1fcmVxdWVzdF9z dWJtaXQoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0LAo+PiArCQkJCSAgIHN0 cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpiYXRjaCkKPj4gK3sKPj4gKwlzdHJ1Y3QgaW50ZWxf cmluZ2J1ZmZlciAqcmluZ2J1ZiA9IF9fcmVxdWVzdF90b19yaW5nYnVmKHJlcXVlc3QpOwo+PiAr CXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcgPSByZXF1ZXN0LT5yaW5nOwo+PiArCWludCBy ZXQ7Cj4+ICAgCj4+ICAgCS8qIFJlY29yZCB0aGUgcG9zaXRpb24gb2YgdGhlIHN0YXJ0IG9mIHRo ZSByZXF1ZXN0IHNvIHRoYXQKPj4gICAJICogc2hvdWxkIHdlIGRldGVjdCB0aGUgdXBkYXRlZCBz ZXFubyBwYXJ0LXdheSB0aHJvdWdoIHRoZQo+PiAgIAkgKiBHUFUgcHJvY2Vzc2luZyB0aGUgcmVx dWVzdCwgd2UgbmV2ZXIgb3Zlci1lc3RpbWF0ZSB0aGUKPj4gICAJICogcG9zaXRpb24gb2YgdGhl IGhlYWQuCj4+ICAgCSAqLwo+PiArCXJlcXVlc3QtPmJhdGNoX29iaiA9IGJhdGNoOwo+PiAgIAly ZXF1ZXN0LT5wb3N0Zml4ID0gaW50ZWxfcmluZ19nZXRfdGFpbChyaW5nYnVmKTsKPj4gICAKPj4g ICAJaWYgKGk5MTUuZW5hYmxlX2V4ZWNsaXN0cykgewo+PiBAQCAtMjQ2MSw3ICsyNDc4LDYgQEAg aW50IF9faTkxNV9hZGRfcmVxdWVzdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nLAo+PiAg IAkJCXJldHVybiByZXQ7Cj4+ICAgCX0KPj4gICAKPj4gLQlyZXF1ZXN0LT5oZWFkID0gcmVxdWVz dF9zdGFydDsKPj4gICAJcmVxdWVzdC0+dGFpbCA9IGludGVsX3JpbmdfZ2V0X3RhaWwocmluZ2J1 Zik7Cj4+ICAgCj4+ICAgCS8qIFdoaWxzdCB0aGlzIHJlcXVlc3QgZXhpc3RzLCBiYXRjaF9vYmog d2lsbCBiZSBvbiB0aGUKPj4gQEAgLTI0NzAsMzUgKzI0ODYsNTkgQEAgaW50IF9faTkxNV9hZGRf cmVxdWVzdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nLAo+PiAgIAkgKiBpbmFjdGl2ZV9s aXN0IGFuZCBsb3NlIGl0cyBhY3RpdmUgcmVmZXJlbmNlLiBIZW5jZSB3ZSBkbyBub3QgbmVlZAo+ PiAgIAkgKiB0byBleHBsaWNpdGx5IGhvbGQgYW5vdGhlciByZWZlcmVuY2UgaGVyZS4KPj4gICAJ ICovCj4+IC0JcmVxdWVzdC0+YmF0Y2hfb2JqID0gb2JqOwo+PiAgIAo+PiAtCWlmICghaTkxNS5l bmFibGVfZXhlY2xpc3RzKSB7Cj4+IC0JCS8qIEhvbGQgYSByZWZlcmVuY2UgdG8gdGhlIGN1cnJl bnQgY29udGV4dCBzbyB0aGF0IHdlIGNhbiBpbnNwZWN0Cj4+IC0JCSAqIGl0IGxhdGVyIGluIGNh c2UgYSBoYW5nY2hlY2sgZXJyb3IgZXZlbnQgZmlyZXMuCj4+ICsJaWYgKCFpOTE1LmVuYWJsZV9l eGVjbGlzdHMgJiYgcmVxdWVzdC0+Y3R4KSB7Cj4+ICsJCS8qIEhvbGQgYSByZWZlcmVuY2UgdG8g dGhlIGN1cnJlbnQgY29udGV4dCBzbyB0aGF0IHdlIGNhbgo+PiArCQkgKiBpbnNwZWN0IGl0IGxh dGVyIGluIGNhc2UgYSBoYW5nY2hlY2sgZXJyb3IgZXZlbnQgZmlyZXMuCj4+ICAgCQkgKi8KPj4g LQkJcmVxdWVzdC0+Y3R4ID0gcmluZy0+bGFzdF9jb250ZXh0Owo+PiAtCQlpZiAocmVxdWVzdC0+ Y3R4KQo+PiAtCQkJaTkxNV9nZW1fY29udGV4dF9yZWZlcmVuY2UocmVxdWVzdC0+Y3R4KTsKPj4g KwkJaTkxNV9nZW1fY29udGV4dF9yZWZlcmVuY2UocmVxdWVzdC0+Y3R4KTsKPj4gICAJfQo+PiAg IAo+PiAgIAlyZXF1ZXN0LT5lbWl0dGVkX2ppZmZpZXMgPSBqaWZmaWVzOwo+PiArCj4+ICAgCWxp c3RfYWRkX3RhaWwoJnJlcXVlc3QtPmxpc3QsICZyaW5nLT5yZXF1ZXN0X2xpc3QpOwo+PiAtCXJl cXVlc3QtPmZpbGVfcHJpdiA9IE5VTEw7Cj4+ICsJcmluZy0+b3V0c3RhbmRpbmdfbGF6eV9yZXF1 ZXN0ID0gTlVMTDsKPj4gICAKPj4gLQlpZiAoZmlsZSkgewo+PiAtCQlzdHJ1Y3QgZHJtX2k5MTVf ZmlsZV9wcml2YXRlICpmaWxlX3ByaXYgPSBmaWxlLT5kcml2ZXJfcHJpdjsKPj4gKwl0cmFjZV9p OTE1X2dlbV9yZXF1ZXN0X2FkZChyZXF1ZXN0KTsKPj4gICAKPj4gLQkJc3Bpbl9sb2NrKCZmaWxl X3ByaXYtPm1tLmxvY2spOwo+PiAtCQlyZXF1ZXN0LT5maWxlX3ByaXYgPSBmaWxlX3ByaXY7Cj4+ IC0JCWxpc3RfYWRkX3RhaWwoJnJlcXVlc3QtPmNsaWVudF9saXN0LAo+PiAtCQkJICAgICAgJmZp bGVfcHJpdi0+bW0ucmVxdWVzdF9saXN0KTsKPj4gLQkJc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+ bW0ubG9jayk7Cj4+ICsJcmV0dXJuIDA7Cj4+ICt9Cj4+ICAgCj4+IC0JCXJlcXVlc3QtPnBpZCA9 IGdldF9waWQodGFza19waWQoY3VycmVudCkpOwo+PiAtCX0KPj4gK3N0YXRpYyB2b2lkIGk5MTVf Z2VtX3JlcXVlc3RfYWRkX3RvX2NsaWVudChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJl cXVlc3QpCj4+ICt7Cj4+ICsJc3RydWN0IGRybV9pOTE1X2ZpbGVfcHJpdmF0ZSAqZmlsZV9wcml2 Owo+PiAgIAo+PiAtCXRyYWNlX2k5MTVfZ2VtX3JlcXVlc3RfYWRkKHJlcXVlc3QpOwo+PiAtCXJp bmctPm91dHN0YW5kaW5nX2xhenlfcmVxdWVzdCA9IE5VTEw7Cj4+ICsJaWYgKCFyZXF1ZXN0LT5m aWxlX3ByaXYpCj4+ICsJCXJldHVybjsKPj4gKwo+PiArCWZpbGVfcHJpdiA9IHJlcXVlc3QtPmZp bGVfcHJpdjsKPj4gKwo+PiArCXNwaW5fbG9jaygmZmlsZV9wcml2LT5tbS5sb2NrKTsKPj4gKwly ZXF1ZXN0LT5maWxlX3ByaXYgPSBmaWxlX3ByaXY7Cj4+ICsJbGlzdF9hZGRfdGFpbCgmcmVxdWVz dC0+Y2xpZW50X2xpc3QsCj4+ICsJCSAgICAgICZmaWxlX3ByaXYtPm1tLnJlcXVlc3RfbGlzdCk7 Cj4+ICsJc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+bW0ubG9jayk7Cj4+ICsKPj4gKwlyZXF1ZXN0 LT5waWQgPSBnZXRfcGlkKHRhc2tfcGlkKGN1cnJlbnQpKTsKPj4gK30KPj4gKwo+PiAraW50IF9f aTkxNV9hZGRfcmVxdWVzdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nLAo+PiArCQkgICAg ICAgc3RydWN0IGRybV9maWxlICpmaWxlLAo+PiArCQkgICAgICAgc3RydWN0IGRybV9pOTE1X2dl bV9vYmplY3QgKmJhdGNoKQo+PiArewo+PiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiA9IHJpbmctPmRldi0+ZGV2X3ByaXZhdGU7Cj4+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9y ZXF1ZXN0ICpyZXF1ZXN0Owo+PiArCWludCByZXQ7Cj4+ICsKPj4gKwlyZXF1ZXN0ID0gaTkxNV9n ZW1fcmVxdWVzdF9wcmVwYXJlKHJpbmcsIGZpbGUpOwo+PiArCWlmIChJU19FUlIocmVxdWVzdCkp Cj4+ICsJCXJldHVybiBQVFJfRVJSKHJlcXVlc3QpOwo+PiArCj4+ICsJcmV0ID0gaTkxNV9nZW1f cmVxdWVzdF9zdWJtaXQocmVxdWVzdCwgYmF0Y2gpOwo+PiArCWlmIChyZXQpCj4+ICsJCXJldHVy biByZXQ7Cj4+ICsKPj4gKwlpOTE1X2dlbV9yZXF1ZXN0X2FkZF90b19jbGllbnQocmVxdWVzdCk7 Cj4+ICAgCj4+ICAgCWk5MTVfcXVldWVfaGFuZ2NoZWNrKHJpbmctPmRldik7Cj4+ICAgCj4KPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdm eCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=