Re: [PATCH] drm/i915: remove indirection in the PCI ID macros

From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: remove indirection in the PCI ID macros
Date: Tue, 03 Feb 2015 15:05:05 +0200	[thread overview]
Message-ID: <87zj8vxi0u.fsf@intel.com> (raw)
In-Reply-To: <20150203123928.GF26272@nuc-i3427.alporthouse.com>

On Tue, 03 Feb 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote:
>> Spell all the PCI IDs out to be able to quickly grep for the IDs. No
>> functional changes.
>
> On the other hand this is a loss of contextual information in the header
> file.

I assume the GT count is what you're referring to. I contemplated that,
and decided that I, personally, really value the file as the canonical
place to look at all the supported PCI IDs above all.

Also, I'm pretty sure there's nothing in the specs that make guarantees
about digits in PCI IDs mapping to GT count. My impression is that it's
just an inference on our part, valid for the set of PCI IDs currently in
the file. But this isn't that important.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx