From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/i915/dp: Cache EDID for a detection cycle
Date: Wed, 03 Sep 2014 11:23:09 +0300 [thread overview]
Message-ID: <87zjehgljm.fsf@intel.com> (raw)
In-Reply-To: <1409684643-1569-2-git-send-email-chris@chris-wilson.co.uk>
On Tue, 02 Sep 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> @@ -3819,27 +3819,55 @@ intel_dp_get_edid(struct drm_connector *connector, struct i2c_adapter *adapter)
> return NULL;
>
> return drm_edid_duplicate(intel_connector->edid);
> - }
> + } else
> + return drm_get_edid(&intel_connector->base,
> + &intel_dp->aux.ddc);
Nitpick, I'd like to see braces on all branches if one branch requires
them. Also CodingStyle.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-09-03 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 19:03 [PATCH 1/5] drm/i915/dp: Refactor common eDP lid detection Chris Wilson
2014-09-02 19:04 ` [PATCH 2/5] drm/i915/dp: Cache EDID for a detection cycle Chris Wilson
2014-09-03 8:23 ` Jani Nikula [this message]
2014-09-03 8:45 ` Daniel Vetter
2014-09-03 8:53 ` Chris Wilson
2014-09-03 10:47 ` Jani Nikula
2014-09-02 19:04 ` [PATCH 3/5] drm/i915/hdmi: " Chris Wilson
2014-09-02 19:04 ` [PATCH 4/5] drm/i915/hdmi: Refactor force_audio -> has_audio coupling Chris Wilson
2014-09-02 19:08 ` Chris Wilson
2014-09-03 8:48 ` Daniel Vetter
2014-09-02 19:04 ` [PATCH 5/5] drm/i915/dp: " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjehgljm.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox