From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: 3.13 i915 brightness settings broken when going from docked -> undocked Date: Tue, 04 Mar 2014 10:54:38 +0200 Message-ID: <87zjl64a41.fsf@intel.com> References: <1392882819.5070.15.camel@x220> <878usz8vmi.fsf@intel.com> <1393921876.3038.3.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1393921876.3038.3.camel@x220> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Paul Bolle Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Josh Boyer , "Linux-Kernel@Vger. Kernel. Org" , DRI mailing list List-Id: intel-gfx@lists.freedesktop.org On Tue, 04 Mar 2014, Paul Bolle wrote: > On Tue, 2014-02-25 at 10:05 +0200, Jani Nikula wrote: >> On Thu, 20 Feb 2014, Paul Bolle wrote: >> > On an (rather old) ThinkPad X41, which also uses i915, brightness >> > adjustments stopped working altogether in v3.14-rc1 (I haven't used its >> > docking station in the v3.14 release cycle). In v3.13.y things behave as >> > expected. So perhaps there's actually a more general problem here. >> >> I presume different problems. Does the ThinkPad X41 have gen3 graphics? >> (See e.g. /sys/kernel/debug/dri/0/i915_capabilities) If yes, it might be >> https://bugs.freedesktop.org/show_bug.cgi?id=75001 > > Yes, it has "gen3" graphics (a 915GM). And applying your patch > "drm/i915: use backlight legacy combination mode also for > i915gm/i945/gm" on top of v3.14-rc5 fixes the issue on that ThinkPad > X41. Thanks for confirming this on i915gm too. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center