From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Eliminate lots of WARNs when there's no backlight present Date: Fri, 17 Jan 2014 13:30:59 +0200 Message-ID: <87zjmu7slo.fsf@intel.com> References: <1389889635-27623-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B7D3FD433 for ; Fri, 17 Jan 2014 03:27:46 -0800 (PST) In-Reply-To: <1389889635-27623-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxNiBKYW4gMjAxNCwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pgo+IE15IDg1NWdtIGRvZXNuJ3QgcmVnaXN0ZXIgdGhlIGludGVsIGJhY2tsaWdodCBidXQgaXQg c3RpbGwgZW5kcyB1cAo+IGNhbGxpbmcgdGhlIGJhY2tsaWdodCBjb2RlIHRvIGVuYWJsZS9kaXNh YmxlIHRoZSBiYWNrbGlnaHQgdmlhIHRoZQo+IExWRFMgY29kZS4gVGhpcyBsZWFkcyB0byBzb21l IFdBUk5zIGR1ZSB0byBiYWNrbGlnaHQubWF4IGJlaW5nIDAuCj4KPiBMZXQncyBoYXZlIGludGVs X3BhbmVsX2VuYWJsZV9iYWNrbGlnaHQoKSBhbmQgaW50ZWxfcGFuZWxfZGlzYWJsZV9iYWNrbGln aHQoKQo+IGNoZWNrIHdoZXRoZXIgdGhlcmUncyBhIGJhY2tsaWdodCBwcmVzZW50IG9yIG5vdC4K Pgo+IEFsc28gbW92ZSB0aGUgYmFja2xpZ2h0LnByZXNlbnQgY2hlY2sgZnJvbSBhc2xlX3NldF9i YWNrbGlnaHQoKSBpbnRvCj4gaW50ZWxfcGFuZWxfc2V0X2JhY2tsaWdodCgpIGZvciBzb21lIGV4 dHJhIHN5bW1ldHJ5LgoKSSBoYXZlIGFuIGlkZW50aWNhbCBwYXRjaCBpbiBteSBsb2NhbCByZXBv IGRhdGVkIERlYyAxMy4uLiBzaG91bGQndmUKc2VudCBpdCBvdXQgd2Vla3MgYWdvLiBEYW1uLgoK UmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cgo+IFNpZ25l ZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX29wcmVnaW9uLmMgfCAxMCArKy0t LS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMgICAgfCAgNiArKyst LS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+ Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX29wcmVnaW9uLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9vcHJlZ2lvbi5jCj4gaW5kZXggM2RhMjU5ZS4uMzdl OWE5NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9vcHJlZ2lvbi5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ByZWdpb24uYwo+IEBAIC0zOTYs OSArMzk2LDcgQEAgaW50IGludGVsX29wcmVnaW9uX25vdGlmeV9hZGFwdGVyKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsIHBjaV9wb3dlcl90IHN0YXRlKQo+ICBzdGF0aWMgdTMyIGFzbGVfc2V0X2Jh Y2tsaWdodChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1MzIgYmNscCkKPiAgewo+ICAJc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCXN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gIAlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpp bnRlbF9jb25uZWN0b3I7Cj4gLQlzdHJ1Y3QgaW50ZWxfcGFuZWwgKnBhbmVsOwo+ICAJc3RydWN0 IG9wcmVnaW9uX2FzbGUgX19pb21lbSAqYXNsZSA9IGRldl9wcml2LT5vcHJlZ2lvbi5hc2xlOwo+ ICAKPiAgCURSTV9ERUJVR19EUklWRVIoImJjbHAgPSAweCUwOHhcbiIsIGJjbHApOwo+IEBAIC00 MTcsMTIgKzQxNSw4IEBAIHN0YXRpYyB1MzIgYXNsZV9zZXRfYmFja2xpZ2h0KHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsIHUzMiBiY2xwKQo+ICAJICogb25seSBvbmUpLgo+ICAJICovCj4gIAlEUk1f REVCVUdfS01TKCJ1cGRhdGluZyBvcHJlZ2lvbiBiYWNrbGlnaHQgJWQvMjU1XG4iLCBiY2xwKTsK PiAtCWxpc3RfZm9yX2VhY2hfZW50cnkoY29ubmVjdG9yLCAmZGV2LT5tb2RlX2NvbmZpZy5jb25u ZWN0b3JfbGlzdCwgaGVhZCkgewo+IC0JCWludGVsX2Nvbm5lY3RvciA9IHRvX2ludGVsX2Nvbm5l Y3Rvcihjb25uZWN0b3IpOwo+IC0JCXBhbmVsID0gJmludGVsX2Nvbm5lY3Rvci0+cGFuZWw7Cj4g LQkJaWYgKHBhbmVsLT5iYWNrbGlnaHQucHJlc2VudCkKPiAtCQkJaW50ZWxfcGFuZWxfc2V0X2Jh Y2tsaWdodChpbnRlbF9jb25uZWN0b3IsIGJjbHAsIDI1NSk7Cj4gLQl9Cj4gKwlsaXN0X2Zvcl9l YWNoX2VudHJ5KGludGVsX2Nvbm5lY3RvciwgJmRldi0+bW9kZV9jb25maWcuY29ubmVjdG9yX2xp c3QsIGJhc2UuaGVhZCkKPiArCQlpbnRlbF9wYW5lbF9zZXRfYmFja2xpZ2h0KGludGVsX2Nvbm5l Y3RvciwgYmNscCwgMjU1KTsKPiAgCWlvd3JpdGUzMihESVZfUk9VTkRfVVAoYmNscCAqIDEwMCwg MjU1KSB8IEFTTEVfQ0JMVl9WQUxJRCwgJmFzbGUtPmNibHYpOwo+ICAKPiAgCW11dGV4X3VubG9j aygmZGV2LT5tb2RlX2NvbmZpZy5tdXRleCk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3BhbmVsLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5j Cj4gaW5kZXggMjBlYmMzZS4uMzUwZGUzNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wYW5lbC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFu ZWwuYwo+IEBAIC01MDIsNyArNTAyLDcgQEAgdm9pZCBpbnRlbF9wYW5lbF9zZXRfYmFja2xpZ2h0 KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciwgdTMyIGxldmVsLAo+ICAJdTMyIGZy ZXE7Cj4gIAl1bnNpZ25lZCBsb25nIGZsYWdzOwo+ICAKPiAtCWlmIChwaXBlID09IElOVkFMSURf UElQRSkKPiArCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50IHx8IHBpcGUgPT0gSU5WQUxJ RF9QSVBFKQo+ICAJCXJldHVybjsKPiAgCj4gIAlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2X3ByaXYt PmJhY2tsaWdodF9sb2NrLCBmbGFncyk7Cj4gQEAgLTU3OSw3ICs1NzksNyBAQCB2b2lkIGludGVs X3BhbmVsX2Rpc2FibGVfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3Rv cikKPiAgCWVudW0gcGlwZSBwaXBlID0gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3IoY29u bmVjdG9yKTsKPiAgCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gIAo+IC0JaWYgKHBpcGUgPT0gSU5W QUxJRF9QSVBFKQo+ICsJaWYgKCFwYW5lbC0+YmFja2xpZ2h0LnByZXNlbnQgfHwgcGlwZSA9PSBJ TlZBTElEX1BJUEUpCj4gIAkJcmV0dXJuOwo+ICAKPiAgCS8qCj4gQEAgLTc4Miw3ICs3ODIsNyBA QCB2b2lkIGludGVsX3BhbmVsX2VuYWJsZV9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3Rv ciAqY29ubmVjdG9yKQo+ICAJZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9nZXRfcGlwZV9mcm9tX2Nv bm5lY3Rvcihjb25uZWN0b3IpOwo+ICAJdW5zaWduZWQgbG9uZyBmbGFnczsKPiAgCj4gLQlpZiAo cGlwZSA9PSBJTlZBTElEX1BJUEUpCj4gKwlpZiAoIXBhbmVsLT5iYWNrbGlnaHQucHJlc2VudCB8 fCBwaXBlID09IElOVkFMSURfUElQRSkKPiAgCQlyZXR1cm47Cj4gIAo+ICAJRFJNX0RFQlVHX0tN UygicGlwZSAlY1xuIiwgcGlwZV9uYW1lKHBpcGUpKTsKPiAtLSAKPiAxLjguMy4yCj4KPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBt YWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkphbmkg TmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=