From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v7] drm/i915/execlists: Direct submission of new requests (avoid tasklet/ksoftirqd) Date: Thu, 28 Jun 2018 14:59:20 +0100 Message-ID: <889f624c-ff90-c5df-74c9-b86f44bbb064@linux.intel.com> References: <20180628123351.31240-9-chris@chris-wilson.co.uk> <20180628131155.31858-1-chris@chris-wilson.co.uk> <748ff973-2d1e-4ad2-eac4-cecd4fab2fd8@linux.intel.com> <153019251194.8693.15386235509479306119@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6333C6EDDB for ; Thu, 28 Jun 2018 13:59:22 +0000 (UTC) In-Reply-To: <153019251194.8693.15386235509479306119@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI4LzA2LzIwMTggMTQ6MjgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA2LTI4IDE0OjIxOjA2KQo+Pgo+PiBPbiAyOC8wNi8yMDE4IDE0OjEx LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiArLyoKPj4+ICsgKiBDaGVjayB0aGUgdW5yZWFkIENv bnRleHQgU3RhdHVzIEJ1ZmZlcnMgYW5kIG1hbmFnZSB0aGUgc3VibWlzc2lvbiBvZiBuZXcKPj4+ ICsgKiBjb250ZXh0cyB0byB0aGUgRUxTUCBhY2NvcmRpbmdseS4KPj4+ICsgKi8KPj4+ICtzdGF0 aWMgdm9pZCBleGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0KHVuc2lnbmVkIGxvbmcgZGF0YSkK Pj4+ICt7Cj4+PiArICAgICBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICogY29uc3QgZW5naW5lID0g KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKilkYXRhOwo+Pj4gKyAgICAgdW5zaWduZWQgbG9uZyBm bGFnczsKPj4+ICsKPj4+ICsgICAgIEdFTV9UUkFDRSgiJXMgYXdha2U/PSVkLCBhY3RpdmU9JXhc biIsCj4+PiArICAgICAgICAgICAgICAgZW5naW5lLT5uYW1lLAo+Pj4gKyAgICAgICAgICAgICAg IGVuZ2luZS0+aTkxNS0+Z3QuYXdha2UsCj4+PiArICAgICAgICAgICAgICAgZW5naW5lLT5leGVj bGlzdHMuYWN0aXZlKTsKPj4+ICsKPj4+ICsgICAgIHNwaW5fbG9ja19pcnFzYXZlKCZlbmdpbmUt PnRpbWVsaW5lLmxvY2ssIGZsYWdzKTsKPj4+ICsKPj4+ICsgICAgIGlmIChlbmdpbmUtPmk5MTUt Pmd0LmF3YWtlKSAvKiB3ZSBtYXkgYmUgZGVsYXllZCB1bnRpbCBhZnRlciB3ZSBpZGxlISAqLwo+ Pgo+PiBObyByYWNlcyBiZXR3ZWVuIHRoZSBjaGVjayBhbmQgdGFza2xldCBjYWxsPyBJbiBvdGhl ciB3b3JkcyB0aGUgY29kZQo+PiBwYXRoIHdoaWNoIHlvdSB3ZXJlIGRlc2NyaWJpbmcgdGhhdCBj YW4gcmFjZSBpcyB0YWtpbmcgdGhlIHRpbWVsaW5lIGxvY2s/Cj4gCj4gaW50ZWxfZW5naW5lX2lz X2lkbGUoKSBpcyB1bnNlcmlhbGlzZWQuCgpPa2F5LCB0aGluayBJIHVuZGVyc3RhbmQuIFNoaXAg aXQhCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNv bT4KClJlZ2FyZHMsCgpUdnJ0a28KCj4+PiArICAgICAgICAgICAgIF9fZXhlY2xpc3RzX3N1Ym1p c3Npb25fdGFza2xldChlbmdpbmUpOwo+Pj4gKwo+Pj4gKyAgICAgc3Bpbl91bmxvY2tfaXJxcmVz dG9yZSgmZW5naW5lLT50aW1lbGluZS5sb2NrLCBmbGFncyk7Cj4+PiArfQo+Pj4gKwo+Pj4gICAg c3RhdGljIHZvaWQgcXVldWVfcmVxdWVzdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUs Cj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGk5MTVfc2NoZWRfbm9kZSAqbm9k ZSwKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgcHJpbykKPj4+IEBAIC0xMTQ0LDE2 ICsxMTU1LDMwIEBAIHN0YXRpYyB2b2lkIHF1ZXVlX3JlcXVlc3Qoc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqZW5naW5lLAo+Pj4gICAgICAgICAgICAgICAgICAgICAgJmxvb2t1cF9wcmlvbGlzdChl bmdpbmUsIHByaW8pLT5yZXF1ZXN0cyk7Cj4+PiAgICB9Cj4+PiAgICAKPj4+IC1zdGF0aWMgdm9p ZCBfX3N1Ym1pdF9xdWV1ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsIGludCBwcmlv KQo+Pj4gK3N0YXRpYyB2b2lkIF9fdXBkYXRlX3F1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSwgaW50IHByaW8pCj4+PiAgICB7Cj4+PiAgICAgICAgZW5naW5lLT5leGVjbGlzdHMu cXVldWVfcHJpb3JpdHkgPSBwcmlvOwo+Pj4gLSAgICAgdGFza2xldF9oaV9zY2hlZHVsZSgmZW5n aW5lLT5leGVjbGlzdHMudGFza2xldCk7Cj4+PiArfQo+Pj4gKwo+Pj4gK3N0YXRpYyB2b2lkIF9f c3VibWl0X3F1ZXVlX2ltbShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+PiArewo+ Pj4gKyAgICAgc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlzdHMgKiBjb25zdCBleGVjbGlzdHMg PSAmZW5naW5lLT5leGVjbGlzdHM7Cj4+PiArCj4+PiArICAgICBpZiAocmVzZXRfaW5fcHJvZ3Jl c3MoZXhlY2xpc3RzKSkKPj4+ICsgICAgICAgICAgICAgcmV0dXJuOyAvKiBkZWZlciB1bnRpbCB3 ZSByZXN0YXJ0IHRoZSBlbmdpbmUgZm9sbG93aW5nIHJlc2V0ICovCj4+Cj4+IFdlIGhhdmUgYSB0 YXNrbGV0IGtpY2sgc29tZXdoZXJlIGluIHRoYXQgcGF0aD8KPiAKPiBJbiBleGVjbGlzdHNfcmVz ZXRfZmluaXNoKCkKPiAKPj4+ICsgICAgIGlmIChleGVjbGlzdHMtPnRhc2tsZXQuZnVuYyA9PSBl eGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0KQo+Pj4gKyAgICAgICAgICAgICBfX2V4ZWNsaXN0 c19zdWJtaXNzaW9uX3Rhc2tsZXQoZW5naW5lKTsKPj4+ICsgICAgIGVsc2UKPj4+ICsgICAgICAg ICAgICAgdGFza2xldF9oaV9zY2hlZHVsZSgmZXhlY2xpc3RzLT50YXNrbGV0KTsKPj4+ICAgIH0K Pj4+ICAgIAo+Pj4gICAgc3RhdGljIHZvaWQgc3VibWl0X3F1ZXVlKHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKmVuZ2luZSwgaW50IHByaW8pCj4+PiAgICB7Cj4+PiAtICAgICBpZiAocHJpbyA+IGVu Z2luZS0+ZXhlY2xpc3RzLnF1ZXVlX3ByaW9yaXR5KQo+Pj4gLSAgICAgICAgICAgICBfX3N1Ym1p dF9xdWV1ZShlbmdpbmUsIHByaW8pOwo+Pj4gKyAgICAgaWYgKHByaW8gPiBlbmdpbmUtPmV4ZWNs aXN0cy5xdWV1ZV9wcmlvcml0eSkgewo+Pj4gKyAgICAgICAgICAgICBfX3VwZGF0ZV9xdWV1ZShl bmdpbmUsIHByaW8pOwo+Pj4gKyAgICAgICAgICAgICBfX3N1Ym1pdF9xdWV1ZV9pbW0oZW5naW5l KTsKPj4+ICsgICAgIH0KPj4+ICAgIH0KPj4+ICAgIAo+Pj4gICAgc3RhdGljIHZvaWQgZXhlY2xp c3RzX3N1Ym1pdF9yZXF1ZXN0KHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJlcXVlc3QpCj4+PiBAQCAt MTE2NSwxMSArMTE5MCwxMiBAQCBzdGF0aWMgdm9pZCBleGVjbGlzdHNfc3VibWl0X3JlcXVlc3Qo c3RydWN0IGk5MTVfcmVxdWVzdCAqcmVxdWVzdCkKPj4+ICAgICAgICBzcGluX2xvY2tfaXJxc2F2 ZSgmZW5naW5lLT50aW1lbGluZS5sb2NrLCBmbGFncyk7Cj4+PiAgICAKPj4+ICAgICAgICBxdWV1 ZV9yZXF1ZXN0KGVuZ2luZSwgJnJlcXVlc3QtPnNjaGVkLCBycV9wcmlvKHJlcXVlc3QpKTsKPj4+ IC0gICAgIHN1Ym1pdF9xdWV1ZShlbmdpbmUsIHJxX3ByaW8ocmVxdWVzdCkpOwo+Pj4gICAgCj4+ PiAgICAgICAgR0VNX0JVR19PTighZW5naW5lLT5leGVjbGlzdHMuZmlyc3QpOwo+Pj4gICAgICAg IEdFTV9CVUdfT04obGlzdF9lbXB0eSgmcmVxdWVzdC0+c2NoZWQubGluaykpOwo+Pj4gICAgCj4+ PiArICAgICBzdWJtaXRfcXVldWUoZW5naW5lLCBycV9wcmlvKHJlcXVlc3QpKTsKPj4+ICsKPj4+ ICAgICAgICBzcGluX3VubG9ja19pcnFyZXN0b3JlKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2ssIGZs YWdzKTsKPj4+ICAgIH0KPj4+ICAgIAo+Pj4gQEAgLTEyOTYsOCArMTMyMiwxMSBAQCBzdGF0aWMg dm9pZCBleGVjbGlzdHNfc2NoZWR1bGUoc3RydWN0IGk5MTVfcmVxdWVzdCAqcmVxdWVzdCwKPj4+ ICAgICAgICAgICAgICAgIH0KPj4+ICAgIAo+Pj4gICAgICAgICAgICAgICAgaWYgKHByaW8gPiBl bmdpbmUtPmV4ZWNsaXN0cy5xdWV1ZV9wcmlvcml0eSAmJgo+Pj4gLSAgICAgICAgICAgICAgICAg aTkxNV9zd19mZW5jZV9kb25lKCZzY2hlZF90b19yZXF1ZXN0KG5vZGUpLT5zdWJtaXQpKQo+Pj4g LSAgICAgICAgICAgICAgICAgICAgIF9fc3VibWl0X3F1ZXVlKGVuZ2luZSwgcHJpbyk7Cj4+PiAr ICAgICAgICAgICAgICAgICBpOTE1X3N3X2ZlbmNlX2RvbmUoJnNjaGVkX3RvX3JlcXVlc3Qobm9k ZSktPnN1Ym1pdCkpIHsKPj4+ICsgICAgICAgICAgICAgICAgICAgICAvKiBkZWZlciBzdWJtaXNz aW9uIHVudGlsIGFmdGVyIGFsbCBvZiBvdXIgdXBkYXRlcyAqLwo+Pj4gKyAgICAgICAgICAgICAg ICAgICAgIF9fdXBkYXRlX3F1ZXVlKGVuZ2luZSwgcHJpbyk7Cj4+PiArICAgICAgICAgICAgICAg ICAgICAgdGFza2xldF9oaV9zY2hlZHVsZSgmZW5naW5lLT5leGVjbGlzdHMudGFza2xldCk7Cj4+ Cj4+IF9pbW0gc3VmZml4IG9uIF9fc3VibWl0X3F1ZXVlX2ltbSBzb3VuZHMgdW51c2VkIGlmIHRo ZXJlIGlzIG5vIHBsYWluCj4+IF9fc3VibWl0X3F1ZXVlLCB3aGljaCBjb3VsZCBoYXZlIGJlZW4g dXNlZCBoZXJlLiBCdXQgbWVoLgo+IAo+IEkgdGhvdWdodCBvZiB0cnlpbmcgdG8gZW1waGFzaXMg dGhlIGltbWVkaWF0ZSBuYXR1cmUgb2YgdGhpcyBwYXRoLiBJdCdzCj4gbm90IGEgaHVnZSBkZWFs LCBidXQgSSBkaWRuJ3QgcGFydGljdWxhcmx5IGxpa2UgY2FsbGluZyBpdAo+IGRpcmVjdF9zdWJt aXRfcXVldWUoKSAob3IganVzdCBkaXJlY3Rfc3VibWl0KCksIHRvbyBtYW55IHN1Ym1pdHMhKQo+ IF9fIHByZWZpeCB0byBpbmRpY2F0ZSB0aGF0IGl0J3MgYW4gaW5uZXIgZnVuY3Rpb24gdG8gc3Vi bWl0X3F1ZXVlLAo+IF9pbW0gc3VmZml4IHRvIGluZGljYXRlIHdoYXQncyBzcGVjaWFsLgo+IC1D aHJpcwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK