[PATCH] Add jobserver flag (+) to deb-pkg build commands

[PATCH] Add jobserver flag (+) to deb-pkg build commands

[Dave Gordon]

This gets rid of some annoying warnings and allows GNU make to parallelise more
parts of a deb-pkg build. The message is ...

make[3]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.

... so I've added the '+' as suggested.

Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
---
 scripts/package/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/package/Makefile b/scripts/package/Makefile
index 99ca6e7..0dbfae7 100644
--- a/scripts/package/Makefile
+++ b/scripts/package/Makefile
@@ -88,7 +88,7 @@ quiet_cmd_builddeb = BUILDDEB
 
 deb-pkg: FORCE
 	$(MAKE) KBUILD_SRC=
-	$(call cmd,builddeb)
+	+$(call cmd,builddeb)
 
 clean-dirs += $(objtree)/debian/
 
-- 
1.7.9.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] Add jobserver flag (+) to deb-pkg build commands

[shuang.he]

Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                                  354/354              354/354
ILK                                  354/354              354/354
SNB                 -17              418/439              401/439
IVB                                  488/488              488/488
BYT                                  278/280              278/280
HSW              +2-41              530/536              491/536
BDW                 -1              406/406              405/406
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
 SNB  igt_kms_flip_event_leak      NSPT(2, M22M35)PASS(1, M35)      NSPT(1, M22)
*SNB  igt_gem_concurrent_blit_gtt-bcs-early-read-forked      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gtt-bcs-gpu-read-after-write-forked      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gtt-bcs-overwrite-source-forked      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gtt-bcs-overwrite-source-interruptible      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gtt-rcs-early-read-forked      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gtt-rcs-early-read-interruptible      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gtt-rcs-gpu-read-after-write-forked      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gtt-rcs-gpu-read-after-write-interruptible      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gtt-rcs-overwrite-source-forked      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gtt-rcs-overwrite-source-interruptible      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gttX-bcs-early-read-interruptible      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gttX-bcs-gpu-read-after-write-interruptible      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gttX-bcs-overwrite-source-forked      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gttX-bcs-overwrite-source-interruptible      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gttX-rcs-overwrite-source-forked      PASS(3, M35M22)      DMESG_WARN(1, M22)
*SNB  igt_gem_concurrent_blit_gttX-rcs-overwrite-source-interruptible      PASS(3, M35M22)      DMESG_WARN(1, M22)
 HSW  igt_kms_cursor_crc_cursor-size-change      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_kms_fence_pin_leak      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_kms_flip_dpms-vs-vblank-race      DMESG_WARN(1, M40)PASS(2, M40M19)      PASS(1, M40)
 HSW  igt_kms_flip_event_leak      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_kms_flip_flip-vs-dpms-off-vs-modeset      DMESG_WARN(1, M40)PASS(2, M40M19)      PASS(1, M40)
 HSW  igt_kms_mmio_vs_cs_flip_setcrtc_vs_cs_flip      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_kms_mmio_vs_cs_flip_setplane_vs_cs_flip      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_lpsp_non-edp      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_cursor      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_cursor-dpms      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_dpms-mode-unset-non-lpsp      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_dpms-non-lpsp      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_drm-resources-equal      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_fences      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_fences-dpms      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_gem-execbuf      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_gem-mmap-cpu      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_gem-mmap-gtt      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_gem-pread      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_i2c      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_modeset-non-lpsp      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_modeset-non-lpsp-stress-no-wait      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_pci-d3-state      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_pm_rpm_rte      NSPT(2, M40M19)PASS(1, M40)      NSPT(1, M40)
 HSW  igt_gem_concurrent_blit_gtt-bcs-early-read-forked      DMESG_WARN(2, M40M19)PASS(1, M40)      DMESG_WARN(1, M40)
 HSW  igt_gem_concurrent_blit_gtt-bcs-early-read-interruptible      DMESG_WARN(1, M40)PASS(1, M40)      DMESG_WARN(1, M40)
 HSW  igt_gem_concurrent_blit_gtt-bcs-gpu-read-after-write-forked      DMESG_WARN(1, M40)PASS(1, M40)      DMESG_WARN(1, M40)
 HSW  igt_gem_concurrent_blit_gtt-bcs-gpu-read-after-write-interruptible      DMESG_WARN(1, M40)PASS(1, M40)      DMESG_WARN(1, M40)
 HSW  igt_gem_concurrent_blit_gtt-bcs-overwrite-source-forked      DMESG_WARN(1, M40)PASS(1, M40)      DMESG_WARN(1, M40)
 HSW  igt_gem_concurrent_blit_gtt-bcs-overwrite-source-interruptible      DMESG_WARN(1, M40)PASS(1, M40)      DMESG_WARN(1, M40)
 HSW  igt_gem_concurrent_blit_gtt-rcs-early-read-forked      DMESG_WARN(1, M40)PASS(1, M40)      DMESG_WARN(1, M40)
 HSW  igt_gem_concurrent_blit_gtt-rcs-early-read-interruptible      DMESG_WARN(1, M40)PASS(1, M40)      DMESG_WARN(1, M40)
 HSW  igt_gem_concurrent_blit_gtt-rcs-gpu-read-after-write-forked      DMESG_WARN(1, M40)PASS(1, M40)      DMESG_WARN(1, M40)
 HSW  igt_gem_concurrent_blit_gtt-rcs-overwrite-source-forked      DMESG_WARN(1, M40)PASS(1, M40)      DMESG_WARN(1, M40)
 HSW  igt_gem_concurrent_blit_gtt-rcs-overwrite-source-interruptible      DMESG_WARN(1, M40)PASS(1, M40)      DMESG_WARN(1, M40)
 HSW  igt_gem_concurrent_blit_gttX-bcs-early-read-interruptible      DMESG_WARN(1, M40)PASS(1, M40)      DMESG_WARN(1, M40)
*HSW  igt_gem_concurrent_blit_gttX-bcs-gpu-read-after-write-interruptible      PASS(1, M40)      DMESG_WARN(1, M40)
*HSW  igt_gem_concurrent_blit_gttX-bcs-overwrite-source-forked      PASS(1, M40)      DMESG_WARN(1, M40)
*HSW  igt_gem_concurrent_blit_gttX-bcs-overwrite-source-interruptible      PASS(1, M40)      DMESG_WARN(1, M40)
*HSW  igt_gem_concurrent_blit_gttX-rcs-early-read-interruptible      PASS(1, M40)      DMESG_WARN(1, M40)
*HSW  igt_gem_concurrent_blit_gttX-rcs-gpu-read-after-write-interruptible      PASS(1, M40)      DMESG_WARN(1, M40)
*HSW  igt_gem_concurrent_blit_gttX-rcs-overwrite-source-forked      PASS(1, M40)      DMESG_WARN(1, M40)
*HSW  igt_gem_concurrent_blit_gttX-rcs-overwrite-source-interruptible      PASS(1, M40)      DMESG_WARN(1, M40)
*BDW  igt_gem_concurrent_blit_gtt-bcs-early-read-interruptible      PASS(2, M30M28)      DMESG_WARN(1, M28)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] Add jobserver flag (+) to deb-pkg build commands

[Dave Gordon]

On 09/01/15 16:14, Gordon, David S wrote:
> This gets rid of some annoying warnings and allows GNU make to parallelise more
> parts of a deb-pkg build. The message is ...
> 
> make[3]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
> 
> ... so I've added the '+' as suggested.
> 
> Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
> ---
>  scripts/package/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/package/Makefile b/scripts/package/Makefile
> index 99ca6e7..0dbfae7 100644
> --- a/scripts/package/Makefile
> +++ b/scripts/package/Makefile
> @@ -88,7 +88,7 @@ quiet_cmd_builddeb = BUILDDEB
>  
>  deb-pkg: FORCE
>  	$(MAKE) KBUILD_SRC=
> -	$(call cmd,builddeb)
> +	+$(call cmd,builddeb)
>  
>  clean-dirs += $(objtree)/debian/

FYI: this speeds up the deb-pkg part of the build by ~10% on my desktop
machine (8-core i7) when using my usual "-j16" option (rule-of-thumb: 2
jobs per core). YMMV; it should be an even bigger win on more parallel
machines, as without it all the targets within deb-pkg are run serially.

.Dave.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx