* [PATCH] drm: Adding edp1.4 specific dpcd macros
@ 2015-02-19 7:46 Sonika Jindal
2015-02-19 10:31 ` shuang.he
2015-02-19 17:46 ` Todd Previte
0 siblings, 2 replies; 6+ messages in thread
From: Sonika Jindal @ 2015-02-19 7:46 UTC (permalink / raw)
To: intel-gfx, dri-devel
Adding dpcd macros related to edp1.4 and link rates
v2: Added DP_SUPPORTED_LINK_RATES macros
Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
---
include/drm/drm_dp_helper.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 11f8c84..77a55e2 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -92,6 +92,9 @@
# define DP_MSA_TIMING_PAR_IGNORED (1 << 6) /* eDP */
# define DP_OUI_SUPPORT (1 << 7)
+#define DP_SUPPORTED_LINK_RATES 0x010 /*eDP 1.4*/
+#define DP_MAX_SUPPORTED_RATES 0x8
+
#define DP_I2C_SPEED_CAP 0x00c /* DPI */
# define DP_I2C_SPEED_1K 0x01
# define DP_I2C_SPEED_5K 0x02
@@ -101,6 +104,7 @@
# define DP_I2C_SPEED_1M 0x20
#define DP_EDP_CONFIGURATION_CAP 0x00d /* XXX 1.2? */
+# define DP_DPCD_DISPLAY_CONTROL_CAPABLE (1 << 3) /* edp v1.2 or higher */
#define DP_TRAINING_AUX_RD_INTERVAL 0x00e /* XXX 1.2? */
/* Multiple stream transport */
@@ -221,6 +225,8 @@
# define DP_UP_REQ_EN (1 << 1)
# define DP_UPSTREAM_IS_SRC (1 << 2)
+#define DP_LINK_RATE_SET 0x115
+
#define DP_PSR_EN_CFG 0x170 /* XXX 1.2? */
# define DP_PSR_ENABLE (1 << 0)
# define DP_PSR_MAIN_LINK_ACTIVE (1 << 1)
@@ -332,6 +338,8 @@
# define DP_SET_POWER_D3 0x2
# define DP_SET_POWER_MASK 0x3
+#define DP_EDP_DPCD_REV 0x700
+
#define DP_SIDEBAND_MSG_DOWN_REQ_BASE 0x1000 /* 1.2 MST */
#define DP_SIDEBAND_MSG_UP_REP_BASE 0x1200 /* 1.2 MST */
#define DP_SIDEBAND_MSG_DOWN_REP_BASE 0x1400 /* 1.2 MST */
--
1.7.10.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Adding edp1.4 specific dpcd macros
2015-02-19 7:46 [PATCH] drm: Adding edp1.4 specific dpcd macros Sonika Jindal
@ 2015-02-19 10:31 ` shuang.he
2015-02-19 17:46 ` Todd Previte
1 sibling, 0 replies; 6+ messages in thread
From: shuang.he @ 2015-02-19 10:31 UTC (permalink / raw)
To: shuang.he, ethan.gao, intel-gfx, sonika.jindal
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 5793
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -7 277/277 270/277
ILK 313/313 313/313
SNB 309/309 309/309
IVB 382/382 382/382
BYT 296/296 296/296
HSW 425/425 425/425
BDW -1 318/318 317/318
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*PNV igt_gem_evict_everything_minor-normal PASS(2) DMESG_WARN(1)PASS(1)
*PNV igt_gem_fence_thrash_bo-write-verify-none NRUN(1)PASS(5) FAIL(1)PASS(1)
*PNV igt_gem_fence_thrash_bo-write-verify-x PASS(6) FAIL(1)PASS(1)
*PNV igt_gem_fence_thrash_bo-write-verify-y NO_RESULT(1)PASS(5) FAIL(1)PASS(1)
*PNV igt_gem_set_tiling_vs_blt_tiled-to-tiled PASS(2) FAIL(1)PASS(1)
*PNV igt_gem_set_tiling_vs_blt_tiled-to-untiled PASS(3) FAIL(1)PASS(1)
PNV igt_gem_userptr_blits_coherency-sync NO_RESULT(1)CRASH(3)PASS(4) CRASH(2)
*BDW igt_gem_gtt_hog PASS(11) DMESG_WARN(1)PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Adding edp1.4 specific dpcd macros
2015-02-19 7:46 [PATCH] drm: Adding edp1.4 specific dpcd macros Sonika Jindal
2015-02-19 10:31 ` shuang.he
@ 2015-02-19 17:46 ` Todd Previte
2015-02-20 8:25 ` Jani Nikula
1 sibling, 1 reply; 6+ messages in thread
From: Todd Previte @ 2015-02-19 17:46 UTC (permalink / raw)
To: intel-gfx
Just some formatting issues that need to be cleaned up. Otherwise the
definitions look correct according to the eDP 1.4 spec.
-T
On 2/19/15 12:46 AM, Sonika Jindal wrote:
> Adding dpcd macros related to edp1.4 and link rates
>
> v2: Added DP_SUPPORTED_LINK_RATES macros
>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> ---
> include/drm/drm_dp_helper.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 11f8c84..77a55e2 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -92,6 +92,9 @@
> # define DP_MSA_TIMING_PAR_IGNORED (1 << 6) /* eDP */
> # define DP_OUI_SUPPORT (1 << 7)
>
> +#define DP_SUPPORTED_LINK_RATES 0x010 /*eDP 1.4*/
> +#define DP_MAX_SUPPORTED_RATES 0x8
> +
Extra blank line
> #define DP_I2C_SPEED_CAP 0x00c /* DPI */
> # define DP_I2C_SPEED_1K 0x01
> # define DP_I2C_SPEED_5K 0x02
> @@ -101,6 +104,7 @@
> # define DP_I2C_SPEED_1M 0x20
>
> #define DP_EDP_CONFIGURATION_CAP 0x00d /* XXX 1.2? */
> +# define DP_DPCD_DISPLAY_CONTROL_CAPABLE (1 << 3) /* edp v1.2 or higher */
Remove the space between # and define.
> #define DP_TRAINING_AUX_RD_INTERVAL 0x00e /* XXX 1.2? */
>
> /* Multiple stream transport */
> @@ -221,6 +225,8 @@
> # define DP_UP_REQ_EN (1 << 1)
> # define DP_UPSTREAM_IS_SRC (1 << 2)
>
> +#define DP_LINK_RATE_SET 0x115
> +
Extra blank line
> #define DP_PSR_EN_CFG 0x170 /* XXX 1.2? */
> # define DP_PSR_ENABLE (1 << 0)
> # define DP_PSR_MAIN_LINK_ACTIVE (1 << 1)
> @@ -332,6 +338,8 @@
> # define DP_SET_POWER_D3 0x2
> # define DP_SET_POWER_MASK 0x3
>
> +#define DP_EDP_DPCD_REV 0x700
> +
Extra blank line
> #define DP_SIDEBAND_MSG_DOWN_REQ_BASE 0x1000 /* 1.2 MST */
> #define DP_SIDEBAND_MSG_UP_REP_BASE 0x1200 /* 1.2 MST */
> #define DP_SIDEBAND_MSG_DOWN_REP_BASE 0x1400 /* 1.2 MST */
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Adding edp1.4 specific dpcd macros
2015-02-19 17:46 ` Todd Previte
@ 2015-02-20 8:25 ` Jani Nikula
2015-02-20 17:00 ` Todd Previte
0 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2015-02-20 8:25 UTC (permalink / raw)
To: Todd Previte, intel-gfx
On Thu, 19 Feb 2015, Todd Previte <tprevite@gmail.com> wrote:
> Just some formatting issues that need to be cleaned up. Otherwise the
> definitions look correct according to the eDP 1.4 spec.
Actually the formatting seems to be in line with the rest of that
particular file.
BR,
Jani.
>
> -T
>
> On 2/19/15 12:46 AM, Sonika Jindal wrote:
>> Adding dpcd macros related to edp1.4 and link rates
>>
>> v2: Added DP_SUPPORTED_LINK_RATES macros
>>
>> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
>> ---
>> include/drm/drm_dp_helper.h | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>> index 11f8c84..77a55e2 100644
>> --- a/include/drm/drm_dp_helper.h
>> +++ b/include/drm/drm_dp_helper.h
>> @@ -92,6 +92,9 @@
>> # define DP_MSA_TIMING_PAR_IGNORED (1 << 6) /* eDP */
>> # define DP_OUI_SUPPORT (1 << 7)
>>
>> +#define DP_SUPPORTED_LINK_RATES 0x010 /*eDP 1.4*/
>> +#define DP_MAX_SUPPORTED_RATES 0x8
>> +
> Extra blank line
>> #define DP_I2C_SPEED_CAP 0x00c /* DPI */
>> # define DP_I2C_SPEED_1K 0x01
>> # define DP_I2C_SPEED_5K 0x02
>> @@ -101,6 +104,7 @@
>> # define DP_I2C_SPEED_1M 0x20
>>
>> #define DP_EDP_CONFIGURATION_CAP 0x00d /* XXX 1.2? */
>> +# define DP_DPCD_DISPLAY_CONTROL_CAPABLE (1 << 3) /* edp v1.2 or higher */
> Remove the space between # and define.
>> #define DP_TRAINING_AUX_RD_INTERVAL 0x00e /* XXX 1.2? */
>>
>> /* Multiple stream transport */
>> @@ -221,6 +225,8 @@
>> # define DP_UP_REQ_EN (1 << 1)
>> # define DP_UPSTREAM_IS_SRC (1 << 2)
>>
>> +#define DP_LINK_RATE_SET 0x115
>> +
> Extra blank line
>> #define DP_PSR_EN_CFG 0x170 /* XXX 1.2? */
>> # define DP_PSR_ENABLE (1 << 0)
>> # define DP_PSR_MAIN_LINK_ACTIVE (1 << 1)
>> @@ -332,6 +338,8 @@
>> # define DP_SET_POWER_D3 0x2
>> # define DP_SET_POWER_MASK 0x3
>>
>> +#define DP_EDP_DPCD_REV 0x700
>> +
> Extra blank line
>> #define DP_SIDEBAND_MSG_DOWN_REQ_BASE 0x1000 /* 1.2 MST */
>> #define DP_SIDEBAND_MSG_UP_REP_BASE 0x1200 /* 1.2 MST */
>> #define DP_SIDEBAND_MSG_DOWN_REP_BASE 0x1400 /* 1.2 MST */
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Adding edp1.4 specific dpcd macros
2015-02-20 8:25 ` Jani Nikula
@ 2015-02-20 17:00 ` Todd Previte
2015-02-23 23:51 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Todd Previte @ 2015-02-20 17:00 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
On 2/20/2015 1:25 AM, Jani Nikula wrote:
> On Thu, 19 Feb 2015, Todd Previte <tprevite@gmail.com> wrote:
>> Just some formatting issues that need to be cleaned up. Otherwise the
>> definitions look correct according to the eDP 1.4 spec.
> Actually the formatting seems to be in line with the rest of that
> particular file.
>
> BR,
> Jani.
Interesting. Looks like there's some inconsistency in that header then.
But if the formatting isn't an issue, it's otherwise correct.
Reviewed-by: Todd Previte <tprevite@gmail.com>
>> -T
>>
>> On 2/19/15 12:46 AM, Sonika Jindal wrote:
>>> Adding dpcd macros related to edp1.4 and link rates
>>>
>>> v2: Added DP_SUPPORTED_LINK_RATES macros
>>>
>>> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
>>> ---
>>> include/drm/drm_dp_helper.h | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>>> index 11f8c84..77a55e2 100644
>>> --- a/include/drm/drm_dp_helper.h
>>> +++ b/include/drm/drm_dp_helper.h
>>> @@ -92,6 +92,9 @@
>>> # define DP_MSA_TIMING_PAR_IGNORED (1 << 6) /* eDP */
>>> # define DP_OUI_SUPPORT (1 << 7)
>>>
>>> +#define DP_SUPPORTED_LINK_RATES 0x010 /*eDP 1.4*/
>>> +#define DP_MAX_SUPPORTED_RATES 0x8
>>> +
>> Extra blank line
>>> #define DP_I2C_SPEED_CAP 0x00c /* DPI */
>>> # define DP_I2C_SPEED_1K 0x01
>>> # define DP_I2C_SPEED_5K 0x02
>>> @@ -101,6 +104,7 @@
>>> # define DP_I2C_SPEED_1M 0x20
>>>
>>> #define DP_EDP_CONFIGURATION_CAP 0x00d /* XXX 1.2? */
>>> +# define DP_DPCD_DISPLAY_CONTROL_CAPABLE (1 << 3) /* edp v1.2 or higher */
>> Remove the space between # and define.
>>> #define DP_TRAINING_AUX_RD_INTERVAL 0x00e /* XXX 1.2? */
>>>
>>> /* Multiple stream transport */
>>> @@ -221,6 +225,8 @@
>>> # define DP_UP_REQ_EN (1 << 1)
>>> # define DP_UPSTREAM_IS_SRC (1 << 2)
>>>
>>> +#define DP_LINK_RATE_SET 0x115
>>> +
>> Extra blank line
>>> #define DP_PSR_EN_CFG 0x170 /* XXX 1.2? */
>>> # define DP_PSR_ENABLE (1 << 0)
>>> # define DP_PSR_MAIN_LINK_ACTIVE (1 << 1)
>>> @@ -332,6 +338,8 @@
>>> # define DP_SET_POWER_D3 0x2
>>> # define DP_SET_POWER_MASK 0x3
>>>
>>> +#define DP_EDP_DPCD_REV 0x700
>>> +
>> Extra blank line
>>> #define DP_SIDEBAND_MSG_DOWN_REQ_BASE 0x1000 /* 1.2 MST */
>>> #define DP_SIDEBAND_MSG_UP_REP_BASE 0x1200 /* 1.2 MST */
>>> #define DP_SIDEBAND_MSG_DOWN_REP_BASE 0x1400 /* 1.2 MST */
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Adding edp1.4 specific dpcd macros
2015-02-20 17:00 ` Todd Previte
@ 2015-02-23 23:51 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2015-02-23 23:51 UTC (permalink / raw)
To: Todd Previte; +Cc: intel-gfx, DRI Development
Aside: reply-all seems to not work (or maybe you have reply-to-list as
default), dri-devel was lost. Readded.
On Fri, Feb 20, 2015 at 10:00:48AM -0700, Todd Previte wrote:
>
> On 2/20/2015 1:25 AM, Jani Nikula wrote:
> >On Thu, 19 Feb 2015, Todd Previte <tprevite@gmail.com> wrote:
> >>Just some formatting issues that need to be cleaned up. Otherwise the
> >>definitions look correct according to the eDP 1.4 spec.
> >Actually the formatting seems to be in line with the rest of that
> >particular file.
> >
> >BR,
> >Jani.
> Interesting. Looks like there's some inconsistency in that header then. But
> if the formatting isn't an issue, it's otherwise correct.
>
> Reviewed-by: Todd Previte <tprevite@gmail.com>
Queued to drm-misc, thanks for patch&review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-23 23:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-19 7:46 [PATCH] drm: Adding edp1.4 specific dpcd macros Sonika Jindal
2015-02-19 10:31 ` shuang.he
2015-02-19 17:46 ` Todd Previte
2015-02-20 8:25 ` Jani Nikula
2015-02-20 17:00 ` Todd Previte
2015-02-23 23:51 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox