From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915: Keep the forcewake timer alive for 1ms past the most recent use Date: Mon, 15 May 2017 11:14:32 +0100 Message-ID: <89d267a6-ff99-c727-1b59-4e2108ee61a2@linux.intel.com> References: <20170512135335.20099-2-chris@chris-wilson.co.uk> <20170512221641.2937-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45D6A6E1BC for ; Mon, 15 May 2017 10:14:38 +0000 (UTC) In-Reply-To: <20170512221641.2937-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEyLzA1LzIwMTcgMjM6MTYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBDdXJyZW50bHkgdGhl IHRpbWVyIGlzIGFybWVkIGZvciAxbXMgYWZ0ZXIgdGhlIGZpcnN0IHVzZSBhbmQgaXMga2lsbGVk Cj4gaW1tZWRpYXRlbHksIGRyb3BwaW5nIHRoZSBmb3JjZXdha2UgYXMgZWFybHkgYXMgcG9zc2li bGUuIEhvd2V2ZXIsIGZvcgoKQ29ycmVjdCBmb3IgaW1wbGljaXQgZ3JhYnMsIGJ1dCBmb3IgZXhw bGljaXQgaXQgaXMgMS0ybXMgYWZ0ZXIgdGhlIGxhc3QgdXNlLgoKPiB2ZXJ5IGZyZXF1ZW50IG9w ZXJhdGlvbnMgdGhlIGZvcmNld2FrZSBkYW5jZSBoYXMgYSBsYXJnZSBpbXBhY3Qgb24KPiBsYXRl bmN5IGFuZCBrZWVwaW5nIHRoZSB0aW1lciBhbGl2ZSB1bnRpbCB3ZSBhcmUgaWRsZSBpcyBwcmVm ZXJyZWQuIFRvCgpXaGF0IHdvcmtsb2FkcyBzZWUgdGhlIGRpZmZlcmVuY2UgYW5kIGJ5IGhvdyBt dWNoPwoKQXQgdGhlIHRpbWUgSSd2ZSBmaXhlZCB0aGUgYXV0by1yZWxlYXNlIHRvIGdvIGZyb20g MC0xIGppZmZpZXMgdG8gMS0ybXMsIAp3ZSB0YWxrZWQgYWJvdXQgdGhpcyBjb251bmRydW0gLSB3 aGV0aGVyIHRvIGNvbnNpZGVyIHRoZSBmaXJzdCBncmFiIG9yIApsYXN0IHB1dCBmb3IgdGhlIHRp bWVyLiBCdXQgd2UgZGVjaWRlZCB0aG9yb3VnaCB0ZXN0aW5nIGlzIG5lZWRlZCB0byBzZWUgCmlm IHRoaXMgd291bGQgbWFrZSBhIGRpZmZlcmVuY2UgYW5kIHdoYXQgcG93ZXIgc2lkZSBlZmZlY3Rz IGl0IG1pZ2h0IGhhdmUuCgo+IGFjaGlldmUgdGhpcywgaWYgd2UgY2FsbCBpbnRlbF91bmNvcmVf Zm9yY2V3YWtlX2dldCB3aGlsc3QgdGhlIHRpbWVyIGlzCj4gYWxpdmUgKHJlcGVhdGVkIHVzZSks IHRoZW4gc2V0IGEgZmxhZyB0byByZXN0YXJ0IHRoZSB0aW1lciBvbiBleHBpcnkKPiByYXRoZXIg dGhhbiBkcm9wIHRoZSBmb3JjZXdha2UgdXNhZ2UgY291bnQuIFRoZSB0aW1lciBpcyByYWN5LCB0 aGUKPiBjb25zZXF1ZW5jZSBvZiB0aGUgcmFjZSBpcyB0byBleHBpcmUgdGhlIHRpbWVyIGVhcmxp ZXIgdGhhbiBpcyBub3cKPiBkZXNpcmVkIGJ1dCBkb2VzIG5vdCBpbXBhY3Qgb24gY29ycmVjdCBi ZWhhdmlvdXIuIFRoZSBvZmZzZXQgdGhlIHJhY2UKPiBzbGlnaHRseSwgd2Ugc2V0IHRoZSBhY3Rp dmUgZmxhZyBhZ2FpbiBvbiBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3B1dC4KClVzaW5nIHRoZSBo cnRpbWVyIEFQSSB0byBtb2RpZnkgdGhlIHRpbWVyIHdhcyB0b28gZXhwZW5zaXZlPwoKPgo+IFNp Z25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENj OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KPiBDYzogVHZydGtvIFVy c3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfdW5jb3JlLmMgfCAxNSArKysrKysrKysrKystLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmggfCAgMSArCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF91bmNvcmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29y ZS5jCj4gaW5kZXggN2VhYTU5MmFlZDI2Li4yZmQwOTg5ODA1ZWIgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF91bmNvcmUuYwo+IEBAIC0yMTYsNiArMjE2LDkgQEAgaW50ZWxfdW5jb3JlX2Z3 X3JlbGVhc2VfdGltZXIoc3RydWN0IGhydGltZXIgKnRpbWVyKQo+Cj4gIAlhc3NlcnRfcnBtX2Rl dmljZV9ub3Rfc3VzcGVuZGVkKGRldl9wcml2KTsKPgo+ICsJaWYgKHhjaGcoJmRvbWFpbi0+YWN0 aXZlLCBmYWxzZSkpCj4gKwkJcmV0dXJuIEhSVElNRVJfUkVTVEFSVDsKPiArCj4gIAlzcGluX2xv Y2tfaXJxc2F2ZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4gIAlpZiAoV0FS Tl9PTihkb21haW4tPndha2VfY291bnQgPT0gMCkpCj4gIAkJZG9tYWluLT53YWtlX2NvdW50Kys7 Cj4gQEAgLTI0Niw2ICsyNDksNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF91bmNvcmVfZm9yY2V3YWtl X3Jlc2V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQlhY3RpdmVfZG9t YWlucyA9IDA7Cj4KPiAgCQlmb3JfZWFjaF9md19kb21haW4oZG9tYWluLCBkZXZfcHJpdiwgdG1w KSB7Cj4gKwkJCXNtcF9zdG9yZV9tYihkb21haW4tPmFjdGl2ZSwgZmFsc2UpOwo+ICAJCQlpZiAo aHJ0aW1lcl9jYW5jZWwoJmRvbWFpbi0+dGltZXIpID09IDApCj4gIAkJCQljb250aW51ZTsKPgo+ IEBAIC00NTMsOSArNDU3LDEyIEBAIHN0YXRpYyB2b2lkIF9faW50ZWxfdW5jb3JlX2ZvcmNld2Fr ZV9nZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+Cj4gIAlmd19kb21haW5z ICY9IGRldl9wcml2LT51bmNvcmUuZndfZG9tYWluczsKPgo+IC0JZm9yX2VhY2hfZndfZG9tYWlu X21hc2tlZChkb21haW4sIGZ3X2RvbWFpbnMsIGRldl9wcml2LCB0bXApCj4gLQkJaWYgKGRvbWFp bi0+d2FrZV9jb3VudCsrKQo+ICsJZm9yX2VhY2hfZndfZG9tYWluX21hc2tlZChkb21haW4sIGZ3 X2RvbWFpbnMsIGRldl9wcml2LCB0bXApIHsKPiArCQlpZiAoZG9tYWluLT53YWtlX2NvdW50Kysp IHsKPiAgCQkJZndfZG9tYWlucyAmPSB+ZG9tYWluLT5tYXNrOwo+ICsJCQlkb21haW4tPmFjdGl2 ZSA9IHRydWU7Cj4gKwkJfQo+ICsJfQo+Cj4gIAlpZiAoZndfZG9tYWlucykKPiAgCQlkZXZfcHJp di0+dW5jb3JlLmZ1bmNzLmZvcmNlX3dha2VfZ2V0KGRldl9wcml2LCBmd19kb21haW5zKTsKPiBA QCAtNTIwLDggKzUyNywxMCBAQCBzdGF0aWMgdm9pZCBfX2ludGVsX3VuY29yZV9mb3JjZXdha2Vf cHV0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQlpZiAoV0FSTl9PTihk b21haW4tPndha2VfY291bnQgPT0gMCkpCj4gIAkJCWNvbnRpbnVlOwo+Cj4gLQkJaWYgKC0tZG9t YWluLT53YWtlX2NvdW50KQo+ICsJCWlmICgtLWRvbWFpbi0+d2FrZV9jb3VudCkgewo+ICsJCQlk b21haW4tPmFjdGl2ZSA9IHRydWU7Cj4gIAkJCWNvbnRpbnVlOwo+ICsJCX0KPgo+ICAJCWZ3X2Rv bWFpbl9hcm1fdGltZXIoZG9tYWluKTsKPiAgCX0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNv cmUuaAo+IGluZGV4IDVmZWM1ZmQ0MzQ2Yy4uZGZlYWQ1ODU4MzVjIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfdW5jb3JlLmgKPiBAQCAtOTUsNiArOTUsNyBAQCBzdHJ1Y3QgaW50ZWxfdW5j b3JlIHsKPiAgCXN0cnVjdCBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX2RvbWFpbiB7Cj4gIAkJdW5z aWduZWQgaW50IG1hc2s7Cj4gIAkJdW5zaWduZWQgaW50IHdha2VfY291bnQ7Cj4gKwkJYm9vbCBh Y3RpdmU7Cj4gIAkJc3RydWN0IGhydGltZXIgdGltZXI7Cj4gIAkJaTkxNV9yZWdfdCByZWdfc2V0 Owo+ICAJCWk5MTVfcmVnX3QgcmVnX2FjazsKPgoKTWludXMgdGhlIHBvc3NpYmxlIGNvbW1pdCBt ZXNzYWdlIGltcHJvdmVtZW50cyBhbmQgZGlzY3Vzc2lvbiBsb29rcyAKY29ycmVjdCB0byBtZS4K ClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==