From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E40CCC47092 for ; Wed, 2 Jun 2021 09:47:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF5C16135D for ; Wed, 2 Jun 2021 09:47:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF5C16135D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DEA756EC2F; Wed, 2 Jun 2021 09:47:43 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 617BE6EC2D; Wed, 2 Jun 2021 09:47:42 +0000 (UTC) IronPort-SDR: s+vYGZ8ICa6uF1EWTislj6OkJZx4QTx5l4CA9jK8FCsf1YiQ1TtjDdZuQ1W24Hr/8x45KdfuYH 19rhZNvgCeJw== X-IronPort-AV: E=McAfee;i="6200,9189,10002"; a="203744387" X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="203744387" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2021 02:47:41 -0700 IronPort-SDR: izP+4q7UrhyR30hsfFIHklnfrXF06OeU1tw5tPSRiWGTMgqPpJT9HcDNzoZMTcIWE0pdvO1v/U 0ut49Bah7dcw== X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="447337278" Received: from tstaplex-mobl1.ger.corp.intel.com (HELO [10.213.195.193]) ([10.213.195.193]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2021 02:47:37 -0700 To: "Ursulin, Tvrtko" , Zhihao Cheng , "jani.nikula@linux.intel.com" , "joonas.lahtinen@linux.intel.com" , "Vivi, Rodrigo" , "airlied@linux.ie" , "daniel@ffwll.ch" , "chris@chris-wilson.co.uk" References: <20210529043327.2772051-1-chengzhihao1@huawei.com> <33c46ef24cd547d0ad21dc106441491a@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <8abf5ddf-7c08-c2c0-92d4-d6c30058763c@linux.intel.com> Date: Wed, 2 Jun 2021 10:47:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <33c46ef24cd547d0ad21dc106441491a@intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "yukuai3@huawei.com" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 01/06/2021 10:19, Ursulin, Tvrtko wrote: > > [Don't see this on intel-gfx so I have to reply with top post.] > > Reviewed-by: Tvrtko Ursulin Pushed with commit text wrapped and Fixes: tag fixed, thanks for the patch! Regards, Tvrtko > > -----Original Message----- > From: Zhihao Cheng > Sent: Saturday, May 29, 2021 5:33 AM > To: jani.nikula@linux.intel.com; joonas.lahtinen@linux.intel.com; Vivi, Rodrigo ; airlied@linux.ie; daniel@ffwll.ch; chris@chris-wilson.co.uk; Ursulin, Tvrtko > Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; chengzhihao1@huawei.com; yukuai3@huawei.com > Subject: [PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest() > > In case of error, the function live_context() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). > > Fixes: 52c0fdb25c7c9 ("drm/i915: Replace global breadcrumbs ...") > Reported-by: Hulk Robot > Signed-off-by: Zhihao Cheng > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c > index ee8e753d98ce..eae0abd614cb 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_request.c > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c > @@ -1592,8 +1592,8 @@ static int live_breadcrumbs_smoketest(void *arg) > > for (n = 0; n < smoke[0].ncontexts; n++) { > smoke[0].contexts[n] = live_context(i915, file); > - if (!smoke[0].contexts[n]) { > - ret = -ENOMEM; > + if (IS_ERR(smoke[0].contexts[n])) { > + ret = PTR_ERR(smoke[0].contexts[n]); > goto out_contexts; > } > } > -- > 2.25.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx